[Django] #35265: Adjust unit tests on admin custom site titles

7 views
Skip to first unread message

Django

unread,
Mar 3, 2024, 6:58:43 AM3/3/24
to django-...@googlegroups.com
#35265: Adjust unit tests on admin custom site titles
-----------------------------------------+------------------------
Reporter: Kasun Herath | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-----------------------------------------+------------------------
Commit
[https://github.com/django/django/commit/a962286b74f1e8c8cb19fb45a057800da8c2fb56
commit] introduced attributes to {{{AdminSite}}} class that can control
site header, site title and index title.
[https://github.com/django/django/blob/main/django/contrib/admin/sites.py#L29
AdminSite]

But the corresponding unit test still checks for the default site titles
not for the attributes on the site instance.
[https://github.com/django/django/blob/main/tests/admin_views/test_adminsite.py#L41]
--
Ticket URL: <https://code.djangoproject.com/ticket/35265>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Mar 3, 2024, 7:02:36 AM3/3/24
to django-...@googlegroups.com
#35265: Adjust unit tests on admin custom site titles
-------------------------------+--------------------------------------
Reporter: Kasun Herath | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by Kasun Herath):

* version: 5.0 => dev

--
Ticket URL: <https://code.djangoproject.com/ticket/35265#comment:1>

Django

unread,
Mar 3, 2024, 7:10:11 AM3/3/24
to django-...@googlegroups.com
#35265: Adjust unit tests on admin custom site titles
-------------------------------+----------------------------------------
Reporter: Kasun Herath | Owner: Kasun Herath
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+----------------------------------------
Changes (by Kasun Herath):

* owner: nobody => Kasun Herath
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35265#comment:2>
Reply all
Reply to author
Forward
0 new messages