Re: [Django] #35224: Make GenericForeignKey a subclass of Field

[Django]

#35224: Make GenericForeignKey a subclass of Field
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: nobody
Type: | Status: assigned
Cleanup/optimization |
Component: | Version: dev
contrib.contenttypes |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Adam Johnson):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35224#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#35224: Make GenericForeignKey a subclass of Field

--------------------------------------+------------------------------------

Reporter: Adam Johnson | Owner: nobody

Type: Cleanup/optimization | Status: assigned
Component: contrib.contenttypes | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

--------------------------------------+------------------------------------
Changes (by Simon Charette):

* stage: Unreviewed => Accepted

Comment:

I'm eager to see what the test suite says but it seems like a worth
cleanup!
--
Ticket URL: <https://code.djangoproject.com/ticket/35224#comment:4>

[Django]

#35224: Make GenericForeignKey a subclass of Field

-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Dylan
Type: | Patrick Go
Cleanup/optimization | Status: assigned
Component: | Version: dev
contrib.contenttypes |

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Dylan Patrick Go):

* owner: nobody => Dylan Patrick Go

--
Ticket URL: <https://code.djangoproject.com/ticket/35224#comment:5>

[Django]

#35224: Make GenericForeignKey a subclass of Field
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Dylan
Type: | Patrick Go
Cleanup/optimization | Status: assigned
Component: | Version: dev
contrib.contenttypes |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Adam Johnson):

There’s an open PR, the tests all pass.
--
Ticket URL: <https://code.djangoproject.com/ticket/35224#comment:6>

[Django]

#35224: Make GenericForeignKey a subclass of Field

--------------------------------------+------------------------------------
Reporter: Adam Johnson | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: contrib.contenttypes | Version: dev

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

--------------------------------------+------------------------------------

Changes (by Dylan Patrick Go):

* owner: Dylan Patrick Go => (none)
* status: assigned => new

--
Ticket URL: <https://code.djangoproject.com/ticket/35224#comment:7>

[Django]

#35224: Make GenericForeignKey a subclass of Field

-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Adam
Type: | Johnson

Cleanup/optimization | Status: assigned
Component: | Version: dev
contrib.contenttypes |

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Adam Johnson):

* owner: (none) => Adam Johnson
* status: new => assigned

Comment:

Dylan, I already attached a PR to this ticket.
--
Ticket URL: <https://code.djangoproject.com/ticket/35224#comment:8>

[Django]

#35224: Make GenericForeignKey a subclass of Field
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Adam
Type: | Johnson
Cleanup/optimization | Status: assigned
Component: | Version: dev
contrib.contenttypes |
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35224#comment:9>

[Django]

#35224: Make GenericForeignKey a subclass of Field
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Adam
Type: | Johnson

Cleanup/optimization | Status: closed
Component: | Version: dev
contrib.contenttypes |
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"6002df06713cb0a7050432263527a25754190c27" 6002df06]:
{{{#!CommitTicketReference repository=""
revision="6002df06713cb0a7050432263527a25754190c27"
Fixed #35224 -- Made GenericForeignKey inherit from Field.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35224#comment:10>