Re: [Django] #7732: Oracle Backend with SessionPool

Django

unread,

Feb 17, 2013, 2:01:51 AM2/17/13

to django-...@googlegroups.com

#7732: Oracle Backend with SessionPool
-------------------------------------+-------------------------------------
Reporter: halturin | Owner: mboersma
Type: New feature | Status: assigned
Component: Database layer | Version: master
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: yandex-sprint | Needs documentation: 1
oracle session pool | Patch needs improvement: 1
Has patch: 1 | UI/UX: 0
Needs tests: 1 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by skyl):

I have what may be a more simple approach to the problem. I branched off
of the current django master on github. I can easily remove the extraneous
flake8 changes and squash into one commit for a pull request:

https://github.com/skyl/django/compare/7732-oracle-sessionpool

It appears that the tests will pass against Oracle (takes forever).
However, I'm not that familiar with the ins and outs of how database
backends work. If someone could look at my patch and let me know if there
is something obvious I've missed, I would appreciate it. On a simple test
webapp, I'm experiencing a significant speedup with the patch.

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:13>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,

Feb 17, 2013, 1:49:11 PM2/17/13

to django-...@googlegroups.com

#7732: Oracle Backend with SessionPool
-------------------------------------+-------------------------------------
Reporter: halturin | Owner: mboersma
Type: New feature | Status: assigned
Component: Database layer | Version: master
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: yandex-sprint | Needs documentation: 1
oracle session pool | Patch needs improvement: 1
Has patch: 1 | UI/UX: 0
Needs tests: 1 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by akaariai):

It seems that allowing the use of the cx_Oracle inbuilt pooler is a good
idea.

As for the implementation: is the use of class level pool variable really
safe? It seems the pool instance is connection settings dependent, so
having just one pool per project seems suspicious.

Also, the close() implementation should probably do a rollback before
releasing the connection back to the pool.

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:14>

Django

unread,

Feb 17, 2013, 6:18:23 PM2/17/13

to django-...@googlegroups.com

#7732: Oracle Backend with SessionPool
-------------------------------------+-------------------------------------
Reporter: halturin | Owner: mboersma
Type: New feature | Status: assigned
Component: Database layer | Version: master
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: yandex-sprint | Needs documentation: 1
oracle session pool | Patch needs improvement: 1
Has patch: 1 | UI/UX: 0
Needs tests: 1 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by skyl):

I changed to 1 pool per alias; 1 pool per project was definitely wrong. I
also changed to doing a `self.connection.rollback()` in `close` before
releasing the connection.

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:15>

Django

unread,

Feb 18, 2013, 8:25:26 AM2/18/13

to django-...@googlegroups.com

#7732: Oracle Backend with SessionPool
-------------------------------------+-------------------------------------
Reporter: halturin | Owner: mboersma
Type: New feature | Status: assigned
Component: Database layer | Version: master
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: yandex-sprint | Needs documentation: 1
oracle session pool | Patch needs improvement: 1
Has patch: 1 | UI/UX: 0
Needs tests: 1 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by erny):

I had the following problems in the past: The Oracle pools is a "per
process" pool. Each Python Process gets its own pool. Supposing X
processes (apache prefork, wsgi, etc.) with each Y min connections we get
X * Y connections. So keep your min connections count low. With Oracle 11,
there seems to be a server side session pool which should be much more
convenient, but I didn't test it.

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:16>

Django

unread,

Feb 18, 2013, 1:51:44 PM2/18/13

to django-...@googlegroups.com

#7732: Oracle Backend with SessionPool
-------------------------------------+-------------------------------------
Reporter: halturin | Owner: mboersma
Type: New feature | Status: assigned
Component: Database layer | Version: master
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: yandex-sprint | Needs documentation: 1
oracle session pool | Patch needs improvement: 1
Has patch: 1 | UI/UX: 0
Needs tests: 1 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by skyl):

Unfortunately, I think there needs to be some error-checking on the
connection after it is acquired from the pool. After some hours (I didn't
configure the instance I'm running against so I'm not sure how long), I
get `ORA-02399: exceeded maximum connect time, you are being logged off`;
then, the pool continues to try to get the same connection, failing every
time with, `ORA-01012: not logged on`. I think there are 2 options then.

1) put a `CONN_MAX_AGE` parameter in the `SESSION_POOL` settings dict
and drop the connection if it is close enough to that age
2) ping the connection after it is acquired and drop it if it is not
usable

(1) Age is not an attribute of the connection that I can see; so, it would
be ugly to do our own book-keeping on the age of the connections in the
pools we are holding. This does not cover other possible error scenarios.
(2) This would be a hit to performance every time a connection is
acquired.

I think (2) would be easy enough to add. Other suggestions?

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:17>

Django

unread,

Oct 26, 2014, 5:59:19 AM10/26/14

to django-...@googlegroups.com

#7732: Oracle Backend with SessionPool
-------------------------------------+-------------------------------------
Reporter: halturin | Owner: mboersma
Type: New feature | Status: assigned
Component: Database layer | Version: master
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: yandex-sprint | Needs documentation: 1
oracle session pool | Patch needs improvement: 1
Has patch: 1 | UI/UX: 0
Needs tests: 1 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by thedrow):

Since I believe that adding pooled backends was rejected from Django
shouldn't this issue be closed?

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:18>

Django

unread,

Sep 23, 2016, 11:36:15 AM9/23/16

to django-...@googlegroups.com

#7732: Oracle Backend with SessionPool
-------------------------------------+-------------------------------------

Reporter: halturin | Owner: (none)
Type: New feature | Status: new

Component: Database layer | Version: master
(models, ORM) |

Severity: Normal | Resolution:
Keywords: yandex-sprint | Triage Stage: Accepted
oracle session pool |
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* status: assigned => new
* owner: Matt Boersma => (none)

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:19>

Django

unread,

May 15, 2019, 11:41:05 AM5/15/19

to django-...@googlegroups.com

#7732: Oracle Backend with SessionPool
-------------------------------------+-------------------------------------
Reporter: halturin | Owner: (none)
Type: New feature | Status: new
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: yandex-sprint | Triage Stage: Accepted
oracle session pool |
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Dan Davis):

* cc: Dan Davis (added)

Comment:

I'm interested in this. I'm not quite on the point of assigning it, but
one of my developers asked me see to return to what is needed to use
Oracle DRCP. I tested it using django-oraclepool many years ago to
determine whether there was any performance difference, from the client-
side, between CONN_MAX_AGE and this feature. django-oraclepool is so
old, that it seems I'd either need to fork it or return to this issue.

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:20>

Django

unread,

Aug 31, 2023, 4:07:15 AM8/31/23

to django-...@googlegroups.com

#7732: Oracle Backend with SessionPool
-------------------------------------+-------------------------------------
Reporter: halturin | Owner: (none)
Type: New feature | Status: new

Component: Database layer | Version: dev

Changes (by Mariusz Felisiak):

* cc: Christopher Jones, Suraj Shaw (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:21>

Django

unread,

Jan 16, 2024, 4:52:54 AM1/16/24

to django-...@googlegroups.com

#7732: Oracle Backend with SessionPool
-------------------------------------+-------------------------------------

Reporter: halturin | Owner: Suraj
| Shaw

Type: New feature | Status: assigned

Changes (by Suraj Shaw):

* owner: (none) => Suraj Shaw
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:22>

Django

unread,

Jan 16, 2024, 1:29:23 PM1/16/24

to django-...@googlegroups.com

#7732: Oracle Backend with SessionPool
-------------------------------------+-------------------------------------
Reporter: halturin | Owner: Suraj
| Shaw
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: yandex-sprint | Triage Stage: Accepted
oracle session pool |
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Suraj Shaw):

* Attachment "Session Pool Backend in Django For Oracle (1).docx" added.

Design specification

--
Ticket URL: <https://code.djangoproject.com/ticket/7732>

Django

unread,

Jan 16, 2024, 1:48:00 PM1/16/24

to django-...@googlegroups.com

#7732: Oracle Backend with SessionPool
-------------------------------------+-------------------------------------
Reporter: halturin | Owner: Suraj
| Shaw
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: yandex-sprint | Triage Stage: Accepted
oracle session pool |
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Suraj Shaw):

[https://github.com/django/django/pull/17743 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:23>

Django

unread,

Feb 13, 2024, 5:36:06 AM2/13/24

to django-...@googlegroups.com

#7732: Oracle Backend with SessionPool
-------------------------------------+-------------------------------------
Reporter: halturin | Owner: Suraj
| Shaw
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: yandex-sprint | Triage Stage: Accepted
oracle session pool |

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Suraj Shaw):

* needs_docs: 1 => 0
* has_patch: 1 => 0
* needs_tests: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:24>

Django

unread,

Feb 15, 2024, 4:16:11 AM2/15/24

to django-...@googlegroups.com

#7732: Oracle Backend with SessionPool
-------------------------------------+-------------------------------------
Reporter: halturin | Owner: Suraj
| Shaw
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: yandex-sprint | Triage Stage: Accepted
oracle session pool |

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Suraj Shaw):

* needs_better_patch: 1 => 0
* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:25>

Django

unread,

Feb 15, 2024, 5:09:17 AM2/15/24

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:26>

Django

unread,

Feb 18, 2024, 11:45:39 PM2/18/24

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Suraj Shaw):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:27>

Django

unread,

Feb 28, 2024, 8:11:38 AM2/28/24

to django-...@googlegroups.com

Needs tests: 1 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1

* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:28>

Django

unread,

Mar 15, 2024, 1:05:48 AM3/15/24

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Suraj Shaw):

* needs_better_patch: 1 => 0

* needs_tests: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:29>

Django

unread,

Mar 18, 2024, 6:48:50 AM3/18/24

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:30>

Django

unread,

Mar 26, 2024, 3:19:20 PM3/26/24

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Suraj Shaw):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:31>

Django

unread,

Apr 3, 2024, 6:51:02 AM4/3/24

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:32>

Django

unread,

Apr 8, 2024, 4:34:14 AM4/8/24

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Suraj Shaw):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:33>

Django

unread,

Apr 11, 2024, 11:24:57 AM4/11/24

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:34>

Django

unread,

Apr 16, 2024, 11:49:19 AM4/16/24

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Suraj Shaw):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:35>

Django

unread,

Aug 14, 2024, 4:24:50 AM8/14/24

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:36>

Django

unread,

Aug 27, 2024, 11:54:33 AM8/27/24

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Suraj Shaw):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:37>

Django

unread,

Aug 30, 2024, 2:47:36 AM8/30/24

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:38>

Django

unread,

Sep 9, 2024, 12:15:23 AM9/9/24

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Suraj Shaw):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:39>

Django

unread,

Sep 9, 2024, 4:18:56 AM9/9/24

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:40>

Django

unread,

Sep 9, 2024, 1:17:53 PM9/9/24

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Suraj Shaw):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:41>

Django

unread,

Dec 9, 2024, 10:56:34 AM12/9/24

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:42>

Django

unread,

Dec 11, 2024, 4:44:38 AM12/11/24

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:43>

Django

unread,

Dec 11, 2024, 4:58:54 AM12/11/24

to django-...@googlegroups.com

Keywords: yandex-sprint | Triage Stage: Ready for
oracle session pool | checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:44>

Django

unread,

Dec 17, 2024, 5:26:42 AM12/17/24

to django-...@googlegroups.com

#7732: Oracle Backend with SessionPool
-------------------------------------+-------------------------------------
Reporter: halturin | Owner: Suraj
| Shaw

Type: New feature | Status: closed

Component: Database layer | Version: dev
(models, ORM) |

Severity: Normal | Resolution: fixed

Keywords: yandex-sprint | Triage Stage: Ready for
oracle session pool | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"0d9872fc9a70ef6966930c68c68febea7eb60ede" 0d9872fc]:
{{{#!CommitTicketReference repository=""
revision="0d9872fc9a70ef6966930c68c68febea7eb60ede"
Fixed #7732 -- Added support for connection pools on Oracle.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/7732#comment:45>

Reply all

Reply to author

Forward