Re: [Django] #35179: Admindocs does not recognize methods containing positional-only arguments or keyword-only arguments as such

[Django]

#35179: Admindocs does not recognize methods containing positional-only arguments
or keyword-only arguments as such
-----------------------------------+------------------------------------
Reporter: David Sanders | Owner: nobody
Type: Bug | Status: new
Component: contrib.admindocs | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
Changes (by Salvo Polizzi):

* has_patch: 0 => 1
* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35179#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#35179: Admindocs does not recognize methods containing positional-only arguments
or keyword-only arguments as such
-----------------------------------+------------------------------------
Reporter: David Sanders | Owner: nobody
Type: Bug | Status: new
Component: contrib.admindocs | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
Changes (by Salvo Polizzi):

* needs_tests: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/35179#comment:5>

[Django]

#35179: Admindocs does not recognize methods containing positional-only arguments
or keyword-only arguments as such
-----------------------------------+------------------------------------
Reporter: David Sanders | Owner: nobody
Type: Bug | Status: new
Component: contrib.admindocs | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 1 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------

Changes (by David Sanders):

* needs_better_patch: 0 => 1

* needs_tests: 0 => 1

Comment:

Hi Salvo,

Thanks for picking this up. You're in the right areaa but the patch
provided appears to break the patched functions.

My advice is to start with creating a test for admindocs first then take a
look at the function `method_has_no_args()`. The fix should be the same
for ticket #35175 👍
--
Ticket URL: <https://code.djangoproject.com/ticket/35179#comment:6>

[Django]

#35179: Admindocs does not recognize methods containing positional-only arguments
or keyword-only arguments as such
-----------------------------------+------------------------------------
Reporter: David Sanders | Owner: nobody
Type: Bug | Status: new
Component: contrib.admindocs | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------

Changes (by Salvo Polizzi):

* needs_better_patch: 1 => 0

* needs_tests: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/35179#comment:7>

[Django]

#35179: Admindocs does not recognize methods containing positional-only arguments
or keyword-only arguments as such

-------------------------------------+-------------------------------------
Reporter: David Sanders | Owner: Salvo
| Polizzi
Type: Bug | Status: assigned

Component: contrib.admindocs | Version: dev
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* owner: nobody => Salvo Polizzi
* status: new => assigned
* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35179#comment:8>

[Django]

#35179: Admindocs does not recognize methods containing positional-only arguments
or keyword-only arguments as such
-------------------------------------+-------------------------------------
Reporter: David Sanders | Owner: Salvo
| Polizzi

Type: Bug | Status: closed
Component: contrib.admindocs | Version: dev
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"e6fa74f02068b2c112de41e9c785f31041668a64" e6fa74f]:
{{{#!CommitTicketReference repository=""
revision="e6fa74f02068b2c112de41e9c785f31041668a64"
Fixed #35179 -- Made admindocs detect positional/keyword-only arguments.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35179#comment:9>