Re: [Django] #35172: intcomma adds leading comma for string-based 3-digit number with at least 1 decimal place.

[Django]

#35172: intcomma adds leading comma for string-based 3-digit number with at least 1
decimal place.
-------------------------------------+-------------------------------------
Reporter: Warwick Brown | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: contrib.humanize | Version: 3.2
Severity: Release blocker | Resolution:
Keywords: humanize intcomma | Triage Stage: Accepted
comma decimal places |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* owner: nobody => Mariusz Felisiak
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35172#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#35172: intcomma adds leading comma for string-based 3-digit number with at least 1
decimal place.
-------------------------------------+-------------------------------------
Reporter: Warwick Brown | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: contrib.humanize | Version: 3.2
Severity: Release blocker | Resolution:
Keywords: humanize intcomma | Triage Stage: Accepted
comma decimal places |

Has patch: 1 | Needs documentation: 1

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_docs: 0 => 1
* has_patch: 0 => 1

Comment:

[https://github.com/django/django/pull/17833 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/35172#comment:4>

[Django]

#35172: intcomma adds leading comma for string-based 3-digit number with at least 1
decimal place.
-------------------------------------+-------------------------------------
Reporter: Warwick Brown | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: contrib.humanize | Version: 3.2
Severity: Release blocker | Resolution:
Keywords: humanize intcomma | Triage Stage: Accepted
comma decimal places |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_docs: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/35172#comment:5>

[Django]

#35172: intcomma adds leading comma for string-based 3-digit number with at least 1
decimal place.
-------------------------------------+-------------------------------------
Reporter: Warwick Brown | Owner: Mariusz
| Felisiak

Type: Bug | Status: closed
Component: contrib.humanize | Version: 3.2
Severity: Release blocker | Resolution: fixed

Keywords: humanize intcomma | Triage Stage: Accepted
comma decimal places |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"2f14c2cedc9c92373471c1f98a80c81ba299584a" 2f14c2ce]:
{{{#!CommitTicketReference repository=""
revision="2f14c2cedc9c92373471c1f98a80c81ba299584a"
Fixed #35172 -- Fixed intcomma for string floats.

Thanks Warwick Brown for the report.

Regression in 55519d6cf8998fe4c8f5c8abffc2b10a7c3d14e9.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35172#comment:6>

[Django]

#35172: intcomma adds leading comma for string-based 3-digit number with at least 1
decimal place.
-------------------------------------+-------------------------------------
Reporter: Warwick Brown | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: contrib.humanize | Version: 3.2
Severity: Release blocker | Resolution: fixed
Keywords: humanize intcomma | Triage Stage: Accepted
comma decimal places |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"c22075af803e031e2977ed93391c2e3c6a714df4" c22075af]:
{{{#!CommitTicketReference repository=""
revision="c22075af803e031e2977ed93391c2e3c6a714df4"
[5.0.x] Fixed #35172 -- Fixed intcomma for string floats.

Thanks Warwick Brown for the report.

Regression in 55519d6cf8998fe4c8f5c8abffc2b10a7c3d14e9.
Backport of 2f14c2cedc9c92373471c1f98a80c81ba299584a from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35172#comment:7>

[Django]

#35172: intcomma adds leading comma for string-based 3-digit number with at least 1
decimal place.
-------------------------------------+-------------------------------------
Reporter: Warwick Brown | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: contrib.humanize | Version: 3.2
Severity: Release blocker | Resolution: fixed
Keywords: humanize intcomma | Triage Stage: Accepted
comma decimal places |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"cb173bb088e32df3d9ee8bee3c579d88ea713e8f" cb173bb0]:
{{{#!CommitTicketReference repository=""
revision="cb173bb088e32df3d9ee8bee3c579d88ea713e8f"
[4.2.x] Fixed #35172 -- Fixed intcomma for string floats.

Thanks Warwick Brown for the report.

Regression in 55519d6cf8998fe4c8f5c8abffc2b10a7c3d14e9.

Backport of 2f14c2cedc9c92373471c1f98a80c81ba299584a from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35172#comment:8>

[Django]

#35172: intcomma adds leading comma for string-based 3-digit number with at least 1
decimal place.
-------------------------------------+-------------------------------------
Reporter: Warwick Brown | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: contrib.humanize | Version: 3.2
Severity: Release blocker | Resolution: fixed
Keywords: humanize intcomma | Triage Stage: Accepted
comma decimal places |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"fc41af69a2e49a717ef069a37e1d68b80a6a5d56" fc41af69]:
{{{#!CommitTicketReference repository=""
revision="fc41af69a2e49a717ef069a37e1d68b80a6a5d56"
[3.2.x] Fixed #35172 -- Fixed intcomma for string floats.

Thanks Warwick Brown for the report.

Regression in 55519d6cf8998fe4c8f5c8abffc2b10a7c3d14e9.

Backport of 2f14c2cedc9c92373471c1f98a80c81ba299584a from main.
}}}
--

Ticket URL: <https://code.djangoproject.com/ticket/35172#comment:9>

[Django]

#35172: intcomma adds leading comma for string-based 3-digit number with at least 1
decimal place.
-------------------------------------+-------------------------------------
Reporter: Warwick Brown | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: contrib.humanize | Version: 3.2
Severity: Release blocker | Resolution: fixed
Keywords: humanize intcomma | Triage Stage: Accepted
comma decimal places |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Adam Johnson):

Ah, well caught, thank you very much!
--
Ticket URL: <https://code.djangoproject.com/ticket/35172#comment:10>