[Django] #26001: Make ModelAdmin.search_fields do an integer lookup for IntegerFields
Django
------------------------------------------------+------------------------
Reporter: timgraham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
Currently,
[https://github.com/django/django/pull/5883#issuecomment-167767767 all
queries are done as string lookups] which gives something like this on
PostgreSQL, for example:
`("admin_views_pluggablesearchperson"."age"::text) = UPPER(20))`. It would
be more efficient if the admin cast the search value to an integer and
used that for the query.
--
Ticket URL: <https://code.djangoproject.com/ticket/26001>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: timgraham | Owner: akki
Type: Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by akki):
* owner: nobody => akki
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/26001#comment:1>
Django
Reporter: timgraham | Owner: akki
Type: Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by akki):
* has_patch: 0 => 1
Comment:
PR: https://github.com/django/django/pull/6219
--
Ticket URL: <https://code.djangoproject.com/ticket/26001#comment:2>
Django
Reporter: timgraham | Owner: akki
Type: Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by charettes):
I think we should favor the approach suggested in #26184 instead.
--
Ticket URL: <https://code.djangoproject.com/ticket/26001#comment:3>
Django
Reporter: timgraham | Owner: akki
Type: Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
Comment:
I agree, let's revisit this if it doesn't.
--
Ticket URL: <https://code.djangoproject.com/ticket/26001#comment:4>
Django
Reporter: timgraham | Owner:
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by akki):
* owner: akki =>
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/26001#comment:5>
Django
Reporter: Tim Graham | Owner: Krzysztof
Type: | Nazarewski
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by Krzysztof Nazarewski):
* owner: (none) => Krzysztof Nazarewski
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/26001#comment:6>
Django
Reporter: Tim Graham | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by Krzysztof Nazarewski):
* owner: Krzysztof Nazarewski => (none)
* status: assigned => new
Comment:
Related to #26184
--
Ticket URL: <https://code.djangoproject.com/ticket/26001#comment:7>
Django
Reporter: Tim Graham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* needs_better_patch: 1 => 0
* has_patch: 1 => 0
Comment:
As far as I tested, you can now use something like `search_fields =
['votes__exact']` to do the appropriate query, however, if a non-integer
search term is entered, the page crashes with `ValueError invalid literal
for int() with base 10: 'abc'` from `IntegerField.get_prep_value()`.
Probably that exception should be caught in
`ModelAdmin.get_search_results()` and no results returned.
--
Ticket URL: <https://code.djangoproject.com/ticket/26001#comment:5>
Django
Reporter: Tim Graham | Owner: Nick
Type: | Sandford
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Nick Sandford):
* owner: nobody => Nick Sandford
* status: new => assigned
Comment:
PR: [https://github.com/django/django/pull/10339]
--
Ticket URL: <https://code.djangoproject.com/ticket/26001#comment:6>
Django
Reporter: Tim Graham | Owner: Nick
Type: | Sandford
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Nick Sandford):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/26001#comment:7>
Django
Reporter: Tim Graham | Owner: Nick
Type: | Sandford
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/26001#comment:8>
Django
Reporter: Tim Graham | Owner: Nick
Type: | Sandford
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Comment (by Niclas Olofsson):
Replying to [comment:5 Tim Graham]:
> As far as I tested, you can now use something like `search_fields =
['votes__exact']` to do the appropriate query, however, if a non-integer
search term is entered, the page crashes with `ValueError invalid literal
for int() with base 10: 'abc'` from `IntegerField.get_prep_value()`.
Probably that exception should be caught in
`ModelAdmin.get_search_results()` and no results returned.
We have to consider that there might be multiple search fields of mixed
types though, i.e. `search_fields = ['votes__exact', 'title',
'text__contains']`, just so the matches for other fields does not get
discarded just because one of the fields threw an error.
--
Ticket URL: <https://code.djangoproject.com/ticket/26001#comment:9>
Django
string fields.
--------------------------------------+------------------------------------
Reporter: Tim Graham | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* owner: Nick Sandford => (none)
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/26001#comment:10>
Django
string fields.
--------------------------------------+------------------------------------
Reporter: Tim Graham | Owner: (none)
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Comment (by Mariusz Felisiak):
#34191 was a duplicate for `DecimalField`.
--
Ticket URL: <https://code.djangoproject.com/ticket/26001#comment:11>
Django
string fields.
--------------------------------------+------------------------------------
Reporter: Tim Graham | Owner: (none)
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Comment (by mishachernyshov):
Replying to [comment:11 Mariusz Felisiak]:
> #34191 was a duplicate for `DecimalField`.
You can use __iexact instead of __exact for non-string fields, I think, it
even makes sense, because the word `exact` means complete equality even
with type. It works for me.
--
Ticket URL: <https://code.djangoproject.com/ticket/26001#comment:12>
Django
string fields.
--------------------------------------+------------------------------------
Reporter: Tim Graham | Owner: (none)
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Comment (by Sandeep Pal):
can i work on this?
--
Ticket URL: <https://code.djangoproject.com/ticket/26001#comment:13>
Django
string fields.
--------------------------------------+------------------------------------
Type: Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by Saurabh ):
* owner: (none) => Saurabh
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/26001#comment:14>
Django
string fields.
--------------------------------------+------------------------------------
Reporter: Tim Graham | Owner: Saurabh
Type: Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Comment (by Saurabh ):
PR: https://github.com/django/django/pull/17885
--
Ticket URL: <https://code.djangoproject.com/ticket/26001#comment:15>