[Django] #35135: FilteredRelation fails when rhs of the condition is a queryset

[Django]

#35135: FilteredRelation fails when rhs of the condition is a queryset
-------------------------------------+-------------------------------------
Reporter: Nicolas | Owner: nobody
Delaby |
Type: Bug | Status: new
Component: Database | Version: 5.0
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
There is a regression test on the following pr
https://github.com/django/django/pull/17771

--
Ticket URL: <https://code.djangoproject.com/ticket/35135>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#35135: FilteredRelation fails when rhs of the condition is a queryset
-------------------------------------+-------------------------------------

Reporter: Nicolas Delaby | Owner: Nicolas
| Delaby
Type: Bug | Status: assigned
Component: Database layer | Version: 5.0
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* cc: Francesco Panico (added)
* owner: nobody => Nicolas Delaby
* status: new => assigned
* severity: Normal => Release blocker
* stage: Unreviewed => Accepted

Comment:

Thanks for the report.

--
Ticket URL: <https://code.djangoproject.com/ticket/35135#comment:1>

[Django]

#35135: FilteredRelation fails when rhs of the condition is a queryset
-------------------------------------+-------------------------------------
Reporter: Nicolas Delaby | Owner: Nicolas
| Delaby
Type: Bug | Status: assigned
Component: Database layer | Version: 5.0
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak):

Regression in 59f475470494ce5b8cbff816b1e5dafcbd10a3a3.

--
Ticket URL: <https://code.djangoproject.com/ticket/35135#comment:2>

[Django]

#35135: FilteredRelation fails when rhs of the condition is a queryset
-------------------------------------+-------------------------------------
Reporter: Nicolas Delaby | Owner: Nicolas
| Delaby
Type: Bug | Status: assigned
Component: Database layer | Version: 5.0
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Natalia Bidart):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35135#comment:3>

[Django]

#35135: FilteredRelation fails when rhs of the condition is a queryset
-------------------------------------+-------------------------------------
Reporter: Nicolas Delaby | Owner: Nicolas
| Delaby
Type: Bug | Status: assigned
Component: Database layer | Version: 5.0
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* needs_better_patch: 1 => 0

Comment:

Sorry, I set the "patch needs improvement" flag in the wrong tab,
reverting :-)

--
Ticket URL: <https://code.djangoproject.com/ticket/35135#comment:4>

[Django]

#35135: FilteredRelation fails when rhs of the condition is a queryset
-------------------------------------+-------------------------------------
Reporter: Nicolas Delaby | Owner: Nicolas
| Delaby
Type: Bug | Status: assigned
Component: Database layer | Version: 5.0
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35135#comment:5>

[Django]

#35135: FilteredRelation fails when rhs of the condition is a queryset
-------------------------------------+-------------------------------------
Reporter: Nicolas Delaby | Owner: Nicolas
| Delaby
Type: Bug | Status: assigned
Component: Database layer | Version: 5.0
(models, ORM) |
Severity: Release blocker | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35135#comment:6>

[Django]

#35135: FilteredRelation fails when rhs of the condition is a queryset
-------------------------------------+-------------------------------------
Reporter: Nicolas Delaby | Owner: Nicolas
| Delaby

Type: Bug | Status: closed

Component: Database layer | Version: 5.0
(models, ORM) |

Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"820c5f1bacd41713bd30d8b5fefb66752ff15c4c" 820c5f1]:
{{{#!CommitTicketReference repository=""
revision="820c5f1bacd41713bd30d8b5fefb66752ff15c4c"
Fixed #35135 -- Made FilteredRelation raise ValueError on querysets as
rhs.

Regression in 59f475470494ce5b8cbff816b1e5dafcbd10a3a3.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35135#comment:7>

[Django]

#35135: FilteredRelation fails when rhs of the condition is a queryset
-------------------------------------+-------------------------------------
Reporter: Nicolas Delaby | Owner: Nicolas
| Delaby
Type: Bug | Status: closed
Component: Database layer | Version: 5.0
(models, ORM) |
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"a5440054d2285b2abf54251a33990fd9a6f94060" a544005]:
{{{#!CommitTicketReference repository=""
revision="a5440054d2285b2abf54251a33990fd9a6f94060"
[5.0.x] Fixed #35135 -- Made FilteredRelation raise ValueError on
querysets as rhs.

Regression in 59f475470494ce5b8cbff816b1e5dafcbd10a3a3.

Backport of 820c5f1bacd41713bd30d8b5fefb66752ff15c4c from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35135#comment:8>