[Django] #35121: Links in the admin should use the --link-fg color.

9 views
Skip to first unread message

Django

unread,
Jan 17, 2024, 11:50:18 PMJan 17
to django-...@googlegroups.com
#35121: Links in the admin should use the --link-fg color.
--------------------------------------------+------------------------
Reporter: Mariusz Felisiak | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 5.0
Severity: Release blocker | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
--------------------------------------------+------------------------
Links in the admin should use the `--link-fg` color. There is #34038 to
improve links in the admin, however, this is a separate regression that
should be fixed and backported to Django 5.0:

{{{#!diff
diff --git a/django/contrib/admin/static/admin/css/base.css
b/django/contrib/admin/static/admin/css/base.css
index aaa9c3441a..daf4699cac 100644
--- a/django/contrib/admin/static/admin/css/base.css
+++ b/django/contrib/admin/static/admin/css/base.css
@@ -102,7 +102,7 @@ body {
/* LINKS */

a:link, a:visited {
- color: var(--body-fg);
+ color: var(--link-fg);
text-decoration: none;
transition: color 0.15s, background 0.15s;
}

}}}

Reported by [https://code.djangoproject.com/ticket/34036#comment:16
Collin].

Regression in 6ad2738a8f32b94cbae742f212080fadf2dee421.

--
Ticket URL: <https://code.djangoproject.com/ticket/35121>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 18, 2024, 4:24:49 AMJan 18
to django-...@googlegroups.com
#35121: Links in the admin should use the --link-fg color.
----------------------------------+------------------------------------

Reporter: Mariusz Felisiak | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 5.0
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
----------------------------------+------------------------------------
Changes (by Salvo Polizzi):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/35121#comment:1>

Django

unread,
Jan 18, 2024, 5:54:33 AMJan 18
to django-...@googlegroups.com
#35121: Links in the admin should use the --link-fg color.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Salvo
| Polizzi
Type: Bug | Status: assigned

Component: contrib.admin | Version: 5.0
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* owner: nobody => Salvo Polizzi
* status: new => assigned
* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/35121#comment:2>

Django

unread,
Jan 18, 2024, 8:07:18 AMJan 18
to django-...@googlegroups.com
#35121: Links in the admin should use the --link-fg color.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Salvo
| Polizzi
Type: Bug | Status: closed
Component: contrib.admin | Version: 5.0
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"10c7c7320baf1c655fcb91202169d77725c9c4bd" 10c7c73]:
{{{
#!CommitTicketReference repository=""
revision="10c7c7320baf1c655fcb91202169d77725c9c4bd"
Fixed #35121 -- Corrected color for links in the admin.

Thanks Collin Anderson for the report.

Regression in 6ad2738a8f32b94cbae742f212080fadf2dee421.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/35121#comment:3>

Django

unread,
Jan 18, 2024, 8:07:50 AMJan 18
to django-...@googlegroups.com
#35121: Links in the admin should use the --link-fg color.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Salvo
| Polizzi
Type: Bug | Status: closed
Component: contrib.admin | Version: 5.0
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"4ed1423de4342e453bf1d80129e84c14be819df3" 4ed1423d]:
{{{
#!CommitTicketReference repository=""
revision="4ed1423de4342e453bf1d80129e84c14be819df3"
[5.0.x] Fixed #35121 -- Corrected color for links in the admin.

Thanks Collin Anderson for the report.

Regression in 6ad2738a8f32b94cbae742f212080fadf2dee421.

Backport of 10c7c7320baf1c655fcb91202169d77725c9c4bd from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/35121#comment:4>

Reply all
Reply to author
Forward
0 new messages