[Django] #35119: Have the same max_length for EmailValidator and EmailField

6 views
Skip to first unread message

Django

unread,
Jan 16, 2024, 7:27:25 AM1/16/24
to django-...@googlegroups.com
#35119: Have the same max_length for EmailValidator and EmailField
------------------------------------------------+------------------------
Reporter: jecarr | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: 5.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
As per [https://code.djangoproject.com/ticket/34961 this discussion],
there is consideration to make the max_length values the same for
EmailValidator and EmailField

--
Ticket URL: <https://code.djangoproject.com/ticket/35119>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 18, 2024, 12:55:42 PM1/18/24
to django-...@googlegroups.com
#35119: Have the same max_length for EmailValidator and EmailField
--------------------------------------+------------------------------------

Reporter: jecarr | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Natalia Bidart):

* version: 5.0 => dev
* stage: Unreviewed => Accepted


Comment:

Accepting following ticket:34961#comment:9, where it's suggested that we
should unify `max_length` to be 254 across the `EmailValidator` and the
form's and model's `EmailField`.
But before moving forward, I would like us to understand the implications
of reducing the `max_length` for the validator and form field, and
evaluate whether a deprecation warning/process is needed.

I think we should make an analysis about how existing code bases could be
affected by this change. Ideally we would describe how different
combinations of using model's and form's `EmailField` would interact with
each other when the `max_length` changes, considering both `ModelForm`s
and `Form`s. jecarr would you be interested in pushing this forward?

--
Ticket URL: <https://code.djangoproject.com/ticket/35119#comment:1>

Reply all
Reply to author
Forward
0 new messages