[Django] #16281: ContentType.get_object_for_this_type using wrong database for creating object

Django

unread,

Jun 16, 2011, 5:29:37 AM6/16/11

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------
Reporter: tfrydrychewicz@… | Owner: nobody
Type: Bug | Status: new
Milestone: | Component:
Version: 1.3 | contrib.contenttypes
Keywords: contenttype, object | Severity: Release blocker
get_object_for_this_type, | Triage Stage: Unreviewed
database, multiple | Easy pickings: 0
Has patch: 1 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
There is a subtle error in
[https://docs.djangoproject.com/en/1.3/ref/contrib/contenttypes/#django.contrib.contenttypes.models.ContentType.get_object_for_this_type
ContentType.get_object_for_this_type] method.

{{{
def get_object_for_this_type(self, **kwargs):
return
self.model_class()._default_manager.using(self._state.db).get(**kwargs)
}}}

Database used to ''get'' ''model_class'' object is taken from
self._state.db, which provides an error when ''contenttype'' model is hold
in one database and model, of which object we're going to create, in
another one.

Database should be provided using self.model_class().objects.db not
self._state.db.

--
Ticket URL: <https://code.djangoproject.com/ticket/16281>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,

Jun 16, 2011, 8:04:03 AM6/16/11

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------

* needs_better_patch: => 0
* needs_tests: => 1
* needs_docs: => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:1>

Django

unread,

Jun 16, 2011, 9:29:13 AM6/16/11

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------

Reporter: | Owner: nobody
tfrydrychewicz@… | Status: new
Type: Bug | Component:
Milestone: | contrib.contenttypes

Version: SVN | Severity: Release blocker
Resolution: | Keywords: contenttype, object
Triage Stage: Accepted | get_object_for_this_type, database,
Needs documentation: 0 | multiple
Patch needs improvement: 0 | Has patch: 1
UI/UX: 0 | Needs tests: 1
| Easy pickings: 0
-------------------------------------+-------------------------------------
Changes (by melinath):

* version: 1.3 => SVN
* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:2>

Django

unread,

Jun 28, 2011, 8:13:58 AM6/28/11

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------

Comment (by ramiro):

Django

unread,

Nov 12, 2011, 11:31:59 AM11/12/11

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------

Needs tests: 1 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Changes (by poirier):

* owner: nobody => poirier
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:4>

Django

unread,

Nov 12, 2011, 1:02:34 PM11/12/11

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------

Reporter: tfrydrychewicz@… | Owner: poirier
Type: Bug | Status: closed
Component: | Version: SVN
contrib.contenttypes | Resolution: invalid

* cc: poirier (added)
* status: assigned => closed
* resolution: => invalid

Comment:

After studying this, I'm not sure the current code is wrong. I'd want to
see a use case in which Django clearly does the wrong thing to be
convinced otherwise. Please re-open the ticket if there is one.

The proposed fix:
{{{
- return
self.model_class()._base_manager.using(self._state.db).get(**kwargs)
+ return
self.model_class()._base_manager.using(self.model_class().objects.db).get(**kwargs)
}}}
seems to assume that there is exactly one database in which it is correct
to look for instances of a given model, but in Django, it's not required
that all instances of a model be stored in one database.

Applying the fix causes one of the multiple database tests,
test_generic_key_separation(), to fail. This test puts pairs of related
instances in each of the two test databases and ensures that querying for
the related instances works, but after this change, is unable to find the
related instance in the 2nd database correctly, probably because now
get_object_for_this_type() is only looking in the default database.

The test does assume that !ContentType objects exist in every database in
which a model has instances, but that seems reasonable, given the
requirement in Django that related objects be stored in the same database.
!ContentType objects don't actually have !ForeignKeys, but logically
they're still related to the models they represent.

The current code looks for the instance of the requested model in the same
database in which the !ContentType instance being used was found, which
fits in with the "related instances in same database" requirement.

However, in working through all this, I found nothing in the Django
documentation discussing how the content type framework and multiple
databases interact, and perhaps this ticket demonstrates the need for more
documentation on how to correctly use content types when multiple
databases are involved.

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:5>

Django

unread,

Nov 24, 2012, 2:48:35 PM11/24/12

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------

Reporter: tfrydrychewicz@… | Owner: poirier
Type: Bug | Status: reopened
Component: | Version: master
contrib.contenttypes | Resolution:

Changes (by Gertjan Klein <gklein@…>):

* status: closed => reopened
* resolution: invalid =>

Comment:

I don't understand the patch or it's implications enough to comment on it.
However, I can confirm this is a valid bug in Django 1.4. I have an
application where some tables reside in a mysql database; these are pre-
existing tables, not managed by Django, for which I created models using
inspectdb. Everything else (auth, contenttypes, ...) resides in a sqlite
database. A database router manages which model is mapped to which
database. This works fine everywhere.

Recently, I decided to add a get_absolute_url method to one of the models
residing in the mysql database. I now have a "show on site" link in the
admin for that model. Without the patch above, clicking this link causes a
DatabaseError exception, because Django attempts to access the model's
table in the sqlite database.

It seems to me that this should just work. Django knows the model's table
resides in the mysql database, because it is editing an instance of it.

The proposed fix above does indeed fix this problem for me: the link now
properly links to my site. (I haven't tried trunk, but the relevant code
appears to be unchanged from 1.4, so I expect it to behave the same.)

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:6>

Django

unread,

Nov 24, 2012, 2:49:39 PM11/24/12

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------

Reporter: tfrydrychewicz@… | Owner: poirier
Type: Bug | Status: reopened
Component: | Version: master
contrib.contenttypes | Resolution:

Severity: Normal | Triage Stage: Accepted

Keywords: contenttype, object | Needs documentation: 0
get_object_for_this_type, | Patch needs improvement: 0
database, multiple | UI/UX: 0
Has patch: 1 |
Needs tests: 1 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by Gertjan Klein <gklein@…>):

* cc: gklein@… (added)
* severity: Release blocker => Normal

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:7>

Django

unread,

Apr 16, 2013, 4:33:04 PM4/16/13

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------

Reporter: tfrydrychewicz@… | Owner: poirier
Type: Bug | Status: new

Comment (by anonymous):

Based on poirier's earlier comment, would it not work to simply remove the
`.using(self._state.db)` clause from the original code altogether? Then
the DB router could do its usual job of deciding where to point the query.

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:9>

Django

unread,

Apr 17, 2013, 7:02:41 AM4/17/13

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------

Comment (by Gertjan Klein <gklein@…>):

Replying to [comment:9 anonymous]:

> would it not work to simply remove the `.using(self._state.db)` clause
from the original code altogether?

I can confirm that works in my situation (described above in [comment 6
comment:6]).

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:10>

Django

unread,

Apr 20, 2013, 8:51:02 AM4/20/13

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------

Changes (by poirier):

* cc: poirier (removed)

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:11>

Django

unread,

Jul 24, 2013, 6:58:56 PM7/24/13

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------

Comment (by anonymous):

Replying to [comment:10 Gertjan Klein <gklein@…>]:

> Replying to [comment:9 anonymous]:
> > would it not work to simply remove the `.using(self._state.db)` clause
from the original code altogether?
>
> I can confirm that works in my situation (described above in [comment 6
comment:6]).

This also fixes the problem in for me. However, it also causes
`test_generic_key_separation
(regressiontests.multiple_database.tests.QueryTestCase)` to fail (just
like the proposed fix by poirier above). This isn't a problem in my
application, but it clearly is a regression elsewhere.

This change allows get_object_for_this_type to continue using the
instance._state.db for the regression test case, but the router-provided
database for cases that don't specify a database. I don't think this
change is complete, as there are almost certainly more locations that need
to pass using= in order to not regress.

{{{
diff --git a/django/contrib/contenttypes/generic.py
b/django/contrib/contenttypes/generic.py
index e83c83a..ee04262 100644
--- a/django/contrib/contenttypes/generic.py
+++ b/django/contrib/contenttypes/generic.py
@@ -123,7 +123,7 @@ class GenericForeignKey(object):
if ct_id:
ct = self.get_content_type(id=ct_id,
using=instance._state.db)
try:
- rel_obj =
ct.get_object_for_this_type(pk=getattr(instance, self.fk_field))
+ rel_obj =
ct.get_object_for_this_type(using=instance._state.db, pk=getattr(instance,
self.fk_field))
except ObjectDoesNotExist:
pass
setattr(instance, self.cache_attr, rel_obj)
diff --git a/django/contrib/contenttypes/models.py
b/django/contrib/contenttypes/models.py
index b658655..4c4d92b 100644
--- a/django/contrib/contenttypes/models.py
+++ b/django/contrib/contenttypes/models.py
@@ -157,20 +157,23 @@ class ContentType(models.Model):
return models.get_model(self.app_label, self.model,
only_installed=False)

- def get_object_for_this_type(self, **kwargs):
+ def get_object_for_this_type(self, using=None, **kwargs):
"""
Returns an object of this type for the keyword arguments given.
Basically, this is a proxy around this object_type's get_object()
model
method. The ObjectNotExist exception, if thrown, will not be
caught,
so code that calls this method should catch it.
"""
- return
self.model_class()._base_manager.using(self._state.db).get(**kwargs)
+ if using:
+ return
self.model_class()._base_manager.using(using).get(**kwargs)
+ else:
+ return self.model_class()._base_manager.get(**kwargs)

def get_all_objects_for_this_type(self, **kwargs):
"""
Returns all objects of this type for the keyword arguments given.
"""
- return
self.model_class()._base_manager.using(self._state.db).filter(**kwargs)
+ return self.model_class()._base_manager.filter(**kwargs)

def natural_key(self):
return (self.app_label, self.model)
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:12>

Django

unread,

Feb 16, 2015, 5:56:16 PM2/16/15

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------

Reporter: tfrydrychewicz@… | Owner: poirier
Type: Bug | Status: new
Component: | Version: master
contrib.contenttypes |

Severity: Normal | Resolution:

Keywords: contenttype, object | Triage Stage: Accepted
get_object_for_this_type, |

database, multiple |
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by gregplaysguitar):

I've just been bitten by this bug (django 1.7) - I have a particular app
in a separate database, and now the admin's "view on site" link doesn't
work because it's looking for the object in the default database. What are
the chances of it being addressed?

I don't really think this is an edge case; as it stands the "view on site"
link will fail for *any* object kept in a separate database, and the only
way to remove said link is to remove the get_absolute_url method from the
model.

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:13>

Django

unread,

Feb 16, 2015, 6:17:56 PM2/16/15

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------

Comment (by timgraham):

It looks to me like writing a patch with tests is the next step to address
this.

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:14>

Django

unread,

Oct 2, 2015, 3:58:49 PM10/2/15

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------

Comment (by timgraham):

Might be a duplicate of #15610 as the patch proposed there also modifies
these methods.

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:15>

Django

unread,

Oct 21, 2015, 3:05:49 PM10/21/15

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------

Comment (by timgraham):

#25564 is a duplicate.

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:16>

Django

unread,

Nov 7, 2020, 5:43:55 PM11/7/20

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------

Reporter: tfrydrychewicz@… | Owner: Dan
| Poirier

Comment (by Tim Graham):

#30760 is another duplicate.

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:17>

Django

unread,

Jul 29, 2022, 6:46:13 AM7/29/22

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------

Reporter: tfrydrychewicz@… | Owner: (none)
Type: Bug | Status: assigned
Component: | Version: dev

Changes (by Mariusz Felisiak):

* owner: Dan Poirier => (none)

* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:18>

Django

unread,

Jul 29, 2022, 6:46:19 AM7/29/22

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------

Reporter: tfrydrychewicz@… | Owner: (none)
Type: Bug | Status: new

* status: assigned => new

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:19>

Django

unread,

Nov 15, 2023, 11:40:53 AM11/15/23

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------

Comment (by bcail):

Here's a similar patch that does the current query, and if it fails, falls
back to the using the default router. This passes the tests if I fix the
number of expected queries in one test. If we go this direction, we'd
probably want to update the `get_all_objects_for_this_type` method as
well.

{{{
diff --git a/django/contrib/contenttypes/models.py
b/django/contrib/contenttypes/models.py
index 0d98ed3a4d..2cf08bc85e 100644
--- a/django/contrib/contenttypes/models.py
+++ b/django/contrib/contenttypes/models.py
@@ -2,7 +2,7 @@ from collections import defaultdict

from django.apps import apps
from django.db import models
-from django.db.models import Q
+from django.db.models import ObjectDoesNotExist, Q
from django.utils.translation import gettext_lazy as _

@@ -181,7 +181,10 @@ class ContentType(models.Model):

method. The ObjectNotExist exception, if thrown, will not be
caught,
so code that calls this method should catch it.
"""
- return
self.model_class()._base_manager.using(self._state.db).get(**kwargs)

+ try:
+ return
self.model_class()._base_manager.using(self._state.db).get(**kwargs)
+ except ObjectDoesNotExist:
+ return self.model_class()._base_manager.get(**kwargs)

def get_all_objects_for_this_type(self, **kwargs):
"""
diff --git a/tests/contenttypes_tests/test_fields.py
b/tests/contenttypes_tests/test_fields.py
index 5510f34cd0..dd1edae834 100644
--- a/tests/contenttypes_tests/test_fields.py
+++ b/tests/contenttypes_tests/test_fields.py
@@ -32,7 +32,7 @@ class GenericForeignKeyTests(TestCase):
Question.objects.all().delete()

post = Post.objects.get(pk=post.pk)
- with self.assertNumQueries(1):
+ with self.assertNumQueries(2):
self.assertEqual(post.object_id, question_pk)
self.assertIsNone(post.parent)
self.assertIsNone(post.parent)
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:20>

Django

unread,

Nov 15, 2023, 3:23:48 PM11/15/23

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by bcail):

* cc: bcail (added)
* needs_tests: 1 => 0

Comment:

Actually, the patch in comment number 12, by anonymous, seems to work
quite well. I added a test and
[https://github.com/django/django/pull/17479 opened a PR] with that
change.

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:21>

Django

unread,

Nov 20, 2023, 12:13:30 AM11/20/23

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------

Reporter: tfrydrychewicz@… | Owner: bcail
Type: Bug | Status: assigned

Changes (by Mariusz Felisiak):

* owner: (none) => bcail

* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:22>

Django

unread,

Dec 27, 2023, 3:14:51 AM12/27/23

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------

Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1
* needs_tests: 0 => 1
* needs_docs: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:23>

Django

unread,

Jan 4, 2024, 10:53:38 AM1/4/24

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by bcail):

* needs_better_patch: 1 => 0

* needs_tests: 1 => 0

* needs_docs: 1 => 0

Comment:

Thanks, Mariusz - I updated docs and commented on the PR.

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:24>

Django

unread,

Jan 8, 2024, 4:41:18 AM1/8/24

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------

Needs tests: 1 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1
* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:25>

Django

unread,

Jan 8, 2024, 1:11:23 PM1/8/24

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by bcail):

* needs_better_patch: 1 => 0
* needs_tests: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:26>

Django

unread,

Jan 9, 2024, 4:11:39 AM1/9/24

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------
Reporter: tfrydrychewicz@… | Owner: bcail
Type: Bug | Status: assigned
Component: | Version: dev
contrib.contenttypes |
Severity: Normal | Resolution:
Keywords: contenttype, object | Triage Stage: Accepted
get_object_for_this_type, |
database, multiple |
Has patch: 1 | Needs documentation: 0

Needs tests: 1 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1
* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:27>

Django

unread,

Jan 10, 2024, 2:24:00 PM1/10/24

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------
Reporter: tfrydrychewicz@… | Owner: bcail
Type: Bug | Status: assigned
Component: | Version: dev
contrib.contenttypes |
Severity: Normal | Resolution:
Keywords: contenttype, object | Triage Stage: Accepted
get_object_for_this_type, |
database, multiple |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by bcail):

* needs_better_patch: 1 => 0
* needs_tests: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:28>

Django

unread,

Jan 10, 2024, 11:48:56 PM1/10/24

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------
Reporter: tfrydrychewicz@… | Owner: bcail
Type: Bug | Status: assigned
Component: | Version: dev
contrib.contenttypes |
Severity: Normal | Resolution:
Keywords: contenttype, object | Triage Stage: Accepted
get_object_for_this_type, |
database, multiple |
Has patch: 1 | Needs documentation: 0

Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:29>

Django

unread,

Jan 11, 2024, 12:32:33 PM1/11/24

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------
Reporter: tfrydrychewicz@… | Owner: bcail
Type: Bug | Status: assigned
Component: | Version: dev
contrib.contenttypes |
Severity: Normal | Resolution:
Keywords: contenttype, object | Triage Stage: Accepted
get_object_for_this_type, |
database, multiple |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by bcail):

* needs_tests: 1 => 0

Comment:

Hi Mariusz, I posted another comment on the PR for you to look at.

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:30>

Django

unread,

Jan 11, 2024, 1:08:01 PM1/11/24

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------
Reporter: tfrydrychewicz@… | Owner: bcail
Type: Bug | Status: assigned
Component: | Version: dev
contrib.contenttypes |
Severity: Normal | Resolution:
Keywords: contenttype, object | Triage Stage: Accepted
get_object_for_this_type, |
database, multiple |
Has patch: 1 | Needs documentation: 0

Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* needs_tests: 0 => 1

Comment:

This still requires further tests, check out
[https://github.com/django/django/pull/17479#discussion_r1448287696
comments].

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:31>

Django

unread,

Jan 11, 2024, 1:19:01 PM1/11/24

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------
Reporter: tfrydrychewicz@… | Owner: bcail
Type: Bug | Status: assigned
Component: | Version: dev
contrib.contenttypes |
Severity: Normal | Resolution:
Keywords: contenttype, object | Triage Stage: Accepted
get_object_for_this_type, |
database, multiple |
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by bcail):

Yup - could I add the additional tests after the questions are resolved?

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:32>

Django

unread,

Jan 24, 2024, 4:00:31 PM1/24/24

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------
Reporter: tfrydrychewicz@… | Owner: bcail
Type: Bug | Status: assigned
Component: | Version: dev
contrib.contenttypes |
Severity: Normal | Resolution:
Keywords: contenttype, object | Triage Stage: Accepted
get_object_for_this_type, |
database, multiple |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by bcail):

* needs_tests: 1 => 0

Comment:

I added a test for View on Site.

For ticket 15610, I added a comment with a question on that issue.
--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:33>

Django

unread,

Feb 2, 2024, 12:18:04 AM2/2/24

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------
Reporter: tfrydrychewicz@… | Owner: bcail
Type: Bug | Status: assigned
Component: | Version: dev
contrib.contenttypes |
Severity: Normal | Resolution:
Keywords: contenttype, object | Triage Stage: Accepted
get_object_for_this_type, |
database, multiple |
Has patch: 1 | Needs documentation: 0

Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:34>

Django

unread,

Feb 2, 2024, 10:13:05 AM2/2/24

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------
Reporter: tfrydrychewicz@… | Owner: bcail
Type: Bug | Status: assigned
Component: | Version: dev
contrib.contenttypes |
Severity: Normal | Resolution:
Keywords: contenttype, object | Triage Stage: Accepted
get_object_for_this_type, |
database, multiple |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by bcail):

* needs_tests: 1 => 0

Comment:

I updated the tests.
--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:35>

Django

unread,

Feb 5, 2024, 2:29:33 AM2/5/24

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------
Reporter: tfrydrychewicz@… | Owner: bcail
Type: Bug | Status: assigned
Component: | Version: dev
contrib.contenttypes |
Severity: Normal | Resolution:

Keywords: contenttype, object | Triage Stage: Ready for
get_object_for_this_type, | checkin

database, multiple |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:36>

Django

unread,

Feb 5, 2024, 3:15:02 AM2/5/24

to django-...@googlegroups.com

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-------------------------------------+-------------------------------------
Reporter: tfrydrychewicz@… | Owner: bcail

Type: Bug | Status: closed
Component: | Version: dev
contrib.contenttypes |
Severity: Normal | Resolution: fixed

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"02a600ff67f7b106cdcab22310bacea98c1a26ba" 02a600f]:
{{{#!CommitTicketReference repository=""
revision="02a600ff67f7b106cdcab22310bacea98c1a26ba"
Fixed #16281 -- Fixed ContentType.get_object_for_this_type() in a multiple
database setup.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/16281#comment:37>

Reply all

Reply to author

Forward