[Django] #35096: Error messages in admin forms with class "wide" misaligned

9 views
Skip to first unread message

Django

unread,
Jan 8, 2024, 5:07:08 PM1/8/24
to django-...@googlegroups.com
#35096: Error messages in admin forms with class "wide" misaligned
-----------------------------------------+------------------------------
Reporter: Fabian Braun | Owner: Fabian Braun
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------------
The admin allows customizing the styling of fieldsets. "wide" is a
documented class for a fieldset. It widens the width of the label column
from 160px to 200px.

Alas, if the form has errors, the error messages stay indented at 160px
not 200px:
[]

--
Ticket URL: <https://code.djangoproject.com/ticket/35096>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 8, 2024, 5:07:50 PM1/8/24
to django-...@googlegroups.com
#35096: Error messages in admin forms with class "wide" misaligned
-------------------------------+----------------------------------------

Reporter: Fabian Braun | Owner: Fabian Braun
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+----------------------------------------
Changes (by Fabian Braun):

* Attachment "admin-wide.jpg" added.

Django

unread,
Jan 8, 2024, 5:09:32 PM1/8/24
to django-...@googlegroups.com
#35096: Error messages in admin forms with class "wide" misaligned
-------------------------------+----------------------------------------
Reporter: Fabian Braun | Owner: Fabian Braun
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+----------------------------------------
Description changed by Fabian Braun:

Old description:

> The admin allows customizing the styling of fieldsets. "wide" is a
> documented class for a fieldset. It widens the width of the label column
> from 160px to 200px.
>
> Alas, if the form has errors, the error messages stay indented at 160px
> not 200px:
> []

New description:

The admin allows customizing the styling of fieldsets. "wide" is a
documented class for a fieldset. It widens the width of the label column
from 160px to 200px.

Alas, if the form has errors, the error messages stay indented at 160px
not 200px:

[[Image(https://code.djangoproject.com/raw-attachment/ticket/35096/admin-
wide.jpg)]]

--

--
Ticket URL: <https://code.djangoproject.com/ticket/35096#comment:1>

Django

unread,
Jan 8, 2024, 5:25:32 PM1/8/24
to django-...@googlegroups.com
#35096: Error messages in admin forms with class "wide" misaligned
-------------------------------+----------------------------------------
Reporter: Fabian Braun | Owner: Fabian Braun
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+----------------------------------------
Changes (by Fabian Braun):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/35096#comment:2>

Django

unread,
Jan 8, 2024, 11:49:52 PM1/8/24
to django-...@googlegroups.com
#35096: Error messages in admin forms with class "wide" misaligned
---------------------------------+----------------------------------------

Reporter: Fabian Braun | Owner: Fabian Braun
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+----------------------------------------
Changes (by Mariusz Felisiak):

* cc: Tom Carrick (added)
* severity: Normal => Release blocker
* stage: Unreviewed => Accepted


Comment:

Thanks for the report.

Regression in be06c39abe80ca650e37810d16d15ff60e8c9727 (LTR) and
b34a4771a3d4cd7829a1f38a0f6a7a0da519a724 (RTL).

--
Ticket URL: <https://code.djangoproject.com/ticket/35096#comment:3>

Django

unread,
Jan 9, 2024, 12:01:35 AM1/9/24
to django-...@googlegroups.com
#35096: Error messages in admin forms with class "wide" misaligned
-------------------------------------+-------------------------------------

Reporter: Fabian Braun | Owner: Fabian
| Braun
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/35096#comment:4>

Django

unread,
Jan 9, 2024, 8:18:52 AM1/9/24
to django-...@googlegroups.com
#35096: Error messages in admin forms with class "wide" misaligned
-------------------------------------+-------------------------------------
Reporter: Fabian Braun | Owner: Fabian
| Braun
Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"6dae40839ba828b704eed1f0749c48a21bd88d78" 6dae408]:
{{{
#!CommitTicketReference repository=""
revision="6dae40839ba828b704eed1f0749c48a21bd88d78"
Fixed #35096 -- Corrected alignment for error lists in admin "wide" forms.

Regression in be06c39abe80ca650e37810d16d15ff60e8c9727 (LTR) and
b34a4771a3d4cd7829a1f38a0f6a7a0da519a724 (RTL).
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/35096#comment:5>

Reply all
Reply to author
Forward
0 new messages