[Django] #34901: Add async interface to contrib.sessions

15 views
Skip to first unread message

Django

unread,
Oct 15, 2023, 7:49:20 PM10/15/23
to django-...@googlegroups.com
#34901: Add async interface to contrib.sessions
--------------------------------------------+----------------------------
Reporter: Jon Janzen | Owner: Jon Janzen
Type: New feature | Status: assigned
Component: contrib.sessions | Version: dev
Severity: Normal | Keywords: async
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
--------------------------------------------+----------------------------
Per the ongoing attempt to asyncify the contrib.auth system the next step
is to add an async interface/backends to sessions:
https://forum.djangoproject.com/t/asyncifying-django-contrib-auth-and-
signals-and-maybe-sessions/18770

There is obvious needs for this (see the above forum thread) and a basic
implementation provided in one of the more recent comments:
https://forum.djangoproject.com/t/asyncifying-django-contrib-auth-and-
signals-and-maybe-sessions/18770/20

My plan is to take this implementation, add some tests and put it up as a
PR

--
Ticket URL: <https://code.djangoproject.com/ticket/34901>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 15, 2023, 11:59:34 PM10/15/23
to django-...@googlegroups.com
#34901: Add async interface to contrib.sessions
----------------------------------+--------------------------------------

Reporter: Jon Janzen | Owner: Jon Janzen
Type: New feature | Status: assigned
Component: contrib.sessions | Version: dev
Severity: Normal | Resolution:
Keywords: async | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+--------------------------------------
Changes (by Mariusz Felisiak):

* cc: Andrew Chen Wang (added)
* stage: Unreviewed => Accepted


Comment:

> My plan is to take this implementation...

I'm not sure if that's enough, but we can discuss it in PR.

--
Ticket URL: <https://code.djangoproject.com/ticket/34901#comment:1>

Django

unread,
Oct 16, 2023, 9:52:03 PM10/16/23
to django-...@googlegroups.com
#34901: Add async interface to contrib.sessions
----------------------------------+--------------------------------------
Reporter: Jon Janzen | Owner: Jon Janzen
Type: New feature | Status: assigned
Component: contrib.sessions | Version: dev
Severity: Normal | Resolution:
Keywords: async | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+--------------------------------------

Comment (by Jon Janzen):

[https://github.com/django/django/pull/17372 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/34901#comment:2>

Django

unread,
Oct 16, 2023, 9:52:15 PM10/16/23
to django-...@googlegroups.com
#34901: Add async interface to contrib.sessions
----------------------------------+--------------------------------------
Reporter: Jon Janzen | Owner: Jon Janzen
Type: New feature | Status: assigned
Component: contrib.sessions | Version: dev
Severity: Normal | Resolution:
Keywords: async | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+--------------------------------------
Changes (by Jon Janzen):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/34901#comment:3>

Django

unread,
Dec 13, 2023, 3:15:17 AM12/13/23
to django-...@googlegroups.com
#34901: Add async interface to contrib.sessions
----------------------------------+--------------------------------------
Reporter: Jon Janzen | Owner: Jon Janzen
Type: New feature | Status: assigned
Component: contrib.sessions | Version: dev
Severity: Normal | Resolution:
Keywords: async | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
----------------------------------+--------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1
* needs_tests: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/34901#comment:4>

Django

unread,
Feb 6, 2024, 8:30:26 PM2/6/24
to django-...@googlegroups.com
#34901: Add async interface to contrib.sessions
----------------------------------+--------------------------------------
Reporter: Jon Janzen | Owner: Jon Janzen
Type: New feature | Status: assigned
Component: contrib.sessions | Version: dev
Severity: Normal | Resolution:
Keywords: async | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+--------------------------------------
Changes (by Jon Janzen):

* needs_better_patch: 1 => 0
* needs_tests: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/34901#comment:5>

Django

unread,
Mar 13, 2024, 9:19:24 AM3/13/24
to django-...@googlegroups.com
#34901: Add async interface to contrib.sessions
-------------------------------------+-------------------------------------
Reporter: Jon Janzen | Owner: Jon
| Janzen
Type: New feature | Status: assigned
Component: contrib.sessions | Version: dev
Severity: Normal | Resolution:
Keywords: async | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/34901#comment:6>

Django

unread,
Mar 14, 2024, 12:18:52 AM3/14/24
to django-...@googlegroups.com
#34901: Add async interface to contrib.sessions
-------------------------------------+-------------------------------------
Reporter: Jon Janzen | Owner: Jon
| Janzen
Type: New feature | Status: closed
Component: contrib.sessions | Version: dev
Severity: Normal | Resolution: fixed
Keywords: async | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"f5c340684be3f27a145ec86ba55b24eb88d2780c" f5c34068]:
{{{#!CommitTicketReference repository=""
revision="f5c340684be3f27a145ec86ba55b24eb88d2780c"
Fixed #34901 -- Added async-compatible interface to session engines.

Thanks Andrew-Chen-Wang for the initial implementation which was posted
to the Django forum thread about asyncifying contrib modules.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34901#comment:7>
Reply all
Reply to author
Forward
0 new messages