Re: [Django] #35019: Model with GeneratedField and ForeignKey raises an error on save().

25 views
Skip to first unread message

Django

unread,
Dec 6, 2023, 5:32:24 PM12/6/23
to django-...@googlegroups.com
#35019: Model with GeneratedField and ForeignKey raises an error on save().
-------------------------------------+-------------------------------------
Reporter: Deb Kumar Das | Owner: Sarah
| Boyce
Type: Bug | Status: assigned
Component: Database layer | Version: 5.0
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: GeneratedField save | Triage Stage: Accepted
error |
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* owner: nobody => Sarah Boyce
* needs_docs: 0 => 1
* has_patch: 0 => 1
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/35019#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Dec 6, 2023, 9:07:25 PM12/6/23
to django-...@googlegroups.com
#35019: Model with GeneratedField and ForeignKey raises an error on save().
-------------------------------------+-------------------------------------
Reporter: Deb Kumar Das | Owner: Sarah
| Boyce
Type: Bug | Status: assigned
Component: Database layer | Version: 5.0
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: GeneratedField save | Triage Stage: Accepted
error |
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Simon Charette):

* needs_better_patch: 0 => 1
* needs_tests: 0 => 1


Comment:

The patch will need some improvements as we must consider that generated
fields can also be deferred. We'll likely want to add tests for generated
field deferral as well.

--
Ticket URL: <https://code.djangoproject.com/ticket/35019#comment:6>

Django

unread,
Dec 7, 2023, 3:03:54 AM12/7/23
to django-...@googlegroups.com
#35019: Model with GeneratedField and ForeignKey raises an error on save().
-------------------------------------+-------------------------------------
Reporter: Deb Kumar Das | Owner: Sarah
| Boyce
Type: Bug | Status: assigned
Component: Database layer | Version: 5.0
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: GeneratedField save | Triage Stage: Accepted
error |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 1 => 0
* needs_tests: 1 => 0
* needs_docs: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/35019#comment:7>

Django

unread,
Dec 8, 2023, 3:42:42 AM12/8/23
to django-...@googlegroups.com
#35019: Model with GeneratedField and ForeignKey raises an error on save().
-------------------------------------+-------------------------------------
Reporter: Deb Kumar Das | Owner: Sarah
| Boyce
Type: Bug | Status: assigned
Component: Database layer | Version: 5.0
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: GeneratedField save | Triage Stage: Ready for
error | checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/35019#comment:8>

Django

unread,
Dec 8, 2023, 6:09:47 AM12/8/23
to django-...@googlegroups.com
#35019: Model with GeneratedField and ForeignKey raises an error on save().
-------------------------------------+-------------------------------------
Reporter: Deb Kumar Das | Owner: Sarah
| Boyce
Type: Bug | Status: closed

Component: Database layer | Version: 5.0
(models, ORM) |
Severity: Release blocker | Resolution: fixed

Keywords: GeneratedField save | Triage Stage: Ready for
error | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"b287af5dc954628d4b336aefc5027b2edceee64b" b287af5d]:
{{{
#!CommitTicketReference repository=""
revision="b287af5dc954628d4b336aefc5027b2edceee64b"
Fixed #35019 -- Fixed save() on models with both GeneratedFields and
ForeignKeys.

Thanks Deb Kumar Das for the report.

Regression in f333e3513e8bdf5ffeb6eeb63021c230082e6f95.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/35019#comment:9>

Django

unread,
Dec 8, 2023, 6:10:18 AM12/8/23
to django-...@googlegroups.com
#35019: Model with GeneratedField and ForeignKey raises an error on save().
-------------------------------------+-------------------------------------
Reporter: Deb Kumar Das | Owner: Sarah
| Boyce
Type: Bug | Status: closed
Component: Database layer | Version: 5.0
(models, ORM) |
Severity: Release blocker | Resolution: fixed
Keywords: GeneratedField save | Triage Stage: Ready for
error | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"03af8fbd0f1cfc08edadda248cf5d3498e8ed2f7" 03af8fb]:
{{{
#!CommitTicketReference repository=""
revision="03af8fbd0f1cfc08edadda248cf5d3498e8ed2f7"
[5.0.x] Fixed #35019 -- Fixed save() on models with both GeneratedFields
and ForeignKeys.

Thanks Deb Kumar Das for the report.

Regression in f333e3513e8bdf5ffeb6eeb63021c230082e6f95.

Backport of b287af5dc954628d4b336aefc5027b2edceee64b from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/35019#comment:10>

Django

unread,
Dec 8, 2023, 7:58:28 AM12/8/23
to django-...@googlegroups.com
#35019: Model with GeneratedField and ForeignKey raises an error on save().
-------------------------------------+-------------------------------------
Reporter: Deb Kumar Das | Owner: Sarah
| Boyce
Type: Bug | Status: closed
Component: Database layer | Version: 5.0
(models, ORM) |
Severity: Release blocker | Resolution: fixed
Keywords: GeneratedField save | Triage Stage: Ready for
error | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Deb Kumar Das):

Thanks @Mariusz Felisiak and all the Django team, for a quick response and
fix.

--
Ticket URL: <https://code.djangoproject.com/ticket/35019#comment:11>

Reply all
Reply to author
Forward
0 new messages