Re: [Django] #35022: RenameIndex crashes when there is a unique index on the same fields. (was: migration fails from index_together to models.Index)

8 views
Skip to first unread message

Django

unread,
Dec 6, 2023, 11:32:39 PM12/6/23
to django-...@googlegroups.com
#35022: RenameIndex crashes when there is a unique index on the same fields.
-----------------------------------+------------------------------------
Reporter: Thomas Capricelli | Owner: nobody
Type: Bug | Status: new
Component: Migrations | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
Changes (by Mariusz Felisiak):

* cc: David Wobrock (added)
* stage: Unreviewed => Accepted


Comment:

Thanks for the report. The following patch fixes this for me:

{{{#!diff
diff --git a/django/db/migrations/operations/models.py
b/django/db/migrations/operations/models.py
index d616cafb45..204174f911 100644
--- a/django/db/migrations/operations/models.py
+++ b/django/db/migrations/operations/models.py
@@ -1017,7 +1017,7 @@ class RenameIndex(IndexOperation):
from_model._meta.get_field(field).column for field in
self.old_fields
]
matching_index_name = schema_editor._constraint_names(
- from_model, column_names=columns, index=True
+ from_model, column_names=columns, index=True,
unique=False,
)
if len(matching_index_name) != 1:
raise ValueError(
}}}

Does it work for you?

--
Ticket URL: <https://code.djangoproject.com/ticket/35022#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Reply all
Reply to author
Forward
0 new messages