[Django] #35012: Admin form visual regression
Django
-----------------------------------------+------------------------
Reporter: James Gillard | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
-----------------------------------------+------------------------
I've traced a change in how one of our fieldsets that contains 3 wide text
inputs displays in the admin. The UI cannot be scrolled but can be tabbed
through. Re-adding this removed line of CSS fixes it for me:
https://github.com/django/django/commit/bd0ea8c2ba9943ed245771265f55645dc3bfeae8
#diff-ec6643f5575f7b320d2f0f6b342a6ff8d3d5b29e305e6d3b45ca115774012f99L27
This was working on 4.2.7, breaks on 4.2.8, and I've tested main also and
see the same visual change. I don't understand the full history of this
change hence I'm not suggesting a fix.
--
Ticket URL: <https://code.djangoproject.com/ticket/35012>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: James Gillard | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by James Gillard):
* Attachment "4.2.7-wide.png" added.
Django
-------------------------------+--------------------------------------
Reporter: James Gillard | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by James Gillard):
* Attachment "4.2.7-narrow.png" added.
Django
-------------------------------+--------------------------------------
Reporter: James Gillard | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by James Gillard):
* Attachment "4.2.8-wide.png" added.
Django
-------------------------------+--------------------------------------
Reporter: James Gillard | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by James Gillard):
* Attachment "4.2.8-narrow.png" added.
Django
-------------------------------+--------------------------------------
Reporter: James Gillard | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
Old description:
> I've traced a change in how one of our fieldsets that contains 3 wide
> text inputs displays in the admin. The UI cannot be scrolled but can be
> tabbed through. Re-adding this removed line of CSS fixes it for me:
> https://github.com/django/django/commit/bd0ea8c2ba9943ed245771265f55645dc3bfeae8
> #diff-ec6643f5575f7b320d2f0f6b342a6ff8d3d5b29e305e6d3b45ca115774012f99L27
>
> This was working on 4.2.7, breaks on 4.2.8, and I've tested main also and
> see the same visual change. I don't understand the full history of this
> change hence I'm not suggesting a fix.
New description:
I've traced a change in how one of our fieldsets that contains 3 wide text
inputs displays in the admin. The form fields are overflowing the edge of
the page. The UI cannot be scrolled but can be tabbed through. Re-adding
this removed line of CSS fixes it for me:
https://github.com/django/django/commit/bd0ea8c2ba9943ed245771265f55645dc3bfeae8
#diff-ec6643f5575f7b320d2f0f6b342a6ff8d3d5b29e305e6d3b45ca115774012f99L27
This was working on 4.2.7, breaks on 4.2.8, and I've tested main also and
see the same visual change. I don't understand the full history of this
change hence I'm not suggesting a fix.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/35012#comment:1>
Django
-------------------------------+--------------------------------------
Reporter: James Gillard | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
Description changed by James Gillard:
Old description:
> I've traced a change in how one of our fieldsets that contains 3 wide
> text inputs displays in the admin. The form fields are overflowing the
> edge of the page. The UI cannot be scrolled but can be tabbed through.
> Re-adding this removed line of CSS fixes it for me:
> https://github.com/django/django/commit/bd0ea8c2ba9943ed245771265f55645dc3bfeae8
> #diff-ec6643f5575f7b320d2f0f6b342a6ff8d3d5b29e305e6d3b45ca115774012f99L27
>
> This was working on 4.2.7, breaks on 4.2.8, and I've tested main also and
> see the same visual change. I don't understand the full history of this
> change hence I'm not suggesting a fix.
New description:
I've traced a change in how one of our fieldsets that contains 3 wide text
inputs displays in the admin. The form fields are overflowing the edge of
the page. In the 4.2.8-narrow screenshot, the 3rd is initially completely
hidden from view. The UI cannot be scrolled but can be tabbed through. Re-
adding this removed line of CSS fixes it for me:
https://github.com/django/django/commit/bd0ea8c2ba9943ed245771265f55645dc3bfeae8
#diff-ec6643f5575f7b320d2f0f6b342a6ff8d3d5b29e305e6d3b45ca115774012f99L27
This was working on 4.2.7, breaks on 4.2.8, and I've tested main also and
see the same visual change. I don't understand the full history of this
change hence I'm not suggesting a fix.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/35012#comment:2>
Django
-------------------------------+--------------------------------------
Reporter: James Gillard | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
Comment (by Natalia Bidart):
Hello James, thank you for your report. Could you please try with the
latest stable release, 5.0 and let us know how that goes?
--
Ticket URL: <https://code.djangoproject.com/ticket/35012#comment:3>
Django
-------------------------------+--------------------------------------
Reporter: James Gillard | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
Comment (by James Gillard):
Hi Natalia, the same issue exists on 5.0.0.
--
Ticket URL: <https://code.djangoproject.com/ticket/35012#comment:4>
Django
-------------------------------+--------------------------------------
Reporter: James Gillard | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
Comment (by Natalia Bidart):
Thank you James! Could you please provide minimal models.py and admin.py
to reproduce the issue?
--
Ticket URL: <https://code.djangoproject.com/ticket/35012#comment:5>
Django
-------------------------------+--------------------------------------
Reporter: James Gillard | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
* cc: Tom Carrick (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/35012#comment:6>
Django
-------------------------------+--------------------------------------
Reporter: James Gillard | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
* Attachment "repro.png" added.
--
Ticket URL: <https://code.djangoproject.com/ticket/35012>
Django
-------------------------------+--------------------------------------
Reporter: James Gillard | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by James Gillard):
* Attachment "repro.zip" added.
Django
-------------------------------+--------------------------------------
Reporter: James Gillard | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
Comment (by James Gillard):
Here's a zip containing a
[https://code.djangoproject.com/attachment/ticket/35012/repro.zip minimal
reproduction], and just the models.py and admin.py files below. The issue
is visible with only 2 fields, but I've included 3 as that was what my
setup has.
{{{#!python
class Foo(models.Model):
a = models.CharField(max_length=200)
b = models.CharField(max_length=200)
c = models.CharField(max_length=200)
}}}
{{{#!python
@admin.register(Foo)
class FooAdmin(admin.ModelAdmin):
fieldsets = (
(
None,
{
"fields": (("a", "b", "c"),),
},
),
)
}}}
[[Image(repro.png, 800px)]]
--
Ticket URL: <https://code.djangoproject.com/ticket/35012#comment:7>
Django
Reporter: James Gillard | Owner: nobody
Type: Bug | Status: new
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Mariusz Felisiak):
* version: dev => 4.2
* severity: Normal => Release blocker
* stage: Unreviewed => Accepted
Comment:
Thanks for the report! Regression in
bd0ea8c2ba9943ed245771265f55645dc3bfeae.
--
Ticket URL: <https://code.djangoproject.com/ticket/35012#comment:8>