Re: [Django] #35004: Arrows between "selector available" and "selector chosen" are backwards for RTL languages

15 views
Skip to first unread message

Django

unread,
Nov 30, 2023, 12:06:59 AM11/30/23
to django-...@googlegroups.com
#35004: Arrows between "selector available" and "selector chosen" are backwards for
RTL languages
-------------------------------------+-------------------------------------
Reporter: Natalia Bidart | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: rtl | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* cc: Shai Berger (added)
* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/17556 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/35004#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Nov 30, 2023, 3:39:17 AM11/30/23
to django-...@googlegroups.com
#35004: Arrows between "selector available" and "selector chosen" are backwards for
RTL languages
-------------------------------------+-------------------------------------
Reporter: Natalia Bidart | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed

Keywords: rtl | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"57c1dd466ff0d41760049d6818e82be9d767c7da" 57c1dd4]:
{{{
#!CommitTicketReference repository=""
revision="57c1dd466ff0d41760049d6818e82be9d767c7da"
Fixed #35004 -- Corrected the direction of arrows in admin selector boxes
for RTL languages on small screens.

Follow up to 12617fbd859b1244e91bcf182a2fdf356b388821.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/35004#comment:5>

Django

unread,
Nov 30, 2023, 1:08:54 PM11/30/23
to django-...@googlegroups.com
#35004: Arrows between "selector available" and "selector chosen" are backwards for
RTL languages
-------------------------------------+-------------------------------------
Reporter: Natalia Bidart | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed
Keywords: rtl | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* Attachment "django-admin-wrong-arrow-ltr-before.png" added.

Arrows in small screen for RTL lang before 57c1dd466f

--
Ticket URL: <https://code.djangoproject.com/ticket/35004>

Django

unread,
Nov 30, 2023, 1:18:13 PM11/30/23
to django-...@googlegroups.com
#35004: Arrows between "selector available" and "selector chosen" are backwards for
RTL languages
-------------------------------------+-------------------------------------
Reporter: Natalia Bidart | Owner: Mariusz
| Felisiak
Type: Bug | Status: new

Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: rtl | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* cc: Nick Pope (added)
* status: closed => new
* resolution: fixed =>


Comment:

Mariusz, while the PR does fix the arrow direction in "medium" screens
(tablet size for example), they are now weird in small screens (like
phones, see screenshots). Before this change, the arrows would be "up and
down" for small screen, and now they are "side to side" when the widgets
are one on top of the arrows and the other below the arrows.

* Before 57c1dd466f change:
[[Image(ticket:35004:django-admin-wrong-arrow-rtl-before.png)]]

* After 57c1dd466f change:
[[Image(ticket:35004:django-admin-wrong-arrow-rtl-after.png)]]

--
Ticket URL: <https://code.djangoproject.com/ticket/35004#comment:6>

Django

unread,
Nov 30, 2023, 1:38:54 PM11/30/23
to django-...@googlegroups.com
#35004: Arrows between "selector available" and "selector chosen" are backwards for
RTL languages
-------------------------------------+-------------------------------------
Reporter: Natalia Bidart | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed

Keywords: rtl | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* Attachment "django-admin-wrong-arrow-rtl-after.png" added.

Arrows in small screen for RTL lang after 57c1dd466f

--
Ticket URL: <https://code.djangoproject.com/ticket/35004>

Django

unread,
Nov 30, 2023, 1:48:08 PM11/30/23
to django-...@googlegroups.com
#35004: Arrows between "selector available" and "selector chosen" are backwards for
RTL languages
-------------------------------------+-------------------------------------
Reporter: Natalia Bidart | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed
Keywords: rtl | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* Attachment "django-admin-wrong-arrow-rtl-after.2.png" added.

Django

unread,
Nov 30, 2023, 1:49:51 PM11/30/23
to django-...@googlegroups.com
#35004: Arrows between "selector available" and "selector chosen" are backwards for
RTL languages
-------------------------------------+-------------------------------------
Reporter: Natalia Bidart | Owner: Mariusz
| Felisiak
Type: Bug | Status: new

Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: rtl | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* has_patch: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/35004#comment:7>

Django

unread,
Nov 30, 2023, 1:55:11 PM11/30/23
to django-...@googlegroups.com
#35004: Arrows between "selector available" and "selector chosen" are backwards for
RTL languages
-------------------------------------+-------------------------------------
Reporter: Natalia Bidart | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed

Keywords: rtl | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* Attachment "django-admin-wrong-arrow-rtl-before.png" added.

Arrows in small screen for RTL lang before 57c1dd466f

--
Ticket URL: <https://code.djangoproject.com/ticket/35004>

Django

unread,
Nov 30, 2023, 2:28:20 PM11/30/23
to django-...@googlegroups.com
#35004: Arrows between "selector available" and "selector chosen" are backwards for
RTL languages
-------------------------------------+-------------------------------------
Reporter: Natalia Bidart | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed
Keywords: rtl | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* Attachment "django-admin-wrong-arrow-rtl-after.png" added.

Django

unread,
Nov 30, 2023, 2:37:37 PM11/30/23
to django-...@googlegroups.com
#35004: Arrows between "selector available" and "selector chosen" are backwards for
RTL languages
-------------------------------------+-------------------------------------
Reporter: Natalia Bidart | Owner: Mariusz
| Felisiak
Type: Bug | Status: new

Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: rtl | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak):

Good catch, will work on it tomorrow.

--
Ticket URL: <https://code.djangoproject.com/ticket/35004#comment:8>

Django

unread,
Dec 1, 2023, 12:01:30 AM12/1/23
to django-...@googlegroups.com
#35004: Arrows between "selector available" and "selector chosen" are backwards for
RTL languages
-------------------------------------+-------------------------------------
Reporter: Natalia Bidart | Owner: Mariusz
| Felisiak
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: rtl | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/17565 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/35004#comment:9>

Django

unread,
Dec 1, 2023, 3:46:07 AM12/1/23
to django-...@googlegroups.com
#35004: Arrows between "selector available" and "selector chosen" are backwards for
RTL languages
-------------------------------------+-------------------------------------
Reporter: Natalia Bidart | Owner: Mariusz
| Felisiak
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: rtl | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by GitHub <noreply@…>):

In [changeset:"dafbed9af586bd3973f24f332676a9dc8f501163" dafbed9a]:
{{{
#!CommitTicketReference repository=""
revision="dafbed9af586bd3973f24f332676a9dc8f501163"
Refs #35004 -- Restored the direction of arrows in admin selector boxes
for RTL languages on mobile screens.

Regression in 57c1dd466ff0d41760049d6818e82be9d767c7da.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/35004#comment:10>

Django

unread,
Dec 1, 2023, 3:46:48 AM12/1/23
to django-...@googlegroups.com
#35004: Arrows between "selector available" and "selector chosen" are backwards for
RTL languages
-------------------------------------+-------------------------------------
Reporter: Natalia Bidart | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed

Keywords: rtl | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* status: new => closed
* resolution: => fixed


--
Ticket URL: <https://code.djangoproject.com/ticket/35004#comment:11>

Reply all
Reply to author
Forward
0 new messages