Re: [Django] #35001: Add related object icon (green plus sign) is not fully visible in some screens

[Django]

#35001: Add related object icon (green plus sign) is not fully visible in some
screens
--------------------------------+---------------------------------------
Reporter: Natalia Bidart | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
--------------------------------+---------------------------------------
Changes (by Natalia Bidart):

* stage: Accepted => Unreviewed

Comment:

Sorry I shouldn't have accepted my own ticket :-)

--
Ticket URL: <https://code.djangoproject.com/ticket/35001#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#35001: Add related object icon (green plus sign) is not fully visible in some
screens

---------------------------------+---------------------------------------

Reporter: Natalia Bidart | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev

Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1

---------------------------------+---------------------------------------
Changes (by Mariusz Felisiak):

* severity: Normal => Release blocker
* stage: Unreviewed => Accepted

Comment:

Replying to [comment:1 Natalia Bidart]:
> Regression in d687febce5868545f99974d2499a91f81a32fef5

I don't think it's a proper commit. I can see "+" before and after this
commit, it may be in different places but it's still visible. However
999ba9db6d6331eaa58af77debba42754bcc1a8e made it not visible in some
screens when sidebar is open, so we need to treat this as a regression.

Before 999ba9db6d6331eaa58af77debba42754bcc1a8e
[[Image()]]
After 999ba9db6d6331eaa58af77debba42754bcc1a8e
[[Image()]]

--
Ticket URL: <https://code.djangoproject.com/ticket/35001#comment:5>

[Django]

#35001: Add related object icon (green plus sign) is not fully visible in some
screens
---------------------------------+---------------------------------------
Reporter: Natalia Bidart | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
---------------------------------+---------------------------------------
Changes (by Mariusz Felisiak):

* Attachment "before_34995.png" added.

--
Ticket URL: <https://code.djangoproject.com/ticket/35001>

[Django]

#35001: Add related object icon (green plus sign) is not fully visible in some
screens
---------------------------------+---------------------------------------
Reporter: Natalia Bidart | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
---------------------------------+---------------------------------------
Changes (by Mariusz Felisiak):

* Attachment "after_34995.png" added.

[Django]

#35001: Add related object icon (green plus sign) is not fully visible in some
screens
---------------------------------+---------------------------------------
Reporter: Natalia Bidart | Owner: Tom Carrick
Type: Bug | Status: assigned

Component: contrib.admin | Version: 5.0

Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
---------------------------------+---------------------------------------
Changes (by Mariusz Felisiak):

* version: dev => 5.0

--
Ticket URL: <https://code.djangoproject.com/ticket/35001#comment:6>

[Django]

#35001: Add related object icon (green plus sign) is not fully visible in some
screens
---------------------------------+---------------------------------------
Reporter: Natalia Bidart | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
---------------------------------+---------------------------------------

Comment (by Mariusz Felisiak):

Maybe we could add `flex-wrap: wrap-reverse` to make it always visible,
it's not perfect, but ...
{{{#!diff
diff --git a/django/contrib/admin/static/admin/css/widgets.css
b/django/contrib/admin/static/admin/css/widgets.css
index f5b769333b..64628652ec 100644
--- a/django/contrib/admin/static/admin/css/widgets.css
+++ b/django/contrib/admin/static/admin/css/widgets.css
@@ -582,6 +582,7 @@ ul.timelist, .timelist li {
display: flex;
gap: 10px;
flex-grow: 1;
+ flex-wrap: wrap-reverse;
}

.related-widget-wrapper-link {
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/35001#comment:7>

[Django]

#35001: Add related object icon (green plus sign) is not fully visible in some
screens
---------------------------------+---------------------------------------
Reporter: Natalia Bidart | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
---------------------------------+---------------------------------------

Changes (by Tom Carrick):

* has_patch: 0 => 1

Comment:

[https://github.com/django/django/pull/17566 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/35001#comment:8>

[Django]

#35001: Add related object icon (green plus sign) is not fully visible in some
screens
---------------------------------+---------------------------------------
Reporter: Natalia Bidart | Owner: Tom Carrick

Type: Bug | Status: closed
Component: contrib.admin | Version: 5.0
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
---------------------------------+---------------------------------------

Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"dec8aa68f6a2729e57a58c36a21d36daa9a99fed" dec8aa6]:
{{{
#!CommitTicketReference repository=""
revision="dec8aa68f6a2729e57a58c36a21d36daa9a99fed"
Fixed #35001 -- Fixed position of related widget action icons in admin for
some screen sizes.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/35001#comment:9>

[Django]

#35001: Add related object icon (green plus sign) is not fully visible in some
screens
---------------------------------+---------------------------------------
Reporter: Natalia Bidart | Owner: Tom Carrick
Type: Bug | Status: closed
Component: contrib.admin | Version: 5.0
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
---------------------------------+---------------------------------------

Comment (by Natalia <124304+nessita@…>):

In [changeset:"6c502734a0395c3c937a827716e3c02697f53f9b" 6c502734]:
{{{
#!CommitTicketReference repository=""
revision="6c502734a0395c3c937a827716e3c02697f53f9b"
[5.0.x] Fixed #35001 -- Fixed position of related widget action icons in

admin for some screen sizes.

Backport of dec8aa68f6a2729e57a58c36a21d36daa9a99fed from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/35001#comment:10>