Re: [Django] #34999: Admin search bar input doesn't have proper background color when in dark mode
Django
mode
-------------------------------------+-------------------------------------
Reporter: Raphaël Stefanini | Owner: nobody
Type: Uncategorized | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
| worksforme
Keywords: UI, contrast, admin | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* status: new => closed
* resolution: => worksforme
Comment:
Thanks for this ticket, however it works for me without any changes:
--
Ticket URL: <https://code.djangoproject.com/ticket/34999#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
mode
-------------------------------------+-------------------------------------
Reporter: Raphaël Stefanini | Owner: nobody
Type: Uncategorized | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
| worksforme
Keywords: UI, contrast, admin | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* Attachment "Screenshot_20231129_101841.png" added.
--
Ticket URL: <https://code.djangoproject.com/ticket/34999>
Django
mode
-------------------------------------+-------------------------------------
Reporter: Raphaël Stefanini | Owner: nobody
Type: Uncategorized | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
| worksforme
Keywords: UI, contrast, admin | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
* Attachment "Snapseed.jpeg" added.
ios safari
Django
mode
-------------------------------------+-------------------------------------
Reporter: Raphaël Stefanini | Owner: nobody
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Raphaël Stefanini):
* status: closed => new
* resolution: worksforme =>
Comment:
I have had the issue both on ios safari and a chromium browser based
browser
--
Ticket URL: <https://code.djangoproject.com/ticket/34999#comment:3>
Django
mode
-------------------------------------+-------------------------------------
Reporter: Raphaël Stefanini | Owner: nobody
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: UI, contrast, admin | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => worksforme
Comment:
Again, it works fine for me in both browsers. What version of Django are
you using?
--
Ticket URL: <https://code.djangoproject.com/ticket/34999#comment:4>
Django
mode
-------------------------------------+-------------------------------------
Reporter: Raphaël Stefanini | Owner: nobody
Type: Uncategorized | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
| worksforme
Keywords: UI, contrast, admin | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Raphaël Stefanini):
I have the issue on Mac and iOS with django version 4.2 and 5.0rc1
--
Ticket URL: <https://code.djangoproject.com/ticket/34999#comment:5>
Django
mode
-------------------------------------+-------------------------------------
Reporter: Raphaël Stefanini | Owner: nobody
Type: Uncategorized | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
| worksforme
Keywords: UI, contrast, admin | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak):
Puzzled, the black background is already inherited from `base.css`:
{{{
input[type=text], input[type=password], input[type=email],
input[type=url],
input[type=number], input[type=tel], textarea, select, .vTextField {
border: 1px solid var(--border-color);
border-radius: 4px;
padding: 5px 6px;
margin-top: 0;
color: var(--body-fg);
background-color: var(--body-bg);
}
}}}
You can try to use TicketClosingReasons/UseSupportChannels where folks
will help you debug your issue.
--
Ticket URL: <https://code.djangoproject.com/ticket/34999#comment:6>
Django
mode
-------------------------------------+-------------------------------------
Reporter: Raphaël Stefanini | Owner: nobody
Type: Uncategorized | Status: closed
Component: contrib.admin | Version: 4.2
Keywords: UI, contrast, admin | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
* resolution: worksforme => invalid
Comment:
Ok, after more investigation on my side this is related a middleware I
have in my settings "django_minify_html.middleware.MinifyHtmlMiddleware".
Sorry for the trouble.
--
Ticket URL: <https://code.djangoproject.com/ticket/34999#comment:7>
Django
mode
-------------------------------------+-------------------------------------
Reporter: Raphaël Stefanini | Owner: nobody
Type: Uncategorized | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution: invalid
Keywords: UI, contrast, admin | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak):
Thanks for the follow up.
--
Ticket URL: <https://code.djangoproject.com/ticket/34999#comment:8>
Django
mode
-------------------------------------+-------------------------------------
Reporter: Raphaël Stefanini | Owner: nobody
Type: Uncategorized | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution: invalid
Keywords: UI, contrast, admin | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Raphaël Stefanini):
Adding `input:not([type]),` before `input[type=text],` in base.css would
solve this issue for me.
--
Ticket URL: <https://code.djangoproject.com/ticket/34999#comment:9>