[Django] #34994: Visual regression in admin checkboxes on mobile

[Django]

#34994: Visual regression in admin checkboxes on mobile
-------------------------------------------+------------------------
Reporter: Tom Carrick | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+------------------------
I think it may have been intentional, but it looks pretty wrong.

--
Ticket URL: <https://code.djangoproject.com/ticket/34994>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#34994: Visual regression in admin checkboxes on mobile

---------------------------------+--------------------------------------

Reporter: Tom Carrick | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.admin | Version: 4.2

Severity: Release blocker | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

---------------------------------+--------------------------------------
Changes (by Tom Carrick):

* Attachment "admin-checkboxes.png" added.

[Django]

#34994: Visual regression in admin checkboxes on mobile
---------------------------------+--------------------------------------
Reporter: Tom Carrick | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------

Description changed by Tom Carrick:

Old description:

> I think it may have been intentional, but it looks pretty wrong.

New description:

I think it may have been intentional, but it looks pretty wrong.

[[Image(https://code.djangoproject.com/attachment/ticket/34994/admin-
checkboxes.png)]]

--

--
Ticket URL: <https://code.djangoproject.com/ticket/34994#comment:1>

[Django]

#34994: Visual regression in admin checkboxes on mobile

---------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: assigned

Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:

Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

---------------------------------+---------------------------------------
Changes (by Mariusz Felisiak):

* owner: nobody => Tom Carrick
* status: new => assigned
* type: Uncategorized => Bug
* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/34994#comment:2>

[Django]

#34994: Visual regression in admin checkboxes on mobile
---------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+---------------------------------------

Comment (by Mariusz Felisiak):

Regression in b4817d20b9e55df30be0b1b2ca8c8bb6d61aab07.

--
Ticket URL: <https://code.djangoproject.com/ticket/34994#comment:3>

[Django]

#34994: Visual regression in admin checkboxes on mobile
---------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick

Type: Uncategorized | Status: assigned

Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:

Keywords: | Triage Stage: Unreviewed

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+---------------------------------------

Changes (by Tom Carrick):

* type: Bug => Uncategorized
* stage: Accepted => Unreviewed

--
Ticket URL: <https://code.djangoproject.com/ticket/34994#comment:4>

[Django]

#34994: Visual regression in admin checkboxes on mobile
---------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick

Type: Bug | Status: assigned

Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:

Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+---------------------------------------
Changes (by Tom Carrick):

* type: Uncategorized => Bug

* stage: Unreviewed => Accepted

Comment:

oops, sorry

--
Ticket URL: <https://code.djangoproject.com/ticket/34994#comment:5>

[Django]

#34994: Visual regression in admin checkboxes on mobile
---------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+---------------------------------------

Comment (by Tom Carrick):

[https://github.com/django/django/pull/17516 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/34994#comment:6>

[Django]

#34994: Visual regression in admin checkboxes on mobile
---------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+---------------------------------------

Changes (by Tom Carrick):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/34994#comment:7>

[Django]

#34994: Visual regression in admin checkboxes on mobile
---------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+---------------------------------------

Comment (by Natalia Bidart):

As per my testing, this is a regression in
d687febce5868545f99974d2499a91f81a32fef5 not in
b4817d20b9e55df30be0b1b2ca8c8bb6d61aab07.

--
Ticket URL: <https://code.djangoproject.com/ticket/34994#comment:8>

[Django]

#34994: Visual regression in admin checkboxes on mobile
---------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+---------------------------------------

Comment (by Mariusz Felisiak):

Replying to [comment:8 Natalia Bidart]:

> As per my testing, this is a regression in
d687febce5868545f99974d2499a91f81a32fef5 not in
b4817d20b9e55df30be0b1b2ca8c8bb6d61aab07.

Are you sure? I checked with Django 4.2.7 and it's centered, it looks fine
in Django 4.1.13.

--
Ticket URL: <https://code.djangoproject.com/ticket/34994#comment:9>

[Django]

#34994: Visual regression in admin checkboxes on mobile
---------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+---------------------------------------

Comment (by Natalia Bidart):

Replying to [comment:9 Mariusz Felisiak]:

> Replying to [comment:8 Natalia Bidart]:
> > As per my testing, this is a regression in
d687febce5868545f99974d2499a91f81a32fef5 not in
b4817d20b9e55df30be0b1b2ca8c8bb6d61aab07.
>
> Are you sure? I checked with Django 4.2.7 and it's centered, it looks
fine in Django 4.1.13.

Yes, I'm sure. I checked out revno
d687febce5868545f99974d2499a91f81a32fef5 and the problem is clearly there,
and then I checked out the revno right before it
(21757bbdcd6ef31f2a4092fa1bd55dff29214c7a) and the check boxes are OK.

d687febce5868545f99974d2499a91f81a32fef5 was backported to 4.2 in revno
788f7b8100dbef050129bf5c1e0af47e7bc89b28

--
Ticket URL: <https://code.djangoproject.com/ticket/34994#comment:10>

[Django]

#34994: Visual regression in admin checkboxes on mobile
---------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+---------------------------------------

Comment (by Mariusz Felisiak):

> d687febce5868545f99974d2499a91f81a32fef5 was backported to 4.2 in revno
788f7b8100dbef050129bf5c1e0af47e7bc89b28

So it's still a release blocker for Django 4.2.

--
Ticket URL: <https://code.djangoproject.com/ticket/34994#comment:11>

[Django]

#34994: Visual regression in admin checkboxes on mobile
---------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick

Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+---------------------------------------

Changes (by Natalia <124304+nessita@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"a89c715c3bcf7ab1a90747cf8658ebce6304b6e4" a89c715c]:
{{{
#!CommitTicketReference repository=""
revision="a89c715c3bcf7ab1a90747cf8658ebce6304b6e4"
Fixed #34994 -- Fixed checkbox layout in admin's change page for narrow
screen widths.

Regression in d687febce5868545f99974d2499a91f81a32fef5.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34994#comment:12>

[Django]

#34994: Visual regression in admin checkboxes on mobile
---------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+---------------------------------------

Comment (by Natalia <124304+nessita@…>):

In [changeset:"4d33816ca6a8e5e9a87cfabd9dcd83e416b4f814" 4d33816c]:
{{{
#!CommitTicketReference repository=""
revision="4d33816ca6a8e5e9a87cfabd9dcd83e416b4f814"
[5.0.x] Fixed #34994 -- Fixed checkbox layout in admin's change page for
narrow screen widths.

Regression in d687febce5868545f99974d2499a91f81a32fef5.

Backport of a89c715c3bcf7ab1a90747cf8658ebce6304b6e4 from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34994#comment:13>

[Django]

#34994: Visual regression in admin checkboxes on mobile
---------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+---------------------------------------

Comment (by Natalia <124304+nessita@…>):

In [changeset:"bac9e94ace79d79c55e94b8aba05db0d148430e2" bac9e94]:
{{{
#!CommitTicketReference repository=""
revision="bac9e94ace79d79c55e94b8aba05db0d148430e2"
[4.2.x] Fixed #34994 -- Fixed checkbox layout in admin's change page for
narrow screen widths.

Regression in d687febce5868545f99974d2499a91f81a32fef5.

Backport of a89c715c3bcf7ab1a90747cf8658ebce6304b6e4 from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34994#comment:14>

[Django]

#34994: Visual regression in admin checkboxes on mobile

-------------------------------------+-------------------------------------

Reporter: Tom Carrick | Owner: Tom
| Carrick
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/34994#comment:15>

[Django]

#34994: Visual regression in admin checkboxes on mobile
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
| Carrick
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Adam Johnson):

* Attachment "Xnapper-2024-04-18-12.31.19.png" added.

two checkboxes centred

--
Ticket URL: <https://code.djangoproject.com/ticket/34994>

[Django]

#34994: Visual regression in admin checkboxes on mobile
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
| Carrick
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Adam Johnson):

This is still broken for fieldsets with a checkbox plus another field on
the same line, like:

{{{
class SwitcherAdmin(admin.ModelAdmin):
fieldsets = [
(
None,
{
"fields": [
("up", "down"),
],
},
),
]
}}}

[[Image(https://code.djangoproject.com/raw-
attachment/ticket/34994/Xnapper-2024-04-18-12.31.19.png, 640px)]]

This is due to `checkbox-row` being only applied when there’s a single
checkbox in the row. I am making a small PR that fixes this issue and
another, #35386. Follw on that ticket.
--
Ticket URL: <https://code.djangoproject.com/ticket/34994#comment:16>

[Django]

#34994: Visual regression in admin checkboxes on mobile
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
| Carrick
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Sarah Boyce <42296566+sarahboyce@…>):

In [changeset:"bdd76c4c3817d8e3ed5b0450d5e18e4eae096f16" bdd76c4]:
{{{#!CommitTicketReference repository=""
revision="bdd76c4c3817d8e3ed5b0450d5e18e4eae096f16"
Fixed #34994, Fixed #35386 -- Applied checkbox-row CSS class
unconditionally in Admin.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34994#comment:17>

[Django]

#34994: Visual regression in admin checkboxes on mobile
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
| Carrick
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Sarah Boyce <42296566+sarahboyce@…>):

In [changeset:"ffcf66071158ed3b5541ed13b4c7381240d1b310" ffcf6607]:
{{{#!CommitTicketReference repository=""
revision="ffcf66071158ed3b5541ed13b4c7381240d1b310"
[5.0.x] Fixed #34994, Fixed #35386 -- Applied checkbox-row CSS class
unconditionally in Admin.

Backport of bdd76c4c3817d8e3ed5b0450d5e18e4eae096f16 from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34994#comment:18>

[Django]

#34994: Visual regression in admin checkboxes on mobile
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
| Carrick
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Sarah Boyce <42296566+sarahboyce@…>):

In [changeset:"0fc832676cd585fa420d583937b5b2318bc2c629" 0fc8326]:
{{{#!CommitTicketReference repository=""
revision="0fc832676cd585fa420d583937b5b2318bc2c629"
[4.2.x] Fixed #34994, Fixed #35386 -- Applied checkbox-row CSS class

unconditionally in Admin.

Backport of bdd76c4c3817d8e3ed5b0450d5e18e4eae096f16 from main.
}}}
--

Ticket URL: <https://code.djangoproject.com/ticket/34994#comment:19>

[Django]

#34994: Visual regression in admin checkboxes on mobile
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
| Carrick
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Sarah Boyce <42296566+sarahboyce@…>):

In [changeset:"256f719cb38eee49dcc529ddf1e0b95aa440d133" 256f719]:
{{{#!CommitTicketReference repository=""
revision="256f719cb38eee49dcc529ddf1e0b95aa440d133"
[4.2.x] Reverted "Fixed #34994, Fixed #35386 -- Applied checkbox-row CSS
class unconditionally in Admin."

This reverts commit 0fc832676cd585fa420d583937b5b2318bc2c629.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34994#comment:20>

[Django]

#34994: Visual regression in admin checkboxes on mobile
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
| Carrick
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Sarah Boyce <42296566+sarahboyce@…>):

In [changeset:"a42a2fa267c68ed2cc97559396178deaa9477ef3" a42a2fa]:
{{{#!CommitTicketReference repository=""
revision="a42a2fa267c68ed2cc97559396178deaa9477ef3"
[5.0.x] Reverted "Fixed #34994, Fixed #35386 -- Applied checkbox-row CSS
class unconditionally in Admin."

This reverts commit ffcf66071158ed3b5541ed13b4c7381240d1b310.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34994#comment:21>