Re: [Django] #34991: Wrong layout of pagination buttons with editable list in the admin.
Django
---------------------------------+---------------------------------------
Reporter: Rafał Safin | Owner: Rafał Safin
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: CSS,admin | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
---------------------------------+---------------------------------------
Changes (by Mariusz Felisiak):
* Attachment "django42.png" added.
--
Ticket URL: <https://code.djangoproject.com/ticket/34991>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
---------------------------------+---------------------------------------
Reporter: Rafał Safin | Owner: Rafał Safin
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: CSS,admin | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
---------------------------------+---------------------------------------
Changes (by Mariusz Felisiak):
* Attachment "django41.png" added.
Django
---------------------------------+---------------------------------------
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: CSS,admin | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
---------------------------------+---------------------------------------
* owner: Rafał Safin => Tom Carrick
Comment:
I'll take a look, this seems reasonable.
--
Ticket URL: <https://code.djangoproject.com/ticket/34991#comment:3>
Django
---------------------------------+---------------------------------------
Reporter: Rafał Safin | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: CSS,admin | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+---------------------------------------
Changes (by Tom Carrick):
* needs_better_patch: 1 => 0
Comment:
[https://github.com/django/django/pull/17514 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/34991#comment:4>
Django
---------------------------------+---------------------------------------
Reporter: Rafał Safin | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: CSS,admin | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+---------------------------------------
Comment (by Tom Carrick):
Rafał, not sure if you were still working on this. If so, sorry!
--
Ticket URL: <https://code.djangoproject.com/ticket/34991#comment:5>
Django
Reporter: Rafał Safin | Owner: Tom
| Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Natalia Bidart):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/34991#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Rafał Safin | Owner: Tom
| Carrick
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: CSS,admin | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"4eb9c3d90aff55182151b6be0122f7d0b28832fd" 4eb9c3d9]:
{{{
#!CommitTicketReference repository=""
revision="4eb9c3d90aff55182151b6be0122f7d0b28832fd"
Fixed #34991 -- Fixed pagination links and input layout in admin's change
list page when using list_editable.
Regression in b4817d20b9e55df30be0b1b2ca8c8bb6d61aab07.
Thanks Tom Carrick for the report and fix.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34991#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: Rafał Safin | Owner: Tom
| Carrick
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: CSS,admin | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Natalia <124304+nessita@…>):
In [changeset:"3d943c4f55e24eb77a5fc70e6253e182110d80f6" 3d943c4f]:
{{{
#!CommitTicketReference repository=""
revision="3d943c4f55e24eb77a5fc70e6253e182110d80f6"
[4.2.x] Fixed #34991 -- Fixed pagination links and input layout in admin's
change list page when using list_editable.
Regression in b4817d20b9e55df30be0b1b2ca8c8bb6d61aab07.
Thanks Tom Carrick for the report and fix.
Backport of 4eb9c3d90aff55182151b6be0122f7d0b28832fd from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34991#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: Rafał Safin | Owner: Tom
| Carrick
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: CSS,admin | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Natalia <124304+nessita@…>):
In [changeset:"15d49c80820be1a15e6e9e296a6948163b827fec" 15d49c8]:
{{{
#!CommitTicketReference repository=""
revision="15d49c80820be1a15e6e9e296a6948163b827fec"
[5.0.x] Fixed #34991 -- Fixed pagination links and input layout in admin's
change list page when using list_editable.
Regression in b4817d20b9e55df30be0b1b2ca8c8bb6d61aab07.
Thanks Tom Carrick for the report and fix.
Backport of 4eb9c3d90aff55182151b6be0122f7d0b28832fd from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34991#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: Rafał Safin | Owner: Tom
| Carrick
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: CSS,admin | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Rafał Safin):
Thank you for valuable input Mateusz.
No, I didn't work more on it @Tom, as pointed out (closed PR), I didn't
have the context on how this should be fixed properly and what is desired
look, so after reading Mateusz's comment, I decided that someone else
would probably have better idea :D
Thanks for the fix everyone! :P ;)
--
Ticket URL: <https://code.djangoproject.com/ticket/34991#comment:10>