[Django] #34977: Turn link to change password form in admin user change form into a button

[Django]

#34977: Turn link to change password form in admin user change form into a button
------------------------------------------------+------------------------
Reporter: Fabian Braun | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.auth | Version: 4.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 1 |
------------------------------------------------+------------------------
Currently, to change a user's password the admin user must got to the
change user form, find the password field and click a link in its help
text.

[[Image()]]

For better user guidance and accessibility, I suggest turning this link
into a button:

[[Image(https://user-
images.githubusercontent.com/16904477/283912840-eeee524b-3845-411a-a804-7217d8778e62.png)]]

As David Smith pointed out, links in help texts are not read by screen
readers:

"Do not include links within hint text. While screen readers will read out
the link text when describing the field, they will not tell users that the
text is a link." (https://design-system.service.gov.uk/components/text-
input/#hint-text).

I'll be happy to provide a patch.

--
Ticket URL: <https://code.djangoproject.com/ticket/34977>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#34977: Turn link to change password form in admin user change form into a button

-------------------------------------+-------------------------------------

Reporter: Fabian Braun | Owner: nobody

Type: | Status: new
Cleanup/optimization |
Component: contrib.auth | Version: 4.2
Severity: Normal | Resolution:

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1

-------------------------------------+-------------------------------------
Changes (by Fabian Braun):

* Attachment "password-link.jpg" added.

Current link to change password form

[Django]

#34977: Turn link to change password form in admin user change form into a button
-------------------------------------+-------------------------------------
Reporter: Fabian Braun | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.auth | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Description changed by Fabian Braun:

Old description:

> Currently, to change a user's password the admin user must got to the
> change user form, find the password field and click a link in its help
> text.
>
> [[Image()]]
>
> For better user guidance and accessibility, I suggest turning this link
> into a button:
>
> [[Image(https://user-
> images.githubusercontent.com/16904477/283912840-eeee524b-3845-411a-a804-7217d8778e62.png)]]
>
> As David Smith pointed out, links in help texts are not read by screen
> readers:
>
> "Do not include links within hint text. While screen readers will read
> out the link text when describing the field, they will not tell users

> that the text is a link." (https://design-

> system.service.gov.uk/components/text-input/#hint-text).
>
> I'll be happy to provide a patch.

New description:

Currently, to change a user's password the admin user must got to the
change user form, find the password field and click a link in its help
text.

[[Image(https://code.djangoproject.com/raw-attachment/ticket/34977
/password-link.jpg)]]

For better user guidance and accessibility, I suggest turning this link
into a button:

[[Image(https://user-
images.githubusercontent.com/16904477/283912840-eeee524b-3845-411a-a804-7217d8778e62.png)]]

As David Smith pointed out, links in help texts are not read by screen
readers:

"Do not include links within hint text. While screen readers will read out
the link text when describing the field, they will not tell users that the
text is a link." (https://design-system.service.gov.uk/components/text-
input/#hint-text).

I'll be happy to provide a patch.

--

--
Ticket URL: <https://code.djangoproject.com/ticket/34977#comment:1>

[Django]

#34977: Turn link to change password form in admin user change form into a button
-------------------------------------+-------------------------------------
Reporter: Fabian Braun | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.auth | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Fabian Braun):

* Attachment "password-button.png" added.

Potential new change or (in this case) set password button.

--
Ticket URL: <https://code.djangoproject.com/ticket/34977>

[Django]

#34977: Turn link to change password form in admin user change form into a button
-------------------------------------+-------------------------------------
Reporter: Fabian Braun | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.auth | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Description changed by Fabian Braun:

Old description:

> Currently, to change a user's password the admin user must got to the
> change user form, find the password field and click a link in its help
> text.
>

> [[Image(https://code.djangoproject.com/raw-attachment/ticket/34977
> /password-link.jpg)]]
>
> For better user guidance and accessibility, I suggest turning this link
> into a button:
>
> [[Image(https://user-
> images.githubusercontent.com/16904477/283912840-eeee524b-3845-411a-a804-7217d8778e62.png)]]
>
> As David Smith pointed out, links in help texts are not read by screen
> readers:
>
> "Do not include links within hint text. While screen readers will read
> out the link text when describing the field, they will not tell users
> that the text is a link." (https://design-
> system.service.gov.uk/components/text-input/#hint-text).
>
> I'll be happy to provide a patch.

New description:

Currently, to change a user's password the admin user must got to the
change user form, find the password field and click a link in its help
text.

[[Image(https://code.djangoproject.com/raw-attachment/ticket/34977
/password-link.jpg)]]

For better user guidance and accessibility, I suggest turning this link
into a button:

[[Image(https://code.djangoproject.com/raw-attachment/ticket/34977
/password-button.png)]]

As David Smith pointed out, links in help texts are not read by screen
readers:

"Do not include links within hint text. While screen readers will read out
the link text when describing the field, they will not tell users that the
text is a link." (https://design-system.service.gov.uk/components/text-
input/#hint-text).

I'll be happy to provide a patch.

--

--
Ticket URL: <https://code.djangoproject.com/ticket/34977#comment:2>

[Django]

#34977: Turn link to change password form in admin user change form into a button
-------------------------------------+-------------------------------------

Reporter: Fabian Braun | Owner: Fabian
Type: | Braun
Cleanup/optimization | Status: assigned

Component: contrib.auth | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Fabian Braun):

* owner: nobody => Fabian Braun
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/34977#comment:3>

[Django]

#34977: Turn link to change password form in admin user change form into a button
-------------------------------------+-------------------------------------
Reporter: Fabian Braun | Owner: Fabian
Type: | Braun
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Fabian Braun):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/34977#comment:4>

[Django]

#34977: Turn link to change password form in admin user change form into a button
-------------------------------------+-------------------------------------
Reporter: Fabian Braun | Owner: Fabian
Type: | Braun
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Fabian Braun):

* owner: Fabian Braun => Fabian Braun

--
Ticket URL: <https://code.djangoproject.com/ticket/34977#comment:5>

[Django]

#34977: Turn link to change password form in admin user change form into a button
-------------------------------------+-------------------------------------
Reporter: Fabian Braun | Owner: Fabian
Type: | Braun
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: 4.2
Severity: Normal | Resolution:

Keywords: accessibility | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* keywords: => accessibility
* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/34977#comment:6>

[Django]

#34977: Turn link to change password form in admin user change form into a button
-------------------------------------+-------------------------------------
Reporter: Fabian Braun | Owner: Fabian
Type: | Braun
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Natalia Bidart):

I added some review comments proposing a slightly different approach:
instead of having either a link or a button *in* the help text, I would
like that we separate the help text legend from the "convenience shortcut"
to hint the admin user where they can act regarding the password.

I'd like the accessibility team's input, I attached a possible diff to the
[https://github.com/django/django/pull/17489#issuecomment-1879361460
linked PR].

--
Ticket URL: <https://code.djangoproject.com/ticket/34977#comment:7>

[Django]

#34977: Turn link to change password form in admin user change form into a button
-------------------------------------+-------------------------------------
Reporter: Fabian Braun | Owner: Fabian
Type: | Braun
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Natalia Bidart):

* cc: Thibaud Colas, Tom Carrick, Sarah Abderemane (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/34977#comment:8>

[Django]

#34977: Turn link to change password form in admin user change form into a button
-------------------------------------+-------------------------------------
Reporter: Fabian Braun | Owner: Fabian
Type: | Braun
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Abhii67534):

I would like to work on this issue :)
--
Ticket URL: <https://code.djangoproject.com/ticket/34977#comment:9>

[Django]

#34977: Turn link to change password form in admin user change form into a button
-------------------------------------+-------------------------------------
Reporter: Fabian Braun | Owner: Fabian
Type: | Braun
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Natalia Bidart):

Replying to [comment:9 Abhii67534]:

I would like to work on this issue :)

Thank you for your interest in helping, but there is already a submitted
PR solving this issue, we are just waiting on some specific feedback.
--
Ticket URL: <https://code.djangoproject.com/ticket/34977#comment:10>

[Django]

#34977: Turn link to change password form in admin user change form into a button
-------------------------------------+-------------------------------------
Reporter: Fabian Braun | Owner: Fabian
Type: | Braun
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Natalia Bidart):

* needs_better_patch: 0 => 1

Comment:

Setting as patch needs improvement until conflicts are solved and the PR
is reviewable again.
--
Ticket URL: <https://code.djangoproject.com/ticket/34977#comment:11>

[Django]

#34977: Turn link to change password form in admin user change form into a button
-------------------------------------+-------------------------------------
Reporter: Fabian Braun | Owner: Fabian
Type: | Braun
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Fabian Braun):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/34977#comment:12>

[Django]

#34977: Turn link to change password form in admin user change form into a button
-------------------------------------+-------------------------------------
Reporter: Fabian Braun | Owner: Fabian
Type: | Braun
Cleanup/optimization | Status: assigned

Component: contrib.auth | Version: dev

Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Natalia Bidart):

* needs_better_patch: 0 => 1

* needs_docs: 0 => 1
* version: 4.2 => dev

--
Ticket URL: <https://code.djangoproject.com/ticket/34977#comment:13>

[Django]

#34977: Turn link to change password form in admin user change form into a button
-------------------------------------+-------------------------------------
Reporter: Fabian Braun | Owner: Fabian
Type: | Braun
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: dev
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Fabian Braun):

* needs_better_patch: 1 => 0

* needs_docs: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/34977#comment:14>

[Django]

#34977: Turn link to change password form in admin user change form into a button
-------------------------------------+-------------------------------------
Reporter: Fabian Braun | Owner: Fabian
Type: | Braun
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: dev
Severity: Normal | Resolution:

Keywords: accessibility | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Natalia Bidart):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/34977#comment:15>

[Django]

#34977: Turn link to change password form in admin user change form into a button
-------------------------------------+-------------------------------------
Reporter: Fabian Braun | Owner: Fabian
Type: | Braun

Cleanup/optimization | Status: closed
Component: contrib.auth | Version: dev
Severity: Normal | Resolution: fixed

Keywords: accessibility | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Natalia <124304+nessita@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"944745afe2ec45aed30cef799c250107f1364ca7" 944745af]:
{{{#!CommitTicketReference repository=""
revision="944745afe2ec45aed30cef799c250107f1364ca7"
Fixed #34977 -- Improved accessibility in the UserChangeForm by replacing
the reset password link with a button.

Co-authored-by: Natalia <124304+...@users.noreply.github.com>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34977#comment:16>