[Django] #33166: Missing context when rendering form widgets
Django
-------------------------------------+-------------------------------------
Reporter: Jacob | Owner: nobody
Rief |
Type: | Status: new
Cleanup/optimization |
Component: Forms | Version: 4.0
Severity: Normal | Keywords: form, widget,
Triage Stage: | context
Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Unsure if this shall be a feature request, but I noticed that when
rendering a field label, the template's rendering context additionally
contains the `field`- and the `form`-object. If however, I render the
widget itself, this information is not available inside the widget's
template rendering context. Apart from this inconsistency, being able to
access the `field`- and/or the `form`-object, when rendering a widget is
really useful.
Example:
I would like to use the `form`-attribute inside some `<input …>`-widgets,
so that each field can refer to its corresponding form. See
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#attr-form
for details. The `form`-object itself provides a name, which is used as
the `<form id="…" …>`. Therefore each widget has to know their form's
name. This information currently can not be determined inside the widget's
template.
--
Ticket URL: <https://code.djangoproject.com/ticket/33166>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Type: | Status: new
Cleanup/optimization |
Component: Forms | Version: 4.0
Keywords: form, widget, | Triage Stage:
context | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Claude Paroz):
Note that `form` is no longer in the context after #33134.
--
Ticket URL: <https://code.djangoproject.com/ticket/33166#comment:1>
Django
-------------------------------------+-------------------------------------
Type: | Status: new
Cleanup/optimization |
Component: Forms | Version: 4.0
Keywords: form, widget, | Triage Stage:
context | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Jacob Rief):
Well, in case of the label rendering context, the `form`-object is
accessible through the `field`. However, the widget rendering context
doesn't offer the `field`-object.
--
Ticket URL: <https://code.djangoproject.com/ticket/33166#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: Jacob Rief | Owner: nobody
Component: Forms | Version: 4.0
Severity: Normal | Resolution:
Keywords: form, widget, | Triage Stage: Accepted
context |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* cc: David Smith (added)
* type: Cleanup/optimization => New feature
* stage: Unreviewed => Accepted
Comment:
Tentatively accepted, this will require passing `field` to the
`Widget.render()`.
This is not strictly related with
456466d932830b096d39806e291fe23ec5ed38d5.
--
Ticket URL: <https://code.djangoproject.com/ticket/33166#comment:3>
Django
-------------------------------------+-------------------------------------
| Rief
Type: New feature | Status: assigned
Component: Forms | Version: 4.0
Severity: Normal | Resolution:
Keywords: form, widget, | Triage Stage: Accepted
context |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: nobody => Jacob Rief
* status: new => assigned
* has_patch: 0 => 1
Comment:
Here is a draft pull request to implement this:
https://github.com/django/django/pull/14955
--
Ticket URL: <https://code.djangoproject.com/ticket/33166#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Jacob Rief | Owner: Jacob
| Rief
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: form, widget, | Triage Stage: Accepted
context |
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/33166#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Jacob Rief | Owner: Jacob
| Rief
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: form, widget, | Triage Stage: Accepted
context |
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by David Smith):
I wonder about creating a circular context here. A field has a widget and
you can access the field from the context of the widget and so on. See
#33134 for a recent bug with field labels.
--
Ticket URL: <https://code.djangoproject.com/ticket/33166#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Jacob Rief | Owner: Jacob
| Rief
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: form, widget, | Triage Stage: Accepted
context |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
Comment:
This should be review again.
--
Ticket URL: <https://code.djangoproject.com/ticket/33166#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: Jacob Rief | Owner: Jacob
| Rief
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: form, widget, | Triage Stage: Accepted
context |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* cc: Sarah Boyce (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/33166#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: Jacob Rief | Owner: Jacob
| Rief
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: form, widget, | Triage Stage: Accepted
context |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Carlton Gibson):
As per David's comment on the PR here, we should resolve #34077 first, to
see if that gives everything needed here.
--
Ticket URL: <https://code.djangoproject.com/ticket/33166#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: Jacob Rief | Owner: Jacob
| Rief
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: form, widget, | Triage Stage: Accepted
context |
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
Comment:
Marking as "Patch needs improvement" as this is waiting for #34077.
--
Ticket URL: <https://code.djangoproject.com/ticket/33166#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: Jacob Rief | Owner: Jacob
| Rief
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: form, widget, | Triage Stage: Accepted
context |
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak):
Jacob, Have you seen cad376f844c7bdeeee7607a7c0ea8ae52061309b? Do we still
need this change?
--
Ticket URL: <https://code.djangoproject.com/ticket/33166#comment:11>
Django
-------------------------------------+-------------------------------------
Reporter: Jacob Rief | Owner: Jacob
| Rief
Component: Forms | Version: 4.0
Severity: Normal | Resolution: wontfix
Keywords: form, widget, | Triage Stage:
context | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* needs_better_patch: 1 => 0
* has_patch: 1 => 0
* resolution: => wontfix
* stage: Accepted => Unreviewed
Comment:
I think it's no longer needed after
cad376f844c7bdeeee7607a7c0ea8ae52061309b.
--
Ticket URL: <https://code.djangoproject.com/ticket/33166#comment:12>