Re: [Django] #14611: Added dedicated option to test.Client methods (other than get()) for passing query parameters.

[Django]

#14611: Added dedicated option to test.Client methods (other than get()) for
passing query parameters.
-----------------------------------+------------------------------------
Reporter: Jari Pennanen | Owner: nobody
Type: New feature | Status: closed
Component: Testing framework | Version: 1.2
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------

Comment (by Lily Foote):

The forum discussion suggested that `query_params` is the most consistent
with similar apis in Django. I'd go with that.

--
Ticket URL: <https://code.djangoproject.com/ticket/14611#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#14611: Added dedicated option to test.Client methods (other than get()) for
passing query parameters.
-----------------------------------+------------------------------------
Reporter: Jari Pennanen | Owner: nobody

Type: New feature | Status: new

Component: Testing framework | Version: 1.2
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------

Changes (by Mariusz Felisiak):

* status: closed => new
* needs_docs: 1 => 0
* resolution: wontfix =>
* needs_tests: 1 => 0

Comment:

Accepted based on the forum discussion.

--
Ticket URL: <https://code.djangoproject.com/ticket/14611#comment:11>

[Django]

#14611: Added dedicated option to test.Client methods (other than get()) for
passing query parameters.

-----------------------------------+---------------------------------------
Reporter: Jari Pennanen | Owner: Tom Carrick
Type: New feature | Status: assigned

Component: Testing framework | Version: 1.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-----------------------------------+---------------------------------------
Changes (by Tom Carrick):

* owner: nobody => Tom Carrick
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/14611#comment:12>

[Django]

#14611: Added dedicated option to test.Client methods (other than get()) for
passing query parameters.
-----------------------------------+---------------------------------------
Reporter: Jari Pennanen | Owner: Tom Carrick
Type: New feature | Status: assigned
Component: Testing framework | Version: 1.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+---------------------------------------
Changes (by Tom Carrick):

* has_patch: 0 => 1

Comment:

[https://github.com/django/django/pull/17447 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/14611#comment:13>

[Django]

#14611: Added dedicated option to test.Client methods (other than get()) for
passing query parameters.
-----------------------------------+---------------------------------------
Reporter: Jari Pennanen | Owner: Tom Carrick
Type: New feature | Status: assigned
Component: Testing framework | Version: 1.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-----------------------------------+---------------------------------------

Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1

Comment:

We need to decide what to do with `get()` and `head()`.

--
Ticket URL: <https://code.djangoproject.com/ticket/14611#comment:14>

[Django]

#14611: Added dedicated option to test.Client methods (other than get()) for
passing query parameters.

-------------------------------------+-------------------------------------

Reporter: Jari Pennanen | Owner: Tom
| Carrick
Type: New feature | Status: assigned
Component: Testing framework | Version: 1.2
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/14611#comment:15>

[Django]

#14611: Added dedicated option to test.Client methods (other than get()) for
passing query parameters.
-------------------------------------+-------------------------------------
Reporter: Jari Pennanen | Owner: Tom
| Carrick

Type: New feature | Status: closed

Component: Testing framework | Version: 1.2

Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"a03593967f098cf8dab79065bcabbcebd461f05b" a0359396]:
{{{
#!CommitTicketReference repository=""
revision="a03593967f098cf8dab79065bcabbcebd461f05b"
Fixed #14611 -- Added query_params argument to RequestFactory and Client
classes.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/14611#comment:16>