[Django] #34958: Intermittent `messages_tests.tests.TestLevelTags.test_lazy` test failure
Django
-----------------------------------------+------------------------
Reporter: bcail | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 4.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
I get following test failure sometimes (it's happened on py3.11, py3.12,
and py3.13a1). Seems to be some kind of race condition.
{{{
======================================================================
FAIL: test_lazy (messages_tests.tests.TestLevelTags.test_lazy)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/opt/python-3.12.0/lib/python3.12/unittest/case.py", line 58, in
testPartExecutor
yield
File "/opt/python-3.12.0/lib/python3.12/unittest/case.py", line 634, in
run
self._callTestMethod(testMethod)
^^^^^^^^^^^^^^^^^
File "/opt/python-3.12.0/lib/python3.12/unittest/case.py", line 589, in
_callTestMethod
if method() is not None:
^^^^^^^^^^^^^^^^^
File "/opt/local/src/django/tests/messages_tests/tests.py", line 73, in
test_lazy
self.assertEqual(base.LEVEL_TAGS[constants.ERROR], "bad")
^^^^^^^^^^^^^^^^^
File "/opt/python-3.12.0/lib/python3.12/unittest/case.py", line 885, in
assertEqual
assertion_func(first, second, msg=msg)
^^^^^^^^^^^^^^^^^
File "/opt/python-3.12.0/lib/python3.12/unittest/case.py", line 1251, in
assertMultiLineEqual
self.fail(self._formatMessage(msg, standardMsg))
^^^^^^^^^^^^^^^^^
File "/opt/python-3.12.0/lib/python3.12/unittest/case.py", line 715, in
fail
raise self.failureException(msg)
^^^^^^^^^^^^^^^^^
AssertionError: 'error' != 'bad'
- error
+ bad
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34958>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: bcail | Owner: nobody
Type: Uncategorized | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by bcail):
* version: 4.2 => dev
--
Ticket URL: <https://code.djangoproject.com/ticket/34958#comment:1>
Django
------------------------------+--------------------------------------
Reporter: bcail | Owner: nobody
Component: Core (Other) | Version: dev
Severity: Normal | Resolution: worksforme
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* status: new => closed
* resolution: => worksforme
* component: Uncategorized => Core (Other)
* type: Uncategorized => Bug
Comment:
Thanks for this report, however, I cannot reproduce the failure in any way
(Python 3.10, 3.12, 3.13),
--
Ticket URL: <https://code.djangoproject.com/ticket/34958#comment:2>
Django
------------------------------+--------------------------------------
Reporter: bcail | Owner: nobody
Type: Bug | Status: closed
Component: Core (Other) | Version: dev
Severity: Normal | Resolution: worksforme
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+--------------------------------------
Comment (by bcail):
More info: I'm on Linux. So far, I've only reproduced the issue running
the tests with 12 or more parallel processes.
--
Ticket URL: <https://code.djangoproject.com/ticket/34958#comment:3>
Django
Reporter: bcail | Owner: nobody
Type: Bug | Status: new
Component: contrib.messages | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Natalia Bidart):
* status: closed => new
* resolution: worksforme =>
* component: Core (Other) => contrib.messages
* stage: Unreviewed => Accepted
Comment:
Accepting since we got the same failure in our CI
[https://djangoci.com/job/main-
random/database=spatialite,label=focal,python=python3.11/124/consoleFull
logs]:
{{{
Started by upstream project "main-random" build number 124
originally caused by:
Started by an SCM change
Running as SYSTEM
Building remotely on focal1 (oracle focal focal-pr) in workspace
/home/jenkins/workspace/main-
random/database/spatialite/label/focal/python/python3.11
The recommended git tool is: NONE
No credentials specified
Cloning the remote Git repository
Using shallow clone with depth 50
Avoid fetching tags
Honoring refspec on initial clone
Cloning repository https://github.com/django/django.git
> git init /home/jenkins/workspace/main-
random/database/spatialite/label/focal/python/python3.11 # timeout=10
Fetching upstream changes from https://github.com/django/django.git
> git --version # timeout=10
> git --version # 'git version 2.25.1'
> git fetch --no-tags --force --progress --depth=50 --
https://github.com/django/django.git
+refs/heads/main:refs/remotes/origin/main # timeout=10
> git config remote.origin.url https://github.com/django/django.git #
timeout=10
> git config --add remote.origin.fetch
+refs/heads/main:refs/remotes/origin/main # timeout=10
Avoid second fetch
Checking out Revision f7389c4b07ceeb036436e065898e411b247bca78
(origin/main)
> git config core.sparsecheckout # timeout=10
> git checkout -f f7389c4b07ceeb036436e065898e411b247bca78 # timeout=10
Commit message: "Fixed #34457 -- Restored output for makemigrations
--check."
> git rev-list --no-walk 797957fb48f63760442d3d4c8985fd94f8602d5e #
timeout=10
[python3.11] $ /bin/sh -xe /tmp/jenkins9896387767571950455.sh
+ export EXTRA_RUNTESTS_ARGS=--shuffle
+ git clean -fqdx
+ cd tests
+ cp -r /home/jenkins/djangodata/apt-pin
/home/jenkins/djangodata/oracle19.env
/home/jenkins/djangodata/oragis19.env
/home/jenkins/djangodata/runtests_jenkins.sh
/home/jenkins/djangodata/test_mysql.py
/home/jenkins/djangodata/test_mysql_gis.py
/home/jenkins/djangodata/test_oracle19.py
/home/jenkins/djangodata/test_oracle19_host.py
/home/jenkins/djangodata/test_oragis19.py
/home/jenkins/djangodata/test_postgis.py
/home/jenkins/djangodata/test_postgres.py
/home/jenkins/djangodata/test_spatialite.py
/home/jenkins/djangodata/test_sqlite3.py .
+ sh runtests_jenkins.sh
...
Using shuffle seed: 5354051979 (generated)
Creating test database for alias 'default'
('file:memorydb_default?mode=memory&cache=shared')...
Found 17253 test(s).
...
test_lazy (messages_tests.tests.TestLevelTags.test_lazy) ... FAIL
(0.002s)
...
======================================================================
FAIL [0.002s]: test_lazy (messages_tests.tests.TestLevelTags.test_lazy)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/jenkins/workspace/main-
random/database/spatialite/label/focal/python/python3.11/tests/messages_tests/tests.py",
line 73, in test_lazy
self.assertEqual(base.LEVEL_TAGS[constants.ERROR], "bad")
AssertionError: 'error' != 'bad'
- error
+ bad
----------------------------------------------------------------------
Ran 17251 tests in 1406.234s
FAILED (failures=1, skipped=1139, expected failures=5)
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34958#comment:4>
Django
Reporter: bcail | Owner: Natalia
| Bidart
Type: Bug | Status: assigned
Component: contrib.messages | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Natalia Bidart):
* owner: nobody => Natalia Bidart
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/34958#comment:5>
Django
Reporter: bcail | Owner: Natalia Bidart
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* component: contrib.messages => Core (Other)
--
Ticket URL: <https://code.djangoproject.com/ticket/34958#comment:6>
Django
------------------------------+------------------------------------------
Reporter: bcail | Owner: Natalia Bidart
Type: Bug | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+------------------------------------------
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/17462 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/34958#comment:7>
Django
Reporter: bcail | Owner: Natalia
| Bidart
Type: Bug | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Jacob Walls):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/34958#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: bcail | Owner: Natalia
| Bidart
Component: Core (Other) | Version: dev
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"1b56b24f81a2e64b4bd3059abad9b6fd0c801c66" 1b56b24]:
{{{
#!CommitTicketReference repository=""
revision="1b56b24f81a2e64b4bd3059abad9b6fd0c801c66"
Fixed #34958 -- Fixed isolation of
messages_tests.tests.TestLevelTags.test_lazy.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34958#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: bcail | Owner: Natalia
| Bidart
Type: Bug | Status: closed
Component: Core (Other) | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"7a21ea5464b61a8fcd43cd1b9b5f99c94687600a" 7a21ea5]:
{{{
#!CommitTicketReference repository=""
revision="7a21ea5464b61a8fcd43cd1b9b5f99c94687600a"
[5.0.x] Fixed #34958 -- Fixed isolation of
messages_tests.tests.TestLevelTags.test_lazy.
Backport of 1b56b24f81a2e64b4bd3059abad9b6fd0c801c66 from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34958#comment:10>