Re: [Django] #34830: csrf_failure and bad_request views missing context processors

12 views
Skip to first unread message

Django

unread,
Nov 8, 2023, 7:44:53 AM11/8/23
to django-...@googlegroups.com
#34830: csrf_failure and bad_request views missing context processors
-----------------------------+------------------------------------------
Reporter: Alex Henman | Owner: Natalia Bidart
Type: Bug | Status: closed
Component: CSRF | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------+------------------------------------------
Changes (by Natalia <124304+nessita@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"5f2f12f61c8e9bc0323efea391ee56e721ce14c6" 5f2f12f6]:
{{{
#!CommitTicketReference repository=""
revision="5f2f12f61c8e9bc0323efea391ee56e721ce14c6"
Reverted "Fixed #34830 -- Added request to csrf_failure view's template
context."

This reverts commit 535f7b5c6cea54a0796d85bbe213183d50002689.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34830#comment:20>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Nov 8, 2023, 7:45:17 AM11/8/23
to django-...@googlegroups.com
#34830: csrf_failure and bad_request views missing context processors
-----------------------------+------------------------------------------
Reporter: Alex Henman | Owner: Natalia Bidart
Type: Bug | Status: new

Component: CSRF | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------+------------------------------------------
Changes (by Natalia Bidart):

* status: closed => new
* resolution: fixed =>


--
Ticket URL: <https://code.djangoproject.com/ticket/34830#comment:21>

Django

unread,
Nov 8, 2023, 7:54:09 AM11/8/23
to django-...@googlegroups.com
#34830: csrf_failure and bad_request views missing context processors
------------------------------+------------------------------------
Reporter: Alex Henman | Owner: (none)
Type: Bug | Status: assigned
Component: Core (Other) | Version: dev

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
------------------------------+------------------------------------
Changes (by Natalia Bidart):

* owner: Natalia Bidart => (none)
* status: new => assigned
* component: CSRF => Core (Other)
* easy: 0 => 1


Comment:

De-assigning myself in case someone else can grab this before I get to it.
The commentary explains in details what should be done to properly solve
the ticket.

--
Ticket URL: <https://code.djangoproject.com/ticket/34830#comment:22>

Django

unread,
Nov 8, 2023, 7:54:34 AM11/8/23
to django-...@googlegroups.com
#34830: csrf_failure and bad_request views missing context processors
------------------------------+------------------------------------
Reporter: Alex Henman | Owner: (none)
Type: Bug | Status: new

Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
------------------------------+------------------------------------
Changes (by Natalia Bidart):

* status: assigned => new


--
Ticket URL: <https://code.djangoproject.com/ticket/34830#comment:23>

Django

unread,
Nov 8, 2023, 8:06:10 AM11/8/23
to django-...@googlegroups.com
#34830: csrf_failure and bad_request views missing context processors
------------------------------+------------------------------------
Reporter: Alex Henman | Owner: yushan
Type: Bug | Status: assigned

Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
------------------------------+------------------------------------
Changes (by yushan):

* owner: (none) => yushan


* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/34830#comment:24>

Django

unread,
Nov 11, 2023, 5:34:35 AM11/11/23
to django-...@googlegroups.com
#34830: csrf_failure and bad_request views missing context processors
------------------------------+------------------------------------
Reporter: Alex Henman | Owner: yushan
Type: Bug | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
------------------------------+------------------------------------
Changes (by yushan):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/17465 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/34830#comment:25>

Django

unread,
Nov 29, 2023, 4:05:59 AM11/29/23
to django-...@googlegroups.com
#34830: csrf_failure and bad_request views missing context processors
------------------------------+------------------------------------
Reporter: Alex Henman | Owner: yushan
Type: Bug | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 0
------------------------------+------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1
* needs_tests: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/34830#comment:26>

Django

unread,
Dec 4, 2023, 4:56:29 AM12/4/23
to django-...@googlegroups.com
#34830: csrf_failure and bad_request views missing context processors
-------------------------------------+-------------------------------------

Reporter: Alex Henman | Owner: yushan
Type: Bug | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 1 => 0
* needs_tests: 1 => 0
* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/34830#comment:27>

Django

unread,
Dec 4, 2023, 5:41:52 AM12/4/23
to django-...@googlegroups.com
#34830: csrf_failure and bad_request views missing context processors
-------------------------------------+-------------------------------------
Reporter: Alex Henman | Owner: yushan
Type: Bug | Status: closed

Component: Core (Other) | Version: dev
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"14b0132e5e70854076ea781451f5ff37f8dc8edd" 14b0132]:
{{{
#!CommitTicketReference repository=""
revision="14b0132e5e70854076ea781451f5ff37f8dc8edd"
Fixed #34830 -- Added request to bad_request/csrf_failure view template
contexts.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34830#comment:28>

Reply all
Reply to author
Forward
0 new messages