Re: [Django] #34935: makemigrations --check no longer reports pending migrations

2 views
Skip to first unread message

Django

unread,
Oct 29, 2023, 9:16:51 PM10/29/23
to django-...@googlegroups.com
#34935: makemigrations --check no longer reports pending migrations
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Migrations | Version: 4.2
Severity: Normal | Resolution: duplicate
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jacob Walls):

* status: new => closed
* type: Bug => Cleanup/optimization
* resolution: => duplicate
* severity: Release blocker => Normal


Comment:

Hi Adam. This was proposed before in #34632 and wontfixed, but I'd be open
to reconsidering. #34051 did muse that other commands with `--check` do a
bit of logging, so it doesn't seem inconsistent to me to let
`makemigrations --check` log, too.

Would you be willing to sound this out on the forum?

(There was #34457, too, going further and arguing for a total reversion.)

--
Ticket URL: <https://code.djangoproject.com/ticket/34935#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 30, 2023, 5:42:17 AM10/30/23
to django-...@googlegroups.com
#34935: makemigrations --check no longer reports pending migrations
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Migrations | Version: 4.2
Severity: Normal | Resolution: duplicate
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Adam Johnson):

Thanks for pointing to the other ticket. Sorry I did not search for it.

I’ve just [https://forum.djangoproject.com/t/makemigrations-check-output-
regression-in-4-2/24894 posted on the forum].

--
Ticket URL: <https://code.djangoproject.com/ticket/34935#comment:4>

Reply all
Reply to author
Forward
0 new messages