[Django] #34934: Made EmailValidator.__eq__() ignore domain_allowlist ordering.

10 views
Skip to first unread message

Django

unread,
Oct 28, 2023, 2:12:46 AM10/28/23
to django-...@googlegroups.com
#34934: Made EmailValidator.__eq__() ignore domain_allowlist ordering.
------------------------------------------------+------------------------
Reporter: ksg | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: dev
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
Just like in the case mentioned here:
https://code.djangoproject.com/ticket/34920.
EmailValidator's eq() method also doesn't correctly handle the comparison
of domain_allowlist when the order of elements in the arrays is different.

{{{
self.assertEqual(
EmailValidator(allowlist=["127.0.0.1", "localhost"]),
EmailValidator(allowlist=["localhost", "127.0.0.1"]),
)
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34934>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 28, 2023, 2:26:55 AM10/28/23
to django-...@googlegroups.com
#34934: Made EmailValidator.__eq__() ignore domain_allowlist ordering.
-------------------------------------+-------------------------------------
Reporter: ksg | Owner: ksg
Type: | Status: assigned
Cleanup/optimization |

Component: Core (Other) | Version: dev
Severity: Normal | Resolution:

Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by ksg):

* owner: nobody => ksg
* status: new => assigned


Comment:

ㅖㄲ: https://github.com/django/django/pull/17420

--
Ticket URL: <https://code.djangoproject.com/ticket/34934#comment:1>

Django

unread,
Oct 28, 2023, 8:25:50 AM10/28/23
to django-...@googlegroups.com
#34934: Made EmailValidator.__eq__() ignore domain_allowlist ordering.
--------------------------------------+------------------------------------
Reporter: ksg | Owner: ksg
Type: Cleanup/optimization | Status: assigned

Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Mariusz Felisiak):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/34934#comment:2>

Django

unread,
Oct 28, 2023, 4:16:24 PM10/28/23
to django-...@googlegroups.com
#34934: Made EmailValidator.__eq__() ignore domain_allowlist ordering.
--------------------------------------+------------------------------------
Reporter: ksg | Owner: ksg
Type: Cleanup/optimization | Status: closed

Component: Core (Other) | Version: dev
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Mariusz Felisiak):

* status: assigned => closed
* resolution: => fixed


Comment:

Fixed in a6c7db1d1d77e34600cec5c5044f4e90ed16691f.

--
Ticket URL: <https://code.djangoproject.com/ticket/34934#comment:3>

Reply all
Reply to author
Forward
0 new messages