[Django] #34932: Setting deterministic Postgres collations incorrectly disallows use of varchar_pattern_ops and text_pattern_ops

27 views
Skip to first unread message

Django

unread,
Oct 27, 2023, 5:16:07 AM10/27/23
to django-...@googlegroups.com
#34932: Setting deterministic Postgres collations incorrectly disallows use of
varchar_pattern_ops and text_pattern_ops
---------------------------------------+--------------------------
Reporter: Tom Carrick | Owner: nobody
Type: Bug | Status: assigned
Component: Migrations | Version: 4.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
---------------------------------------+--------------------------


--
Ticket URL: <https://code.djangoproject.com/ticket/34932>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 27, 2023, 5:16:31 AM10/27/23
to django-...@googlegroups.com
#34932: Setting deterministic Postgres collations incorrectly disallows use of
varchar_pattern_ops and text_pattern_ops
-----------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick

Type: Bug | Status: assigned
Component: Migrations | Version: 4.2
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------+---------------------------------------
Changes (by Tom Carrick):

* owner: nobody => Tom Carrick


--
Ticket URL: <https://code.djangoproject.com/ticket/34932#comment:1>

Django

unread,
Oct 27, 2023, 5:42:45 AM10/27/23
to django-...@googlegroups.com
#34932: Setting deterministic Postgres collations incorrectly disallows use of
varchar_pattern_ops and text_pattern_ops
---------------------------------+---------------------------------------

Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: Migrations | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+---------------------------------------
Changes (by Mariusz Felisiak):

* severity: Normal => Release blocker
* stage: Unreviewed => Accepted


Comment:

Thanks for the report. We should be able to skipped
`varchar_pattern_ops/text_pattern_ops` index creation only for non-
deterministic collations by introspecting
`pg_collation.collisdeterministic`.

Regression in f3f9d03edf17ccfa17263c7efa0b1350d1ac9278 (4.2) and
8ed25d65ea7546fafd808086fa07e7e5bb5428fc (5.0).

--
Ticket URL: <https://code.djangoproject.com/ticket/34932#comment:2>

Django

unread,
Oct 27, 2023, 10:08:19 AM10/27/23
to django-...@googlegroups.com
#34932: Setting deterministic Postgres collations incorrectly disallows use of
varchar_pattern_ops and text_pattern_ops
---------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: Migrations | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+---------------------------------------
Changes (by Tom Carrick):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/17415 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/34932#comment:3>

Django

unread,
Oct 30, 2023, 2:38:29 AM10/30/23
to django-...@googlegroups.com
#34932: Setting deterministic Postgres collations incorrectly disallows use of
varchar_pattern_ops and text_pattern_ops
-------------------------------------+-------------------------------------

Reporter: Tom Carrick | Owner: Tom
| Carrick
Type: Bug | Status: assigned
Component: Migrations | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/34932#comment:4>

Django

unread,
Oct 30, 2023, 6:08:01 AM10/30/23
to django-...@googlegroups.com
#34932: Setting deterministic Postgres collations incorrectly disallows use of
varchar_pattern_ops and text_pattern_ops
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
| Carrick
Type: Bug | Status: closed
Component: Migrations | Version: 4.2
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"34b411762b50883d768d7b67e0a158ec39da8b09" 34b41176]:
{{{
#!CommitTicketReference repository=""
revision="34b411762b50883d768d7b67e0a158ec39da8b09"
Fixed #34932 -- Restored varchar_pattern_ops/text_pattern_ops index
creation when deterministic collaction is set.

Regression in f3f9d03edf17ccfa17263c7efa0b1350d1ac9278 (4.2) and
8ed25d65ea7546fafd808086fa07e7e5bb5428fc (5.0).
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34932#comment:5>

Django

unread,
Oct 30, 2023, 6:11:47 AM10/30/23
to django-...@googlegroups.com
#34932: Setting deterministic Postgres collations incorrectly disallows use of
varchar_pattern_ops and text_pattern_ops
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
| Carrick
Type: Bug | Status: closed
Component: Migrations | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"602835202d976ce2f4a28904ad0f43af866326f1" 6028352]:
{{{
#!CommitTicketReference repository=""
revision="602835202d976ce2f4a28904ad0f43af866326f1"
[5.0.x] Fixed #34932 -- Restored varchar_pattern_ops/text_pattern_ops


index creation when deterministic collaction is set.

Regression in f3f9d03edf17ccfa17263c7efa0b1350d1ac9278 (4.2) and
8ed25d65ea7546fafd808086fa07e7e5bb5428fc (5.0).

Backport of 34b411762b50883d768d7b67e0a158ec39da8b09 from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34932#comment:6>

Django

unread,
Oct 30, 2023, 6:17:26 AM10/30/23
to django-...@googlegroups.com
#34932: Setting deterministic Postgres collations incorrectly disallows use of
varchar_pattern_ops and text_pattern_ops
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
| Carrick
Type: Bug | Status: closed
Component: Migrations | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"109f39a38bf62e350171d8e342788160af95d21a" 109f39a3]:
{{{
#!CommitTicketReference repository=""
revision="109f39a38bf62e350171d8e342788160af95d21a"
[4.2.x] Fixed #34932 -- Restored varchar_pattern_ops/text_pattern_ops


index creation when deterministic collaction is set.

Regression in f3f9d03edf17ccfa17263c7efa0b1350d1ac9278 (4.2) and
8ed25d65ea7546fafd808086fa07e7e5bb5428fc (5.0).

Backport of 34b411762b50883d768d7b67e0a158ec39da8b09 from main.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34932#comment:7>

Reply all
Reply to author
Forward
0 new messages