[Django] #34927: ModelAdmin for model with InlineModelAdmin for proxy class reference results in admin.E202
Django
results in admin.E202
-------------------------------------+-------------------------------------
Reporter: | Owner: nobody
ColonelPhantom |
Type: Bug | Status: new
Component: | Version: 4.2
Uncategorized | Keywords: proxy,
Severity: Normal | InlineModelAdmin, E202
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
This is similar to #30273 and #32975. A class references a proxy model,
and we define an inline for the proxied model. This fails with admin.E202
because Django does not recognize that the FK to the proxy model is the
same as an FK to the proxied model.
Assume models as follows:
{{{
class Reporter(models.Model):
name = models.CharField(max_length=50)
class Journalist(Reporter):
class Meta:
proxy = True
class Article(models.Model):
reporter = models.ForeignKey(Journalist, on_delete=models.CASCADE)
}}}
and an admin as follows:
{{{
class ArticleInline(admin.TabularInline):
model = Article
fk_name = 'reporter'
@admin.register(Reporter)
class ReporterAdmin(admin.ModelAdmin):
inlines = [ArticleInline]
}}}
This will result in {{{<class 'testapp.admin.ArticleInline'>: (admin.E202)
fk_name 'reporter' is not a ForeignKey to 'testapp.Reporter'.}}}
The problem seems to be that the parent list does not include the model
itself, and as such Django does not recognize the equality here.
--
Ticket URL: <https://code.djangoproject.com/ticket/34927>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
results in admin.E202
-------------------------------------+-------------------------------------
Type: Bug | Status: new
Component: Database layer | Version: 4.2
(models, ORM) |
Severity: Normal | Resolution:
Keywords: proxy, | Triage Stage:
InlineModelAdmin, E202 | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* component: Uncategorized => Database layer (models, ORM)
--
Ticket URL: <https://code.djangoproject.com/ticket/34927#comment:1>
Django
results in admin.E202
-------------------------------------+-------------------------------------
Reporter: Quinten Kock | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: 4.2
(models, ORM) |
Severity: Normal | Resolution:
Keywords: proxy, | Triage Stage:
InlineModelAdmin, E202 | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Asfand Yar Khan):
Was able to reproduce this on my end.
--
Ticket URL: <https://code.djangoproject.com/ticket/34927#comment:2>
Django
results in admin.E202
-------------------------------------+-------------------------------------
Reporter: Quinten Kock | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: 4.2
(models, ORM) |
Severity: Normal | Resolution:
InlineModelAdmin, E202 |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/34927#comment:3>
Django
results in admin.E202
-------------------------------------+-------------------------------------
Reporter: Quinten Kock | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: proxy, | Triage Stage: Accepted
InlineModelAdmin, E202 |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* component: Database layer (models, ORM) => contrib.admin
--
Ticket URL: <https://code.djangoproject.com/ticket/34927#comment:4>
Django
results in admin.E202
-------------------------------------+-------------------------------------
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: proxy, | Triage Stage: Accepted
InlineModelAdmin, E202 |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: nobody => chenow
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/34927#comment:5>
Django
results in admin.E202
-------------------------------------+-------------------------------------
Reporter: Quinten Kock | Owner: chenow
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: proxy, | Triage Stage: Accepted
InlineModelAdmin, E202 |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by chenow):
* has_patch: 0 => 1
Comment:
Made a PR here: https://github.com/django/django/pull/17434
--
Ticket URL: <https://code.djangoproject.com/ticket/34927#comment:6>
Django
results in admin.E202
-------------------------------------+-------------------------------------
Reporter: Quinten Kock | Owner: chenow
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: proxy, | Triage Stage: Accepted
InlineModelAdmin, E202 |
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/34927#comment:7>
Django
results in admin.E202
-------------------------------------+-------------------------------------
Reporter: Quinten Kock | Owner: chenow
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
InlineModelAdmin, E202 | checkin
Has patch: 1 | Needs documentation: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* needs_better_patch: 1 => 0
* needs_tests: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/34927#comment:8>
Django
results in admin.E202
-------------------------------------+-------------------------------------
Reporter: Quinten Kock | Owner: chenow
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution: fixed
Keywords: proxy, | Triage Stage: Ready for
InlineModelAdmin, E202 | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"65c283be163212f5679b5edbd6a24c88b3af04ce" 65c283b]:
{{{
#!CommitTicketReference repository=""
revision="65c283be163212f5679b5edbd6a24c88b3af04ce"
Fixed #34927 -- Fixed admin system check for inlines with foreign keys to
proxy models.
Follow up to 0e8be73812a6e62d5a6b12a585d133b56bc2bf52.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34927#comment:9>