Re: [Django] #34920: FileExtensionValidator.__eq__() should ignore allowed_extensions order.

[Django]

#34920: FileExtensionValidator.__eq__() should ignore allowed_extensions order.
------------------------------+------------------------------------
Reporter: ksg | Owner: ksg
Type: Bug | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
------------------------------+------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/34920#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#34920: FileExtensionValidator.__eq__() should ignore allowed_extensions order.
------------------------------+------------------------------------
Reporter: ksg | Owner: ksg
Type: Bug | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
------------------------------+------------------------------------

Comment (by ksg):

Replying to [comment:4 Tim Graham]:
> I'd think that validators that behave identically should be considered
equal. Did you run into a real-world bug with the current behavior?

No, it's just an enhancement to make eq work better!

--
Ticket URL: <https://code.djangoproject.com/ticket/34920#comment:7>

[Django]

#34920: FileExtensionValidator.__eq__() should ignore allowed_extensions order.
------------------------------+------------------------------------
Reporter: ksg | Owner: ksg
Type: Bug | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
------------------------------+------------------------------------

Changes (by ksg):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/34920#comment:8>

[Django]

#34920: FileExtensionValidator.__eq__() should ignore allowed_extensions order.

-------------------------------------+-------------------------------------

Reporter: ksg | Owner: ksg
Type: Bug | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/34920#comment:9>

[Django]

#34920: FileExtensionValidator.__eq__() should ignore allowed_extensions order.
-------------------------------------+-------------------------------------
Reporter: ksg | Owner: ksg

Type: Bug | Status: closed

Component: Core (Other) | Version: dev

Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"d22ba0763086f71fb6df8502162ea63944d166b1" d22ba076]:
{{{
#!CommitTicketReference repository=""
revision="d22ba0763086f71fb6df8502162ea63944d166b1"
Fixed #34920 -- Made FileExtensionValidator.__eq__() ignore
allowed_extensions ordering.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34920#comment:10>