[Django] #34912: Admindocs back-links and bookmarklet help text is too small

0 views
Skip to first unread message

Django

unread,
Oct 19, 2023, 3:35:47 PM10/19/23
to django-...@googlegroups.com
#34912: Admindocs back-links and bookmarklet help text is too small
-------------------------------------+-------------------------------------
Reporter: Thibaud | Owner: nobody
Colas |
Type: Bug | Status: new
Component: | Version: dev
contrib.admindocs | Keywords: accessibility, font
Severity: Normal | size
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
-------------------------------------+-------------------------------------
We use the `.small` class in admindocs for "Back to parent page" links at
the bottom of three documentation pages: models, views, templates. This
makes the text too small to be readable, which doesn’t achieve much as the
text is at the bottom of the page anyway.

Example: [https://static-django-
demo.netlify.app/django_admin_tests/v5.0/english/admin/docs/models/demo.track
Track Model documentation]

We also use `.help` text on the Documentation Bookmarklet docs, and could
equally stop because it makes text too small.

---

Let’s remove those three uses of the `.small` class and the use of `.help`
and make the text more readable.

--
Ticket URL: <https://code.djangoproject.com/ticket/34912>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 19, 2023, 3:39:52 PM10/19/23
to django-...@googlegroups.com
#34912: Admindocs back-links and bookmarklet help text is too small
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Chris
| Frisina
Type: Bug | Status: assigned
Component: contrib.admindocs | Version: dev
Severity: Normal | Resolution:
Keywords: accessibility, font | Triage Stage:
size | Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Thibaud Colas):

* owner: nobody => Chris Frisina
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/34912#comment:1>

Django

unread,
Oct 19, 2023, 3:46:10 PM10/19/23
to django-...@googlegroups.com
#34912: Admindocs back-links and bookmarklet help text is too small
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Chris
| Frisina
Type: Bug | Status: assigned
Component: contrib.admindocs | Version: dev
Severity: Normal | Resolution:
Keywords: accessibility, font | Triage Stage: Accepted
size |

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* stage: Unreviewed => Accepted


Comment:

Accepting following conversations with Thibaud in the Django sprint at
Durham.

--
Ticket URL: <https://code.djangoproject.com/ticket/34912#comment:2>

Django

unread,
Oct 20, 2023, 2:40:15 AM10/20/23
to django-...@googlegroups.com
#34912: Admindocs back-links and bookmarklet help text is too small
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Chris
| Frisina
Type: Bug | Status: assigned
Component: contrib.admindocs | Version: dev
Severity: Normal | Resolution:
Keywords: accessibility, font | Triage Stage: Accepted
size |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/34912#comment:3>

Django

unread,
Oct 21, 2023, 2:23:20 AM10/21/23
to django-...@googlegroups.com
#34912: Admindocs back-links and bookmarklet help text is too small
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Chris
| Frisina
Type: Bug | Status: assigned
Component: contrib.admindocs | Version: dev
Severity: Normal | Resolution:
Keywords: accessibility, font | Triage Stage: Ready for
size | checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/34912#comment:4>

Django

unread,
Oct 21, 2023, 3:01:59 AM10/21/23
to django-...@googlegroups.com
#34912: Admindocs back-links and bookmarklet help text is too small
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Chris
| Frisina
Type: Bug | Status: closed
Component: contrib.admindocs | Version: dev
Severity: Normal | Resolution: fixed

Keywords: accessibility, font | Triage Stage: Ready for
size | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"be8b25def45bda2e9d1b63e67a80362832bcf45d" be8b25d]:
{{{
#!CommitTicketReference repository=""
revision="be8b25def45bda2e9d1b63e67a80362832bcf45d"
Fixed #34912 -- Fixed size of back links and bookmarklet help in admindocs
pages.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34912#comment:5>

Django

unread,
Oct 21, 2023, 3:02:16 AM10/21/23
to django-...@googlegroups.com
#34912: Admindocs back-links and bookmarklet help text is too small
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Chris
| Frisina
Type: Bug | Status: closed
Component: contrib.admindocs | Version: dev
Severity: Normal | Resolution: fixed
Keywords: accessibility, font | Triage Stage: Ready for
size | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"26dddf3752000c2c679394c6f5084a9510b7d596" 26dddf37]:
{{{
#!CommitTicketReference repository=""
revision="26dddf3752000c2c679394c6f5084a9510b7d596"
[5.0.x] Fixed #34912 -- Fixed size of back links and bookmarklet help in
admindocs pages.

Backport of be8b25def45bda2e9d1b63e67a80362832bcf45d from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34912#comment:6>

Reply all
Reply to author
Forward
0 new messages