[Django] #34905: Main landmark is on the wrong element

[Django]

#34905: Main landmark is on the wrong element
-----------------------------------------+-------------------------------
Reporter: Tom Carrick | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Keywords: accessibility
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+-------------------------------
It's currently wrapping the navbar, but it should be inside. Main element
should not have repeated content such as navigation that appears on
multiple pages.

--
Ticket URL: <https://code.djangoproject.com/ticket/34905>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#34905: Main landmark is on the wrong element

---------------------------------+------------------------------------

Reporter: Tom Carrick | Owner: nobody
Type: Bug | Status: new

Component: contrib.admin | Version: 5.0
Severity: Release blocker | Resolution:
Keywords: accessibility | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by Mariusz Felisiak):

* cc: Sarah Abderemane, Thibaud Colas (added)
* version: dev => 5.0
* severity: Normal => Release blocker
* easy: 0 => 1
* stage: Unreviewed => Accepted

Comment:

Thanks for the report! Regression in
91e617c743b21a0ebad01f18623a8b31f6f58500. We should change the `#content-
start` `div` to the `main` landmark instead of `#main`.

--
Ticket URL: <https://code.djangoproject.com/ticket/34905#comment:1>

[Django]

#34905: Main landmark is on the wrong element
---------------------------------+------------------------------------

Reporter: Tom Carrick | Owner: ontowhee
Type: Bug | Status: assigned

Component: contrib.admin | Version: 5.0
Severity: Release blocker | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
---------------------------------+------------------------------------

Changes (by ontowhee):

* owner: nobody => ontowhee
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/34905#comment:2>

[Django]

#34905: Main landmark is on the wrong element
---------------------------------+------------------------------------
Reporter: Tom Carrick | Owner: ontowhee
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Release blocker | Resolution:
Keywords: accessibility | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by ontowhee):

* has_patch: 0 => 1

Comment:

[https://github.com/django/django/pull/17382 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/34905#comment:3>

[Django]

#34905: Main landmark is on the wrong element

-------------------------------------+-------------------------------------

Reporter: Tom Carrick | Owner: ontowhee
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Release blocker | Resolution:

Keywords: accessibility | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/34905#comment:4>

[Django]

#34905: Main landmark is on the wrong element
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: ontowhee

Type: Bug | Status: closed
Component: contrib.admin | Version: 5.0
Severity: Release blocker | Resolution: fixed

Keywords: accessibility | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"89d2ae257bfdbe6f32c4671d97bf572623992ace" 89d2ae2]:
{{{
#!CommitTicketReference repository=""
revision="89d2ae257bfdbe6f32c4671d97bf572623992ace"
Fixed #34905 -- Corrected admin's main content element rendered in <main>
tag.

Regression in 91e617c743b21a0ebad01f18623a8b31f6f58500.

Thanks Tom Carrick for the report.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34905#comment:5>

[Django]

#34905: Main landmark is on the wrong element
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: ontowhee
Type: Bug | Status: closed
Component: contrib.admin | Version: 5.0
Severity: Release blocker | Resolution: fixed
Keywords: accessibility | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"31bdf67a9c443c9acfee8eba53e8f7a3f379241f" 31bdf67a]:
{{{
#!CommitTicketReference repository=""
revision="31bdf67a9c443c9acfee8eba53e8f7a3f379241f"
[5.0.x] Fixed #34905 -- Corrected admin's main content element rendered in
<main> tag.

Regression in 91e617c743b21a0ebad01f18623a8b31f6f58500.

Thanks Tom Carrick for the report.

Backport of 89d2ae257bfdbe6f32c4671d97bf572623992ace from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34905#comment:6>