Re: [Django] #34798: Subquery wrapping is required in QuerySet.aggregate() for aggregates referencing nested subquery.

[Django]

#34798: Subquery wrapping is required in QuerySet.aggregate() for aggregates
referencing nested subquery.
-------------------------------------+-------------------------------------
Reporter: Haldun Komsuoglu | Owner: Simon
| Charette
Type: Bug | Status: assigned
Component: Database layer | Version: 4.2
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: MSSQL, Aggregation, | Triage Stage: Accepted
Subquery |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Simon Charette):

* owner: nobody => Simon Charette
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/34798#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#34798: Subquery wrapping is required in QuerySet.aggregate() for aggregates
referencing nested subquery.
-------------------------------------+-------------------------------------
Reporter: Haldun Komsuoglu | Owner: Simon
| Charette
Type: Bug | Status: assigned
Component: Database layer | Version: 4.2
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: MSSQL, Aggregation, | Triage Stage: Accepted
Subquery |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Simon Charette):

* has_patch: 0 => 1

Comment:

Submitted a MR without release notes as I wasn't sure if we wanted to
backport to 4.2. I assume so?

--
Ticket URL: <https://code.djangoproject.com/ticket/34798#comment:7>

[Django]

#34798: Subquery wrapping is required in QuerySet.aggregate() for aggregates
referencing nested subquery.
-------------------------------------+-------------------------------------
Reporter: Haldun Komsuoglu | Owner: Simon
| Charette
Type: Bug | Status: assigned
Component: Database layer | Version: 4.2
(models, ORM) |
Severity: Release blocker | Resolution:

Keywords: MSSQL, Aggregation, | Triage Stage: Ready for
Subquery | checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin

Comment:

Replying to [comment:7 Simon Charette]:

> Submitted a MR without release notes as I wasn't sure if we wanted to
backport to 4.2. I assume so?

Yes, I added release notes.

--
Ticket URL: <https://code.djangoproject.com/ticket/34798#comment:8>

[Django]

#34798: Subquery wrapping is required in QuerySet.aggregate() for aggregates
referencing nested subquery.
-------------------------------------+-------------------------------------
Reporter: Haldun Komsuoglu | Owner: Simon
| Charette

Type: Bug | Status: closed

Component: Database layer | Version: 4.2
(models, ORM) |

Severity: Release blocker | Resolution: fixed

Keywords: MSSQL, Aggregation, | Triage Stage: Ready for
Subquery | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"3b4a571275d967512866012955eb0b3ae486d63c" 3b4a5712]:
{{{
#!CommitTicketReference repository=""
revision="3b4a571275d967512866012955eb0b3ae486d63c"
Fixed #34798 -- Fixed QuerySet.aggregate() crash when referencing
expressions containing subqueries.

Regression in 59bea9efd2768102fc9d3aedda469502c218e9b7,
complements e5c844d6f2a4ac6ae674d741b5f1fa2a688cedf4.

Refs #28477, #34551.

Thanks Haldun Komsuoglu for the report.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34798#comment:9>

[Django]

#34798: Subquery wrapping is required in QuerySet.aggregate() for aggregates
referencing nested subquery.
-------------------------------------+-------------------------------------
Reporter: Haldun Komsuoglu | Owner: Simon
| Charette
Type: Bug | Status: closed
Component: Database layer | Version: 4.2
(models, ORM) |
Severity: Release blocker | Resolution: fixed
Keywords: MSSQL, Aggregation, | Triage Stage: Ready for
Subquery | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"4ccca9eedc2f453602a20f562399a835a24817c1" 4ccca9ee]:
{{{
#!CommitTicketReference repository=""
revision="4ccca9eedc2f453602a20f562399a835a24817c1"
[5.0.x] Fixed #34798 -- Fixed QuerySet.aggregate() crash when referencing
expressions containing subqueries.

Regression in 59bea9efd2768102fc9d3aedda469502c218e9b7,
complements e5c844d6f2a4ac6ae674d741b5f1fa2a688cedf4.

Refs #28477, #34551.

Thanks Haldun Komsuoglu for the report.

Backport of 3b4a571275d967512866012955eb0b3ae486d63c from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34798#comment:10>

[Django]

#34798: Subquery wrapping is required in QuerySet.aggregate() for aggregates
referencing nested subquery.
-------------------------------------+-------------------------------------
Reporter: Haldun Komsuoglu | Owner: Simon
| Charette
Type: Bug | Status: closed
Component: Database layer | Version: 4.2
(models, ORM) |
Severity: Release blocker | Resolution: fixed
Keywords: MSSQL, Aggregation, | Triage Stage: Ready for
Subquery | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"803caec60bed3b282b9f9961860a467160c0c8f1" 803caec]:
{{{
#!CommitTicketReference repository=""
revision="803caec60bed3b282b9f9961860a467160c0c8f1"
[4.2.x] Fixed #34798 -- Fixed QuerySet.aggregate() crash when referencing
expressions containing subqueries.

Regression in 59bea9efd2768102fc9d3aedda469502c218e9b7,
complements e5c844d6f2a4ac6ae674d741b5f1fa2a688cedf4.

Refs #28477, #34551.

Thanks Haldun Komsuoglu for the report.

Backport of 3b4a571275d967512866012955eb0b3ae486d63c from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34798#comment:11>