Re: [Django] #12241: Admin forgets URL used for prefilling forms when hitting Save and add another
Django
another
-------------------------------+------------------------------------
Reporter: velmont | Owner: batiste
Type: Bug | Status: new
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by michelts):
* cc: michelts@… (added)
* ui_ux: => 0
* easy: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/12241#comment:29>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
another
Reporter: Odin Hørthe Omdal | Owner: matthewn
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by matthewn):
* owner: Batiste Bieler => matthewn
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/12241#comment:30>
Django
another
-----------------------------------+------------------------------------
Reporter: Odin Hørthe Omdal | Owner: matthewn
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
Changes (by matthewn):
* needs_better_patch: 1 => 0
Comment:
Greetings from DjangoCon US! First time contributor here with a pull
request for this: https://github.com/django/django/pull/16206
Note: Earlier discussion in this ticket considered altering the behavior
for 'save and continue' as well, but I am not sure that actually makes
sense from a use case perspective. My proposed fix is much more targeted,
addressing only the 'save and add another' issue mentioned in the ticket
title.
--
Ticket URL: <https://code.djangoproject.com/ticket/12241#comment:31>
Django
another
-----------------------------------+------------------------------------
Reporter: Odin Hørthe Omdal | Owner: matthewn
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/12241#comment:32>
Django
another
-----------------------------------+------------------------------------
Reporter: Odin Hørthe Omdal | Owner: matthewn
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
* needs_better_patch: 1 => 0
Comment:
As requested in the PR, I've expanded my fix to cover save-and-add and
save-and-continue on both add and change forms. Four tests cover the four
cases. https://github.com/django/django/pull/16206
--
Ticket URL: <https://code.djangoproject.com/ticket/12241#comment:33>
Django
another
-----------------------------------+------------------------------------
Reporter: Odin Hørthe Omdal | Owner: matthewn
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/12241#comment:34>
Django
another
-----------------------------------+------------------------------------
Reporter: Odin Hørthe Omdal | Owner: matthewn
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
Changes (by Mariusz Felisiak):
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/12241#comment:35>
Django
another
-----------------------------------+------------------------------------
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
* owner: matthewn => Mariana
--
Ticket URL: <https://code.djangoproject.com/ticket/12241#comment:36>
Django
another
-----------------------------------+------------------------------------
Reporter: Odin Hørthe Omdal | Owner: Mariana
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
-----------------------------------+------------------------------------
Changes (by Mariana):
* needs_better_patch: 1 => 0
* needs_tests: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/12241#comment:37>
Django
another
-----------------------------------+------------------------------------
Reporter: Odin Hørthe Omdal | Owner: Mariana
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
Comment (by Lily Foote):
The patch looks good to me, but would probably benefit from a review from
someone more familiar with the admin. There's also some code we think is
dead that we're not sure whether to delete as part of this ticket or as a
separate PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/12241#comment:38>
Django
another
-----------------------------------+------------------------------------
Reporter: Odin Hørthe Omdal | Owner: Mariana
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/12241#comment:39>
Django
another
-----------------------------------+------------------------------------
Reporter: Odin Hørthe Omdal | Owner: Mariana
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
* needs_tests: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/12241#comment:40>
Django
another
Reporter: Odin Hørthe Omdal | Owner: Mariana
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/12241#comment:41>
Django
another
-------------------------------------+-------------------------------------
Reporter: Odin Hørthe Omdal | Owner: Mariana
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"fc62e17778dad9eab9e507d90d85a33d415f64a7" fc62e177]:
{{{
#!CommitTicketReference repository=""
revision="fc62e17778dad9eab9e507d90d85a33d415f64a7"
Fixed #12241 -- Preserved query strings when using "Save and continue/add
another" in admin.
Co-authored-by: Grady Yu <gra...@users.noreply.github.com>
Co-authored-by: David Sanders <shang.xia...@gmail.com>
Co-authored-by: Matthew Newton <matt...@berkeley.edu>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/12241#comment:42>
Django
another
-------------------------------------+-------------------------------------
Reporter: Odin Hørthe Omdal | Owner: Mariana
Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"0bbe6ca2ac3d70e44081e54c235ff21568bf832c" 0bbe6ca2]:
{{{
#!CommitTicketReference repository=""
revision="0bbe6ca2ac3d70e44081e54c235ff21568bf832c"
[5.0.x] Fixed #12241 -- Preserved query strings when using "Save and
continue/add another" in admin.
Co-authored-by: Grady Yu <gra...@users.noreply.github.com>
Co-authored-by: David Sanders <shang.xia...@gmail.com>
Co-authored-by: Matthew Newton <matt...@berkeley.edu>
Backport of fc62e17778dad9eab9e507d90d85a33d415f64a7 from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/12241#comment:43>
Django
another
-------------------------------------+-------------------------------------
Reporter: Odin Hørthe Omdal | Owner: Mariana
Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by odinho):
This app I was working on when filing this bug 14 years ago is not used
anymore. But I have a more recent one made 12 years ago which is still in
production and could benefit from this in the next release. ;)
Thank you all! :)))
--
Ticket URL: <https://code.djangoproject.com/ticket/12241#comment:44>