[Django] #34759: Confirm/Add support for SpatiaLite 5.1
Django
------------------------------------------+------------------------
Reporter: Olivier Tabone | Owner: nobody
Type: Uncategorized | Status: new
Component: GIS | Version: dev
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------+------------------------
SpatiaLite [https://groups.google.com/g/spatialite-users/c/hAJ2SgitN4M is
preparing to release 5.1].
This ticket would fix broken test cases and update the documentation about
this new version.
with 5.1.0 RC1:
- `FAIL: test_asgml
(gis_tests.geoapp.test_functions.GISFunctionsTests.test_asgml)`
--
Ticket URL: <https://code.djangoproject.com/ticket/34759>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Olivier Tabone | Owner: nobody
Component: GIS | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* type: Uncategorized => Cleanup/optimization
* stage: Unreviewed => Accepted
Comment:
Tentatively accepted, hopefully there will be nothing to fix for the final
5.1 release.
--
Ticket URL: <https://code.djangoproject.com/ticket/34759#comment:1>
Django
Reporter: Olivier Tabone | Owner: Aman Gora
Type: | Status: assigned
Cleanup/optimization |
Component: GIS | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Aman Gora):
* owner: nobody => Aman Gora
* status: new => assigned
Comment:
I would like to take responsibility for resolving this ticket and
contributing to the Django project. I have reviewed the ticket description
and test_asgml function, and I believe I can effectively address the issue
or implement the requested feature in one or two weeks. I am a backend
developer for Django, and this seems to be first good issue to start with.
Regards,
Aman Gora
--
Ticket URL: <https://code.djangoproject.com/ticket/34759#comment:2>
Django
-------------------------------------+-------------------------------------
Type: | Tabone
Cleanup/optimization | Status: assigned
Component: GIS | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: AmanPython => Olivier Tabone
Comment:
Aman, thanks for picking this ticket, however, as far as I'm aware,
Olivier is already working on this.
--
Ticket URL: <https://code.djangoproject.com/ticket/34759#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Olivier Tabone | Owner:
Cleanup/optimization | Status: assigned
Component: GIS | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Olivier Tabone):
* owner: Olivier Tabone => AmanPython
* easy: 0 => 1
Comment:
Hi Aman, Mariusz,
I'm not working on it right now. I reported the issue and did not assign
it to myself. Aman can give a try on it.
- Regards
--
Ticket URL: <https://code.djangoproject.com/ticket/34759#comment:4>
Django
-------------------------------------+-------------------------------------
Type: | Status: assigned
Cleanup/optimization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Olivier Tabone):
Spatialite 5.1.0 is out :
- https://www.gaia-gis.it/fossil/libspatialite/index
- https://groups.google.com/g/spatialite-users/c/LjEKIv0rfrQ
still same test failure
--
Ticket URL: <https://code.djangoproject.com/ticket/34759#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Olivier Tabone | Owner: Aman Gora
Type: | Status: assigned
Cleanup/optimization |
Component: GIS | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* cc: Pieter Cardillo Kwok (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/34759#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Olivier Tabone | Owner: Aman Gora
Type: | Status: assigned
Cleanup/optimization |
Component: GIS | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Paolo Melchiorre):
If some of you want to test Spatialite 5.1 in a GNU/Linux system, it is
already available as a system package in
[https://packages.ubuntu.com/mantic/libsqlite3-mod-spatialite Ubuntu
23.10] (to be released in October) and
[https://packages.debian.org/trixie/libsqlite3-mod-spatialite Debian
Testing].
--
Ticket URL: <https://code.djangoproject.com/ticket/34759#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: Olivier Tabone | Owner: Aman Gora
Type: | Status: assigned
Cleanup/optimization |
Component: GIS | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Pieter Cardillo Kwok):
Hello, I'm currently investigating this ticket since there has been no
update in the past 8 weeks. I'm also trying to reach out to Aman Gora to
ask whether he's still working on this ticket or not. Is it okay for me to
assume ownership of the ticket if there is no response from Aman until
next week?
--
Ticket URL: <https://code.djangoproject.com/ticket/34759#comment:8>
Django
-------------------------------------+-------------------------------------
Type: | Cardillo Kwok
Cleanup/optimization | Status: assigned
Component: GIS | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: Aman Gora => Pieter Cardillo Kwok
--
Ticket URL: <https://code.djangoproject.com/ticket/34759#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: Olivier Tabone | Owner: Pieter
Type: | Cardillo Kwok
Cleanup/optimization | Status: assigned
Component: GIS | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Pieter Cardillo Kwok):
Hello guys I was able to replicate the error by updating spatialite to
5.1.0 and using django docker box. So I'd like to take ownership of the
ticket and start debugging the error. I'll provide some updates
periodically here and I'm also active in Django discord forum. Please feel
free to reach out through discord if needed (my discord name: @peter. tag:
,# 5816 ).
--
Ticket URL: <https://code.djangoproject.com/ticket/34759#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: Olivier Tabone | Owner: Pieter
Type: | Cardillo Kwok
Cleanup/optimization | Status: assigned
Component: GIS | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Pieter Cardillo Kwok):
Hello, I'd like to give update on the progress.
It's available in branch 'ticket_34759' on django repo in my GitHub
Profile:
https://github.com/PieterCK/django/tree/ticket_34759
and a mini documentation / note about the problem, solution, dev env and
setup here:
https://docs.google.com/document/d/1MKw2OnhmoWP4h00tCo85oziGBv1g747RxaBIaYwmctc/edit?usp=sharing
I've added a test case for `test_asgml` function. now there are 2 cases
for valid GML strings that the function may output. The reason for why the
new output is valid and can be found in the documentation above.
--
Ticket URL: <https://code.djangoproject.com/ticket/34759#comment:11>
Django
-------------------------------------+-------------------------------------
Reporter: Olivier Tabone | Owner: Pieter
Type: | Cardillo Kwok
Cleanup/optimization | Status: assigned
Component: GIS | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/34759#comment:12>
Django
-------------------------------------+-------------------------------------
Reporter: Olivier Tabone | Owner: Pieter
Type: | Cardillo Kwok
Cleanup/optimization | Status: assigned
Component: GIS | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_docs: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/34759#comment:13>
Django
-------------------------------------+-------------------------------------
Reporter: Olivier Tabone | Owner: Pieter
Type: | Cardillo Kwok
Cleanup/optimization | Status: assigned
Component: GIS | Version: dev
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* needs_docs: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/34759#comment:14>
Django
-------------------------------------+-------------------------------------
Reporter: Olivier Tabone | Owner: Pieter
Type: | Cardillo Kwok
Component: GIS | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"0989cf13e70f52d5b241aa176eb74a680a282d09" 0989cf1]:
{{{
#!CommitTicketReference repository=""
revision="0989cf13e70f52d5b241aa176eb74a680a282d09"
Fixed #34759 -- Confirmed support for SpatiaLite 5.1.
Thanks The Epic Dev for helping with tests.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34759#comment:15>
Django
-------------------------------------+-------------------------------------
Reporter: Olivier Tabone | Owner: Pieter
Type: | Cardillo Kwok
Cleanup/optimization | Status: closed
Component: GIS | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"72a2044b4062876895122d801bbfd65a0f59abb0" 72a2044]:
{{{
#!CommitTicketReference repository=""
revision="72a2044b4062876895122d801bbfd65a0f59abb0"
[5.0.x] Fixed #34759 -- Confirmed support for SpatiaLite 5.1.
Thanks The Epic Dev for helping with tests.
Backport of 0989cf13e70f52d5b241aa176eb74a680a282d09 from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34759#comment:16>
Django
-------------------------------------+-------------------------------------
Reporter: Olivier Tabone | Owner: Pieter
Type: | Cardillo Kwok
Cleanup/optimization | Status: closed
Component: GIS | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Claude Paroz):
Thanks!
--
Ticket URL: <https://code.djangoproject.com/ticket/34759#comment:17>