[Django] #34835: Use a `nav` element or `navigation` landmark for changelist filters
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud | Owner: nobody
Colas |
Type: | Status: new
Cleanup/optimization |
Component: | Version: 4.2
contrib.admin | Keywords: accessibility,
Severity: Normal | screen reader, landmarks
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
-------------------------------------+-------------------------------------
Related: [https://code.djangoproject.com/ticket/34832 #34832],
[https://code.djangoproject.com/ticket/34833 #34833],
[https://code.djangoproject.com/ticket/34834 #34834]. Changelist filters
are a very useful way to navigate long lists of entries. The filters would
be easier to reach for screen reader users if they were in a `navigation`
landmark done with a `<nav>` element or `role="navigation"` attribute.
Currently they are a `<div id="changelist-filter">`.
This element should be switched to a `<nav>`, and we should also add an
`aria-labelledby` set to the id of `<h2>Filter</h2>` element within, so
the navigation landmark has a distinct label.
--
Ticket URL: <https://code.djangoproject.com/ticket/34835>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage:
screen reader, landmarks | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Old description:
> Related: [https://code.djangoproject.com/ticket/34832 #34832],
> [https://code.djangoproject.com/ticket/34833 #34833],
> [https://code.djangoproject.com/ticket/34834 #34834]. Changelist filters
> are a very useful way to navigate long lists of entries. The filters
> would be easier to reach for screen reader users if they were in a
> `navigation` landmark done with a `<nav>` element or `role="navigation"`
> attribute. Currently they are a `<div id="changelist-filter">`.
>
> This element should be switched to a `<nav>`, and we should also add an
> `aria-labelledby` set to the id of `<h2>Filter</h2>` element within, so
> the navigation landmark has a distinct label.
New description:
Related: [https://code.djangoproject.com/ticket/34832 #34832],
[https://code.djangoproject.com/ticket/34833 #34833],
[https://code.djangoproject.com/ticket/34835 #34835]. Changelist filters
are a very useful way to navigate long lists of entries. The filters would
be easier to reach for screen reader users if they were in a `navigation`
landmark done with a `<nav>` element or `role="navigation"` attribute.
Currently they are a `<div id="changelist-filter">`.
This element should be switched to a `<nav>`, and we should also add an
`aria-labelledby` set to the id of `<h2>Filter</h2>` element within, so
the navigation landmark has a distinct label.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/34835#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage:
screen reader, landmarks | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Description changed by Thibaud Colas:
Old description:
> Related: [https://code.djangoproject.com/ticket/34832 #34832],
> [https://code.djangoproject.com/ticket/34833 #34833],
> [https://code.djangoproject.com/ticket/34835 #34835]. Changelist filters
> are a very useful way to navigate long lists of entries. The filters
> would be easier to reach for screen reader users if they were in a
> `navigation` landmark done with a `<nav>` element or `role="navigation"`
> attribute. Currently they are a `<div id="changelist-filter">`.
>
> This element should be switched to a `<nav>`, and we should also add an
> `aria-labelledby` set to the id of `<h2>Filter</h2>` element within, so
> the navigation landmark has a distinct label.
New description:
Related: [https://code.djangoproject.com/ticket/34832 #34832],
[https://code.djangoproject.com/ticket/34833 #34833],
[https://code.djangoproject.com/ticket/34834 #34834]. Changelist filters
are a very useful way to navigate long lists of entries. The filters would
be easier to reach for screen reader users if they were in a `navigation`
landmark done with a `<nav>` element or `role="navigation"` attribute.
Currently they are a `<div id="changelist-filter">`.
This element should be switched to a `<nav>`, and we should also add an
`aria-labelledby` set to the id of `<h2>Filter</h2>` element within, so
the navigation landmark has a distinct label.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/34835#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner:
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage:
screen reader, landmarks | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
* owner: nobody => faizan2700
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/34835#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner:
Type: | faizan2700
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
screen reader, landmarks |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* easy: 0 => 1
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/34835#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner:
Type: | faizan2700
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
screen reader, landmarks |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Lemuel Sta Ana):
Hi @faizan2700, are you still actively working on the ticket?
--
Ticket URL: <https://code.djangoproject.com/ticket/34835#comment:5>
Django
-------------------------------------+-------------------------------------
Type: | Sta Ana
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
screen reader, landmarks |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
* owner: faizan2700 => Lemuel Sta Ana
Comment:
Reassigning/claiming ticket after about two weeks of inactivity.
--
Ticket URL: <https://code.djangoproject.com/ticket/34835#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Lemuel
Type: | Sta Ana
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
screen reader, landmarks | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Lemuel Sta Ana):
* has_patch: 0 => 1
* stage: Accepted => Ready for checkin
Comment:
Hello. Please see below,
[https://github.com/django/django/pull/17309 PR]
Thanks,
Lem
--
Ticket URL: <https://code.djangoproject.com/ticket/34835#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Lemuel
Type: | Sta Ana
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Ready for
screen reader, landmarks | checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Lemuel Sta Ana):
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/34835#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Lemuel
Type: | Sta Ana
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
screen reader, landmarks |
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
* stage: Ready for checkin => Accepted
Comment:
Please don't mark your own patches as "Ready for checkin".
--
Ticket URL: <https://code.djangoproject.com/ticket/34835#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Lemuel
Type: | Sta Ana
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
screen reader, landmarks |
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Lemuel Sta Ana):
Oops, apologies @Mariusz. I enabled the wrong flag. Will be mindful next
time, thank you!
--
Ticket URL: <https://code.djangoproject.com/ticket/34835#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Lemuel
Type: | Sta Ana
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
screen reader, landmarks |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
* needs_docs: 0 => 1
* needs_tests: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/34835#comment:11>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Lemuel
Type: | Sta Ana
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
screen reader, landmarks | checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* needs_docs: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/34835#comment:12>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Lemuel
Type: | Sta Ana
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution: fixed
Keywords: accessibility, | Triage Stage: Ready for
screen reader, landmarks | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"357365a64e1c756eabaaf0ee0404df87c15c6e9b" 357365a]:
{{{
#!CommitTicketReference repository=""
revision="357365a64e1c756eabaaf0ee0404df87c15c6e9b"
Fixed #34835 -- Made admin's changelist filters render in <nav> tag.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34835#comment:13>