Re: [Django] #34846: Add "Copy" button to the code snippets in docs.

9 views
Skip to first unread message

Django

unread,
Sep 20, 2023, 4:21:55 PM9/20/23
to django-...@googlegroups.com
#34846: Add "Copy" button to the code snippets in docs.
-------------------------------------+-------------------------------------
Reporter: rushabhTt | Owner: Saarthak
Type: | Maini
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Saarthak Maini):

* owner: nobody => Saarthak Maini
* status: new => assigned
* has_patch: 0 => 1


Comment:

I have created a Pull Request for this ticket.

Pull Request : https://github.com/django/django/pull/17292

I referenced the pull request (
https://github.com/django/django/pull/16342/ ) mentioned above in the
discussion.

I tested it and found that it was only working for text which was starting
with "$ " and not covering text starting with "...\>".

So, I used the regex to resolve the issue and made the copy functionality
available for both Linux/MacOS Option and Windows Option

--
Ticket URL: <https://code.djangoproject.com/ticket/34846#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Sep 20, 2023, 5:19:51 PM9/20/23
to django-...@googlegroups.com
#34846: Add "Copy" button to the code snippets in docs.
-------------------------------------+-------------------------------------
Reporter: rushabhTt | Owner: Saarthak
Type: | Maini
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by David Sanders):

Yeah look I think we should give the original author a chance here instead
of just taking over what they did... I mean they're probably patiently
waiting for someone to review it. They haven't actually said that they
can't continue.

--
Ticket URL: <https://code.djangoproject.com/ticket/34846#comment:8>

Django

unread,
Sep 20, 2023, 11:54:29 PM9/20/23
to django-...@googlegroups.com
#34846: Add "Copy" button to the code snippets in docs.
-------------------------------------+-------------------------------------
Reporter: rushabhTt | Owner:
Type: | VenkataBhaskarr

Cleanup/optimization | Status: assigned
Component: Documentation | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* owner: Saarthak Maini => VenkataBhaskarr
* needs_better_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/34846#comment:9>

Django

unread,
Feb 20, 2024, 12:02:37 AM2/20/24
to django-...@googlegroups.com
#34846: Add "Copy" button to the code snippets in docs.
-------------------------------------+-------------------------------------
Reporter: rushabhTt | Owner: Mubeen F.
Type: | Status: assigned
Cleanup/optimization |
Component: Documentation | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mubeen F.):

* owner: VenkataBhaskarr => Mubeen F.

--
Ticket URL: <https://code.djangoproject.com/ticket/34846#comment:10>

Django

unread,
Jun 8, 2024, 9:20:21 AM6/8/24
to django-...@googlegroups.com
#34846: Add "Copy" button to the code snippets in docs.
-------------------------------------+-------------------------------------
Reporter: rushabhTt | Owner: Mubeen F.
Type: | Status: assigned
Cleanup/optimization |
Component: Documentation | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Arthur Vasconcelos):

* cc: Arthur Vasconcelos (added)
* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/34846#comment:11>

Django

unread,
Jun 17, 2024, 4:12:13 AM6/17/24
to django-...@googlegroups.com
#34846: Add "Copy" button to the code snippets in docs.
-------------------------------------+-------------------------------------
Reporter: rushabhTt | Owner: Mubeen F.
Type: | Status: assigned
Cleanup/optimization |
Component: Documentation | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

Comment:

Investigation is required as to whether this shouldn't be solved in
[https://github.com/django/djangoproject.com/blob/main/djangoproject/static/js/mod/clippify.js
djangoproject.com] as is the current approach
--
Ticket URL: <https://code.djangoproject.com/ticket/34846#comment:12>
Reply all
Reply to author
Forward
0 new messages