[Django] #33764: Deprecate make_random_password().

155 views
Skip to first unread message

Django

unread,
Jun 2, 2022, 5:04:35 AM6/2/22
to django-...@googlegroups.com
#33764: Deprecate make_random_password().
------------------------------------------------+------------------------
Reporter: Mariusz Felisiak | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.auth | Version: 4.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
------------------------------------------------+------------------------
It's unused since fcd837cd0f9b2c706bc49af509628778d442bb3f, see also
[https://code.djangoproject.com/ticket/33758?replyto=2#comment:2 Carlton's
comment].

--
Ticket URL: <https://code.djangoproject.com/ticket/33764>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jun 2, 2022, 5:09:06 AM6/2/22
to django-...@googlegroups.com
#33764: Deprecate make_random_password().
-------------------------------------+-------------------------------------

Reporter: Mariusz Felisiak | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.auth | Version: 4.0
Severity: Normal | Resolution:

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by David Wobrock):

* cc: David Wobrock (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/33764#comment:1>

Django

unread,
Jun 2, 2022, 6:12:27 AM6/2/22
to django-...@googlegroups.com
#33764: Deprecate make_random_password().
--------------------------------------+------------------------------------

Reporter: Mariusz Felisiak | Owner: nobody
Type: Cleanup/optimization | Status: new

Component: contrib.auth | Version: 4.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Carlton Gibson):

* stage: Unreviewed => Accepted


Old description:

> It's unused since fcd837cd0f9b2c706bc49af509628778d442bb3f, see also
> [https://code.djangoproject.com/ticket/33758?replyto=2#comment:2
> Carlton's comment].

New description:

It's unused since fcd837cd0f9b2c706bc49af509628778d442bb3f, see also

[https://code.djangoproject.com/ticket/33758?#comment:7 Carlton's
comment].

--

--
Ticket URL: <https://code.djangoproject.com/ticket/33764#comment:2>

Django

unread,
Jun 2, 2022, 6:31:49 AM6/2/22
to django-...@googlegroups.com
#33764: Deprecate make_random_password().
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Ciaran
Type: | McCormick
Cleanup/optimization | Status: assigned

Component: contrib.auth | Version: 4.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Ciaran McCormick):

* owner: nobody => Ciaran McCormick
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/33764#comment:3>

Django

unread,
Jun 2, 2022, 8:10:34 AM6/2/22
to django-...@googlegroups.com
#33764: Deprecate make_random_password().
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Ciaran
Type: | McCormick
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: 4.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Ciaran McCormick):

Hello all, I've opened a PR for this
https://github.com/django/django/pull/15751, this is my first contribution
so go easy on me :). Appreciate any feedback on the code change and also
on whether I've followed correct procedure. Thanks.

--
Ticket URL: <https://code.djangoproject.com/ticket/33764#comment:4>

Django

unread,
Jun 2, 2022, 8:13:08 AM6/2/22
to django-...@googlegroups.com
#33764: Deprecate make_random_password().
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Ciaran
Type: | McCormick
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: 4.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Ciaran McCormick):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/33764#comment:5>

Django

unread,
Jun 2, 2022, 11:13:12 AM6/2/22
to django-...@googlegroups.com
#33764: Deprecate make_random_password().
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Ciaran
Type: | McCormick
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: dev

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1
* version: 4.0 => dev


--
Ticket URL: <https://code.djangoproject.com/ticket/33764#comment:6>

Django

unread,
Jun 3, 2022, 1:32:53 AM6/3/22
to django-...@googlegroups.com
#33764: Deprecate make_random_password().
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Ciaran
Type: | McCormick
Cleanup/optimization | Status: assigned
Component: contrib.auth | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/33764#comment:7>

Django

unread,
Jun 3, 2022, 4:06:54 AM6/3/22
to django-...@googlegroups.com
#33764: Deprecate make_random_password().
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Ciaran
Type: | McCormick
Cleanup/optimization | Status: closed
Component: contrib.auth | Version: dev
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"286e7d076cfb7b4b0bdfc917de3020e6e89683f6" 286e7d07]:
{{{
#!CommitTicketReference repository=""
revision="286e7d076cfb7b4b0bdfc917de3020e6e89683f6"
Fixed #33764 -- Deprecated BaseUserManager.make_random_password().
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33764#comment:8>

Django

unread,
Sep 18, 2023, 4:12:52 PM9/18/23
to django-...@googlegroups.com
#33764: Deprecate make_random_password().
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Ciaran
Type: | McCormick
Cleanup/optimization | Status: closed
Component: contrib.auth | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"00e187961059a0e77403151d2bb38c217101d5af" 00e1879]:
{{{
#!CommitTicketReference repository=""
revision="00e187961059a0e77403151d2bb38c217101d5af"
Refs #33764 -- Removed BaseUserManager.make_random_password() per
deprecation timeline.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33764#comment:9>

Reply all
Reply to author
Forward
0 new messages