[Django] #34834: Use `search` role for the admin changelist search form
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud | Owner: nobody
Colas |
Type: | Status: new
Cleanup/optimization |
Component: | Version: 4.2
contrib.admin | Keywords: accessibility,
Severity: Normal | screen reader, landmarks
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Related: [https://code.djangoproject.com/ticket/34832 #34832],
[https://code.djangoproject.com/ticket/34833 #34833]. Django’s
ChangeListSearchForm and its
[https://github.com/django/django/blob/main/django/contrib/admin/templates/admin/search_form.html
search_form.html] currently use `<div id="toolbar"><form id="changelist-
search" method="get"></form></div>` markup for the form. It would be nice
for screen reader users to use a `role="search"` on the form, so it’s
explicitly identified as a search form when navigating the page by region.
In the future it would be even better to convert the wrapping toolbar div
to use the [https://developer.mozilla.org/en-
US/docs/Web/HTML/Element/search search] HTML element, but browser support
isn’t there yet.
--
Ticket URL: <https://code.djangoproject.com/ticket/34834>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage:
screen reader, landmarks | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by faizan2700):
Please assign me this ticket. I understand what needs to be done.
My Introduction:
I have graduated from IIIT Pune in 2021. I am doing freelancing since
college only, I have worked in ServiceNow and CleverTaps before currently
I am working on my startup.
--
Ticket URL: <https://code.djangoproject.com/ticket/34834#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
screen reader, landmarks |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* easy: 0 => 1
* stage: Unreviewed => Accepted
Comment:
faizan2700, you can assign yourself a ticket.
--
Ticket URL: <https://code.djangoproject.com/ticket/34834#comment:2>
Django
-------------------------------------+-------------------------------------
Type: | Sta Ana
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
screen reader, landmarks |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: nobody => Lemuel Sta Ana
* status: new => assigned
Comment:
Claiming ticket.
--
Ticket URL: <https://code.djangoproject.com/ticket/34834#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Lemuel
Type: | Sta Ana
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
screen reader, landmarks |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Lemuel Sta Ana):
* has_patch: 0 => 1
Comment:
**PR**[https://github.com/django/django/pull/17261]
--
Ticket URL: <https://code.djangoproject.com/ticket/34834#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Lemuel
Type: | Sta Ana
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
screen reader, landmarks |
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/34834#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Lemuel
Type: | Sta Ana
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
screen reader, landmarks |
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Lemuel Sta Ana):
Regression test added as per
[https://github.com/django/django/pull/17261/commits/393b524e0ddb974995cc1c3f5ab9851cf44f958d
commit]
--
Ticket URL: <https://code.djangoproject.com/ticket/34834#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Lemuel
Type: | Sta Ana
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
screen reader, landmarks | checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_tests: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/34834#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Lemuel
Type: | Sta Ana
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution: fixed
Keywords: accessibility, | Triage Stage: Ready for
screen reader, landmarks | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"969ecb8236f033d183108fb28849974da188da50" 969ecb82]:
{{{
#!CommitTicketReference repository=""
revision="969ecb8236f033d183108fb28849974da188da50"
Fixed #34834 -- Added role="search" to the admin changelist search form.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34834#comment:8>