[Django] #34739: Implement GEOSEqualsIdentical method on geometry objects.

1 view
Skip to first unread message

Django

unread,
Jul 25, 2023, 11:14:28 AM7/25/23
to django-...@googlegroups.com
#34739: Implement GEOSEqualsIdentical method on geometry objects.
------------------------------------------+------------------------
Reporter: Olivier Tabone | Owner: nobody
Type: New feature | Status: new
Component: GIS | Version: dev
Severity: Normal | Keywords: gis
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------+------------------------
Recently released GEOS 3.12.0 exposes GEOSEqualsIdentical functions to
compare geometries.

This is not the same comparaison function as the ones already implemented:
GEOSEquals / GEOSEqualsExact.

See [https://github.com/libgeos/geos/pull/810 GEOS PR] for rationale.

GEOSEqualsIdentical is a good fit for equality of geometries and this
ticket would be a first step in the resolution of #25342.

This ticket would implement a method on geometry
`GEOSGeometryBase.equals_identical()` that calls GEOSEqualsIdentical if
available.

Assessing the compatibility with GEOS 3.12.0 is discussed in #34686.

--
Ticket URL: <https://code.djangoproject.com/ticket/34739>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jul 25, 2023, 1:03:12 PM7/25/23
to django-...@googlegroups.com
#34739: Implement GEOSEqualsIdentical method on geometry objects.
--------------------------------+------------------------------------

Reporter: Olivier Tabone | Owner: nobody
Type: New feature | Status: new
Component: GIS | Version: dev
Severity: Normal | Resolution:
Keywords: gis | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+------------------------------------
Changes (by Claude Paroz):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/34739#comment:1>

Django

unread,
Jul 25, 2023, 4:19:41 PM7/25/23
to django-...@googlegroups.com
#34739: Implement GEOSEqualsIdentical method on geometry objects.
--------------------------------+------------------------------------------
Reporter: Olivier Tabone | Owner: Olivier Tabone
Type: New feature | Status: assigned

Component: GIS | Version: dev
Severity: Normal | Resolution:
Keywords: gis | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+------------------------------------------
Changes (by Olivier Tabone):

* owner: nobody => Olivier Tabone
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/34739#comment:2>

Django

unread,
Aug 4, 2023, 4:51:30 AM8/4/23
to django-...@googlegroups.com
#34739: Implement GEOSEqualsIdentical method on geometry objects.
--------------------------------+------------------------------------------
Reporter: Olivier Tabone | Owner: Olivier Tabone
Type: New feature | Status: assigned
Component: GIS | Version: dev
Severity: Normal | Resolution:
Keywords: gis | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
--------------------------------+------------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1
* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/17146 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/34739#comment:3>

Django

unread,
Aug 4, 2023, 10:10:27 AM8/4/23
to django-...@googlegroups.com
#34739: Implement GEOSEqualsIdentical method on geometry objects.
--------------------------------+------------------------------------------
Reporter: Olivier Tabone | Owner: Olivier Tabone
Type: New feature | Status: assigned
Component: GIS | Version: dev
Severity: Normal | Resolution:
Keywords: gis | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------+------------------------------------------
Changes (by Olivier Tabone):

* needs_better_patch: 1 => 0


Comment:

PR updated after Mariusz's review

--
Ticket URL: <https://code.djangoproject.com/ticket/34739#comment:4>

Django

unread,
Aug 5, 2023, 12:06:45 PM8/5/23
to django-...@googlegroups.com
#34739: Implement GEOSEqualsIdentical method on geometry objects.
-------------------------------------+-------------------------------------

Reporter: Olivier Tabone | Owner: Olivier
| Tabone
Type: New feature | Status: assigned
Component: GIS | Version: dev
Severity: Normal | Resolution:
Keywords: gis | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/34739#comment:5>

Django

unread,
Aug 5, 2023, 2:25:40 PM8/5/23
to django-...@googlegroups.com
#34739: Implement GEOSEqualsIdentical method on geometry objects.
-------------------------------------+-------------------------------------
Reporter: Olivier Tabone | Owner: Olivier
| Tabone
Type: New feature | Status: closed
Component: GIS | Version: dev
Severity: Normal | Resolution: fixed

Keywords: gis | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"0f3b1a783dfa36cb23aae0bb954756d0edcd9fc1" 0f3b1a78]:
{{{
#!CommitTicketReference repository=""
revision="0f3b1a783dfa36cb23aae0bb954756d0edcd9fc1"
Fixed #34739 -- Added GEOSGeometry.equals_identical() method.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34739#comment:6>

Reply all
Reply to author
Forward
0 new messages