Re: [Django] #15799: Document what exception should be raised when trying to open non-existent file
Django
file
--------------------------------------+------------------------------------
Reporter: Jonas H. | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: File uploads/storage | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Collin Anderson):
* cc: Collin Anderson (added)
* needs_docs: 0 => 1
* type: New feature => Cleanup/optimization
* easy: 0 => 1
Comment:
`FileNotFoundError` was added in Python 3.3 / PEP 3151 and kinda fixed
this issue.
Could maybe help to document raising exceptions like `FileNotFoundError`
here https://docs.djangoproject.com/en/dev/howto/custom-file-storage/ ,
though probably doesn't need to be super thoroughly documented, as it
mostly should be similar to Python's open().
--
Ticket URL: <https://code.djangoproject.com/ticket/15799#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
file
Reporter: Jonas H. | Owner: Ashis Kar
Type: | Status: assigned
Cleanup/optimization |
Component: File | Version: dev
uploads/storage |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Ashis Kar):
* owner: nobody => Ashis Kar
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/15799#comment:5>
Django
file
-------------------------------------+-------------------------------------
Type: | Kugel
Cleanup/optimization | Status: assigned
Component: File | Version: dev
uploads/storage |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: nobody => Anthony Kugel
Django
file
-------------------------------------+-------------------------------------
Reporter: Jonas H. | Owner: Anthony
Type: | Kugel
Cleanup/optimization | Status: assigned
Component: File | Version: dev
uploads/storage |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_docs: 1 => 0
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/17144 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/15799#comment:6>
Django
file
-------------------------------------+-------------------------------------
Reporter: Jonas H. | Owner: Anthony
Type: | Kugel
Cleanup/optimization | Status: assigned
Component: File | Version: dev
uploads/storage |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/15799#comment:7>
Django
file
-------------------------------------+-------------------------------------
Reporter: Jonas H. | Owner: Anthony
Type: | Kugel
Cleanup/optimization | Status: assigned
Component: File | Version: dev
uploads/storage |
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/15799#comment:8>
Django
file
-------------------------------------+-------------------------------------
Reporter: Jonas H. | Owner: Anthony
Type: | Kugel
Component: File | Version: dev
uploads/storage |
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"8edaf07a28a3e3848ab1edbdcd2fdc25e6bd6015" 8edaf07a]:
{{{
#!CommitTicketReference repository=""
revision="8edaf07a28a3e3848ab1edbdcd2fdc25e6bd6015"
Fixed #15799 -- Doc'd that Storage._open() should raise FileNotFoundError
when file doesn't exist.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/15799#comment:9>
Django
file
-------------------------------------+-------------------------------------
Reporter: Jonas H. | Owner: Anthony
Type: | Kugel
Cleanup/optimization | Status: closed
Component: File | Version: dev
uploads/storage |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"a22aeef55551dc6827b11afcc994a342fca93453" a22aeef5]:
{{{
#!CommitTicketReference repository=""
revision="a22aeef55551dc6827b11afcc994a342fca93453"
[4.2.x] Fixed #15799 -- Doc'd that Storage._open() should raise
FileNotFoundError when file doesn't exist.
Backport of 8edaf07a28a3e3848ab1edbdcd2fdc25e6bd6015 from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/15799#comment:10>