[Django] #34677: Django Admin built-in password reset feature has UI issues

Django

unread,

Jun 24, 2023, 5:46:41 PM6/24/23

to django-...@googlegroups.com

#34677: Django Admin built-in password reset feature has UI issues
------------------------------------------+------------------------
Reporter: Yaniv Toledano | Owner: nobody
Type: Bug | Status: new
Component: Uncategorized | Version: 4.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 1 |
------------------------------------------+------------------------
The documentation refers to adding password reset features to the admin
site here:
https://docs.djangoproject.com/en/dev/ref/contrib/admin/#adding-a
-password-reset-feature.

The resulting pages are, however, visually inconsistent with the rest of
the admin.

Some examples:
1. Spacing is off.
2. No use of a `class="submit-row" ` css class which makes the button look
off.
3. Header is hardcoded to "Django administration" even though the rest of
the admin has a different branding (e.g., when set under
`admin.site.site_header`, `admin.site.site_title`, etc.).
4. The issues can be resolved here
https://github.com/django/django/tree/650ce967825aa192222391bfe3003c8d97e6f1d0/django/contrib/admin/templates/registration
(specifically only the `password_reset_` templates).

--
Ticket URL: <https://code.djangoproject.com/ticket/34677>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,

Jun 24, 2023, 5:48:40 PM6/24/23

to django-...@googlegroups.com

#34677: Django Admin built-in password reset feature has UI issues

-------------------------------+--------------------------------------
Reporter: yanivtoledano | Owner: nobody

Type: Bug | Status: new
Component: Uncategorized | Version: 4.2

Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1

-------------------------------+--------------------------------------
Changes (by yanivtoledano):

* Attachment "Screenshot 2023-06-24 at 22.48.18.png" added.

Django

unread,

Jun 24, 2023, 5:48:49 PM6/24/23

to django-...@googlegroups.com

#34677: Django Admin built-in password reset feature has UI issues
-------------------------------+--------------------------------------
Reporter: yanivtoledano | Owner: nobody
Type: Bug | Status: new
Component: Uncategorized | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by yanivtoledano):

* Attachment "Screenshot 2023-06-24 at 22.47.02.png" added.

Django

unread,

Jun 24, 2023, 5:51:05 PM6/24/23

to django-...@googlegroups.com

#34677: Django Admin built-in password reset feature has UI issues

--------------------------------+--------------------------------------
Reporter: Yaniv Toledano | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.2

--------------------------------+--------------------------------------
Changes (by Yaniv Toledano):

* component: Uncategorized => contrib.admin

--
Ticket URL: <https://code.djangoproject.com/ticket/34677#comment:1>

Django

unread,

Jun 24, 2023, 11:17:02 PM6/24/23

to django-...@googlegroups.com

#34677: Django Admin built-in password reset feature has UI issues
--------------------------------+--------------------------------------
Reporter: Yaniv Toledano | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
--------------------------------+--------------------------------------

Comment (by Andrew Northall):

The header issues are due to the fact that the view providing the password
reset functionality is not actually part of the admin site, so the
`site_header` context variable is never inserted and reverts to the
default.

This does seem like behaviour which should at least be mentioned in the
documentation. An 'easy' solution to this particular problem would be to
update the documentation to give the following example code, which will
ensure the correct site header is used in the views:

{{{#!python
from django.contrib import admin

admin.site.site_header = "My Admin Site"

urlpatterns = [
path(
"admin/password_reset/",
auth_views.PasswordResetView.as_view(
extra_context={"site_header": admin.site.site_header}
),
name="admin_password_reset",
),
path(
"admin/password_reset/done/",
auth_views.PasswordResetDoneView.as_view(
extra_context={"site_header": admin.site.site_header}
),
name="password_reset_done",
),
path(
"reset/<uidb64>/<token>/",
auth_views.PasswordResetConfirmView.as_view(
extra_context={"site_header": admin.site.site_header}
),
name="password_reset_confirm",
),
path(
"reset/done/",
auth_views.PasswordResetCompleteView.as_view(
extra_context={"site_header": admin.site.site_header}
),
name="password_reset_complete",
),
path("admin/", admin.site.urls),
]
}}}

The alternative solutions to the header issue do not seem practical.

--
Ticket URL: <https://code.djangoproject.com/ticket/34677#comment:2>

Django

unread,

Jun 25, 2023, 6:09:29 AM6/25/23

to django-...@googlegroups.com

#34677: Django Admin built-in password reset feature has UI issues

-------------------------------------+-------------------------------------
Reporter: Yaniv Toledano | Owner: Priyank
| Panchal
Type: Bug | Status: assigned

-------------------------------------+-------------------------------------
Changes (by Priyank Panchal):

* owner: nobody => Priyank Panchal
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/34677#comment:3>

Django

unread,

Jun 26, 2023, 1:09:37 PM6/26/23

to django-...@googlegroups.com

#34677: Django Admin built-in password reset feature has UI issues
-------------------------------------+-------------------------------------
Reporter: Yaniv Toledano | Owner: Priyank

Type: | Panchal
Cleanup/optimization | Status: assigned

Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Natalia Bidart):

* type: Bug => Cleanup/optimization
* stage: Unreviewed => Accepted

Comment:

Accepting considering I have reproduced the issue about lack of
consistency for admin site header/title and button CSS. I think the
solution for the former should be to update the docs, but do note that we
should provide a code snippet that sets all the relevant variables.

--
Ticket URL: <https://code.djangoproject.com/ticket/34677#comment:4>

Django

unread,

Jun 26, 2023, 1:32:20 PM6/26/23

to django-...@googlegroups.com

#34677: Django Admin built-in password reset feature has UI issues
-------------------------------------+-------------------------------------
Reporter: Yaniv Toledano | Owner: Priyank
Type: | Panchal
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Natalia Bidart):

Is worth noting that the lack of `class="submit-row"` affects more than
one template, so all password reset related templates should be
audited/fixed.

unread,

Jul 6, 2023, 12:07:43 AM7/6/23

to django-...@googlegroups.com

#34677: Django Admin built-in password reset feature has UI issues
-------------------------------------+-------------------------------------
Reporter: Yaniv Toledano | Owner: Priyank
Type: | Panchal
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1

* needs_tests: 0 => 1
* needs_docs: 0 => 1

Comment:

Priyank, please check
[https://code.djangoproject.com/ticket/34677#comment:4 comments].

unread,

Jul 14, 2023, 7:09:28 AM7/14/23

to django-...@googlegroups.com

#34677: Django Admin built-in password reset feature has UI issues
-------------------------------------+-------------------------------------
Reporter: Yaniv Toledano | Owner: Priyank
Type: | Panchal

Cleanup/optimization | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution: fixed

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"0016a4299569a8f09ff24053ff2b8224f7fa4113" 0016a429]:
{{{
#!CommitTicketReference repository=""
revision="0016a4299569a8f09ff24053ff2b8224f7fa4113"
Fixed #34677 -- Made admin password reset templates more consistent.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34677#comment:15>

Reply all

Reply to author

Forward