[Django] #34621: Django admin site name shouldn’t be an h1

[Django]

#34621: Django admin site name shouldn’t be an h1
-------------------------------------+-------------------------------------
Reporter: Thibaud | Owner: Howard Cox
Colas |
Type: Bug | Status: assigned
Component: | Version: 4.2
contrib.admin | Keywords: accessibility,
Severity: Normal | screen reader
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
-------------------------------------+-------------------------------------
In the Django admin header, the site name ("Django administration" by
default) is currently set up as an `h1` tag. This is problematic for
screen reader users because they use headings to navigate – having two
`h1` is confusing, and the one in the header isn’t particularly helpful
since it’s the same on all pages.

It’d be better if this site name used a `p` or `div` tag. This switch will
also require rewriting the styles so they still work with the new tag.

--
Ticket URL: <https://code.djangoproject.com/ticket/34621>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#34621: Django admin site name shouldn’t be an h1
-------------------------------------+-------------------------------------

Reporter: Thibaud Colas | Owner: Howard
| Cox
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
screen reader |
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Thibaud Colas):

* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/34621#comment:1>

[Django]

#34621: Django admin site name shouldn’t be an h1
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Howard
| Cox
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
screen reader |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak):

Agreed.

For the future, please don't accept you're own tickets.

--
Ticket URL: <https://code.djangoproject.com/ticket/34621#comment:2>

[Django]

#34621: Django admin site name shouldn’t be an h1
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Howard
| Cox
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
screen reader |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Howard Cox):

[https://github.com/django/django/pull/16926 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/34621#comment:3>

[Django]

#34621: Django admin site name shouldn’t be an h1
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Howard
| Cox
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
screen reader |

Has patch: 1 | Needs documentation: 1

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* needs_docs: 0 => 1
* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/34621#comment:4>

[Django]

#34621: Django admin site name shouldn’t be an h1
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Howard
| Cox
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:

Keywords: accessibility, | Triage Stage: Ready for
screen reader | checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_docs: 1 => 0
* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/34621#comment:5>

[Django]

#34621: Django admin site name shouldn’t be an h1
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Howard
| Cox

Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution: fixed

Keywords: accessibility, | Triage Stage: Ready for
screen reader | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"cd413bd78ac65bd4282d26cc279bfd1bd4de707d" cd413bd7]:
{{{
#!CommitTicketReference repository=""
revision="cd413bd78ac65bd4282d26cc279bfd1bd4de707d"
Fixed #34621 -- Made admin site header render in <div> tag.

This was problematic for screen reader users because they use headings
to navigate. Having two <h1> is confusing, and the one in the header
wasn’t particularly helpful since it’s the same on all pages.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34621#comment:6>