[Django] #34592: admin css font does not need explicit apple fonts
Django
-----------------------------------------+---------------------------
Reporter: minusf | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Keywords: css, font
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 1 |
-----------------------------------------+---------------------------
https://caniuse.com/?search=system-ui
`system-ui` is supported now everywhere and `-apple-system,
BlinkMacSystemFont` is not required anymore.
i can make a github PR but the diff is trivial and attaching it here
--
Ticket URL: <https://code.djangoproject.com/ticket/34592>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: minusf | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.admin | Version: dev
Keywords: css, font | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by minusf):
* Attachment "admin_css.diff" added.
Django
Reporter: minusf | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Natalia Bidart):
* type: Uncategorized => Cleanup/optimization
* stage: Unreviewed => Accepted
Comment:
Tentatively accepting this ticket based on [https://developer.mozilla.org
/en-US/docs/Web/CSS/font-family#browser_compatibility this link from
mozilla docs] and [https://css-tricks.com/snippets/css/system-font-stack/
this other, less official, link].
The patch should ideally be a PR, minusf any chance you could do that?
--
Ticket URL: <https://code.djangoproject.com/ticket/34592#comment:1>
Django
--------------------------------------+------------------------------------
Reporter: minusf | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: css, font | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
--------------------------------------+------------------------------------
* cc: Tom Carrick (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/34592#comment:2>
Django
--------------------------------------+------------------------------------
Reporter: minusf | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: css, font | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
--------------------------------------+------------------------------------
Comment (by minusf):
hello.
tada: https://github.com/django/django/pull/16893
--
Ticket URL: <https://code.djangoproject.com/ticket/34592#comment:3>
Django
--------------------------------------+------------------------------------
Type: Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: css, font | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
--------------------------------------+------------------------------------
* owner: nobody => minusf
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/34592#comment:4>
Django
Reporter: minusf | Owner: minusf
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Mariusz Felisiak):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/34592#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: minusf | Owner: minusf
Cleanup/optimization |
Component: contrib.admin | Version: dev
Keywords: css, font | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"8b053c1e3c3dc50a73e471e4edcd2171fc24a7ec" 8b053c1e]:
{{{
#!CommitTicketReference repository=""
revision="8b053c1e3c3dc50a73e471e4edcd2171fc24a7ec"
Fixed #34592 -- Removed Safari/Chrome workaround for system fonts.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34592#comment:6>