Re: [Django] #34518: "random" template filter crashes on an empty list.

[Django]

#34518: "random" template filter crashes on an empty list.
------------------------------------+------------------------------------
Reporter: Алексей Поклонский | Owner: nobody
Type: Bug | Status: new
Component: Template system | Version: 4.0
Severity: Normal | Resolution:
Keywords: random templates | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------------+------------------------------------

Comment (by David Sanders):

Thanks for the report 👍

I think random should behave gracefully.

--
Ticket URL: <https://code.djangoproject.com/ticket/34518#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#34518: "random" template filter crashes on an empty list.

-------------------------------------+-------------------------------------
Reporter: Алексей Поклонский | Owner: Aman
| Pandey
Type: Bug | Status: assigned

Component: Template system | Version: 4.0
Severity: Normal | Resolution:
Keywords: random templates | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Aman Pandey):

* owner: nobody => Aman Pandey
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/34518#comment:4>

[Django]

#34518: "random" template filter crashes on an empty list.
-------------------------------------+-------------------------------------
Reporter: Алексей Поклонский | Owner: Aman
| Pandey
Type: Bug | Status: assigned
Component: Template system | Version: 4.0
Severity: Normal | Resolution:
Keywords: random templates | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* easy: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/34518#comment:5>

[Django]

#34518: "random" template filter crashes on an empty list.
-------------------------------------+-------------------------------------

Reporter: Алексей Поклонский | Owner: David
| Sanders

Type: Bug | Status: assigned
Component: Template system | Version: 4.0
Severity: Normal | Resolution:
Keywords: random templates | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by David Sanders):

* owner: Aman Pandey => David Sanders
* has_patch: 0 => 1

Comment:

Sorry Aman I just submitted a PR… I didn't see you take ownership as my
window was out-of-date.

--
Ticket URL: <https://code.djangoproject.com/ticket/34518#comment:6>

[Django]

#34518: "random" template filter crashes on an empty list.
-------------------------------------+-------------------------------------
Reporter: Алексей Поклонский | Owner: David
| Sanders
Type: Bug | Status: assigned
Component: Template system | Version: 4.0
Severity: Normal | Resolution:
Keywords: random templates | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Aman Pandey):

* has_patch: 1 => 0
* easy: 1 => 0

Comment:

It's totally fine : )

--
Ticket URL: <https://code.djangoproject.com/ticket/34518#comment:7>

[Django]

#34518: "random" template filter crashes on an empty list.
-------------------------------------+-------------------------------------
Reporter: Алексей Поклонский | Owner: David
| Sanders
Type: Bug | Status: assigned
Component: Template system | Version: 4.0
Severity: Normal | Resolution:

Keywords: random templates | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* has_patch: 0 => 1

* easy: 0 => 1

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/34518#comment:8>

[Django]

#34518: "random" template filter crashes on an empty list.
-------------------------------------+-------------------------------------
Reporter: Алексей Поклонский | Owner: David
| Sanders

Type: Bug | Status: closed

Component: Template system | Version: 4.0

Severity: Normal | Resolution: fixed

Keywords: random templates | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"7d0e56620882c207998a41ac07ec5da572045b31" 7d0e566]:
{{{
#!CommitTicketReference repository=""
revision="7d0e56620882c207998a41ac07ec5da572045b31"
Fixed #34518 -- Fixed crash of random() template filter with an empty
list.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34518#comment:9>