[Django] #34512: Admin missing breadcrumbs in app index
Django
-----------------------------------------+------------------------
Reporter: Adam | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
Breadcrumbs appear on the change list page (e.g. /admin/auth/group/ and
/admin/auth/user/), as expected. However, they do not appear on the app
index page (e.g. /admin/auth/) as they did in previous versions of Django.
--
Ticket URL: <https://code.djangoproject.com/ticket/34512>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Adam | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by David Sanders):
* status: new => closed
* resolution: => wontfix
Comment:
Hi Adam,
Thanks for the suggestion but there was a lot of discussion around
breadcrumbs agreed to leave them out of the main index page in this PR:
https://github.com/django/django/pull/12159
If you want you can start a discussion on the Django Forum or the mailing
list on whether it would make sense to include it:
https://code.djangoproject.com/wiki/DevelopersMailingList
Thanks!
--
Ticket URL: <https://code.djangoproject.com/ticket/34512#comment:1>
Django
-------------------------------+--------------------------------------
Reporter: Adam | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Comment (by Adam):
Just to be clear, I am not talking about the MAIN index page, I am talking
about the APP index page. The APP index page definitely looks like it's
still meant to include breadcrumbs
([https://github.com/django/django/blob/4.2/django/contrib/admin/templates/admin/app_index.html#L7-L15
source]), but it doesn't work anymore because of the way the "breadcrumbs"
block was changed to include a `<nav>` element.
--
Ticket URL: <https://code.djangoproject.com/ticket/34512#comment:2>
Django
-------------------------------+------------------------------------
Type: Bug | Status: new
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
* status: closed => new
* resolution: wontfix =>
* stage: Unreviewed => Accepted
Comment:
Hi Adam,
Apologies, thanks for the link you pasted (& your patience!), that does
seem peculiar.
Reopening; after investigating I see that
872b61193b013a700ff88cf50f0eb2cf2c266ff7 changes behaviour causing the
breadcrumbs in the app index to disappear.
--
Ticket URL: <https://code.djangoproject.com/ticket/34512#comment:3>
Django
Reporter: Adam | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.2
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* cc: Florian Perucki (added)
* severity: Normal => Release blocker
Comment:
Regression in 872b61193b013a700ff88cf50f0eb2cf2c266ff7.
--
Ticket URL: <https://code.djangoproject.com/ticket/34512#comment:4>
Django
---------------------------------+------------------------------------
Reporter: Adam | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
* cc: David Sanders (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/34512#comment:5>
Django
---------------------------------+------------------------------------
Reporter: Adam | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
* cc: Thibaud Colas (added)
Comment:
Adam, thanks for the report! What do you think about the following patch?
An empty `<nav>` shouldn't be an issue.
{{{#!diff
diff --git a/django/contrib/admin/templates/admin/index.html
b/django/contrib/admin/templates/admin/index.html
index af4f26dec5..5674264093 100644
--- a/django/contrib/admin/templates/admin/index.html
+++ b/django/contrib/admin/templates/admin/index.html
@@ -7,7 +7,7 @@
{% block bodyclass %}{{ block.super }} dashboard{% endblock %}
-{% block nav-breadcrumbs %}{% endblock %}
+{% block breadcrumbs %}{% endblock %}
{% block nav-sidebar %}{% endblock %}
}}}
Would you like to prepare a patch via GitHub PR? (a regression test is
required.)
--
Ticket URL: <https://code.djangoproject.com/ticket/34512#comment:6>
Django
---------------------------------+------------------------------------
Reporter: Adam | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Comment (by David Sanders):
I tested `<nav aria-label="Breadcrumbs"></nav>` using the macos screen
reader and it didn't read the label out. 👍 Not sure how other screen
readers would read it though? 🤔
The only concern I'd have with that is if someone adds to the nav-
breadcrumbs block in `base.html` not realising it would impact
`index.html` though sufficient test coverage would quickly highlight that
😊
--
Ticket URL: <https://code.djangoproject.com/ticket/34512#comment:7>
Django
Reporter: Adam | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* owner: nobody => Mariusz Felisiak
* status: new => assigned
* has_patch: 0 => 1
Comment:
It's probably safer to have some duplication here.
[https://github.com/django/django/pull/16799 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/34512#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: Adam | Owner: Mariusz
| Felisiak
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"9440f6ba41e5e96458cd7949fc6d605ef5bd09e9" 9440f6b]:
{{{
#!CommitTicketReference repository=""
revision="9440f6ba41e5e96458cd7949fc6d605ef5bd09e9"
Fixed #34512 -- Restored breadcrumbs on admin app index view.
Thanks Adam (ataylor32) for the report.
Regression in 872b61193b013a700ff88cf50f0eb2cf2c266ff7.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34512#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: Adam | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"fffbf850805a9cc7d07caa78df3f07880c85fdb8" fffbf850]:
{{{
#!CommitTicketReference repository=""
revision="fffbf850805a9cc7d07caa78df3f07880c85fdb8"
[4.2.x] Fixed #34512 -- Restored breadcrumbs on admin app index view.
Thanks Adam (ataylor32) for the report.
Regression in 872b61193b013a700ff88cf50f0eb2cf2c266ff7.
Backport of 9440f6ba41e5e96458cd7949fc6d605ef5bd09e9 from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34512#comment:10>