[Django] #34506: Visual regressions in admin's clearable file input.

3 views
Skip to first unread message

Django

unread,
Apr 21, 2023, 2:02:06 AM4/21/23
to django-...@googlegroups.com
#34506: Visual regressions in admin's clearable file input.
-------------------------------------+-------------------------------------
Reporter: Mariusz | Owner: Mariusz Felisiak
Felisiak |
Type: Bug | Status: assigned
Component: | Version: 4.2
contrib.admin |
Severity: Release | Keywords:
blocker |
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Margin for admin's clearable file input is incorrect:

Regression in 96a598356a9ea8c2c05b22cadc12e256a3b295fd.

--
Ticket URL: <https://code.djangoproject.com/ticket/34506>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 21, 2023, 2:02:45 AM4/21/23
to django-...@googlegroups.com
#34506: Visual regressions in admin's clearable file input.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Mariusz

| Felisiak
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* Attachment "Screenshot_20230421_080223.png" added.

Django

unread,
Apr 21, 2023, 2:04:04 AM4/21/23
to django-...@googlegroups.com
#34506: Visual regressions in admin's clearable file input.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Description changed by Mariusz Felisiak:

Old description:

> Margin for admin's clearable file input is incorrect:
>

>
> Regression in 96a598356a9ea8c2c05b22cadc12e256a3b295fd.

New description:

Margin for admin's clearable file input is incorrect:

[[Image(Screenshot_20230421_080223.png)​]]

Regression in 96a598356a9ea8c2c05b22cadc12e256a3b295fd.

--

--
Ticket URL: <https://code.djangoproject.com/ticket/34506#comment:1>

Django

unread,
Apr 21, 2023, 2:05:27 AM4/21/23
to django-...@googlegroups.com
#34506: Visual regressions in admin's clearable file input.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* Attachment "Screenshot_20230421_080223.png" removed.


--
Ticket URL: <https://code.djangoproject.com/ticket/34506>

Django

unread,
Apr 21, 2023, 2:05:28 AM4/21/23
to django-...@googlegroups.com
#34506: Visual regressions in admin's clearable file input.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* Attachment "Screenshot_20230421_080223.png" added.

bug

Django

unread,
Apr 21, 2023, 2:07:24 AM4/21/23
to django-...@googlegroups.com
#34506: Visual regressions in admin's clearable file input.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Description changed by Mariusz Felisiak:

Old description:

> Margin for admin's clearable file input is incorrect:
>

> [[Image(Screenshot_20230421_080223.png)​]]
>
> Regression in 96a598356a9ea8c2c05b22cadc12e256a3b295fd.

New description:

Margin for admin's clearable file input is incorrect:

[[Image(Screenshot_20230421_080223.png)]]
Regression in 96a598356a9ea8c2c05b22cadc12e256a3b295fd.

--

--
Ticket URL: <https://code.djangoproject.com/ticket/34506#comment:2>

Django

unread,
Apr 21, 2023, 2:15:49 AM4/21/23
to django-...@googlegroups.com
#34506: Visual regressions in admin's clearable file input.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/16789 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/34506#comment:3>

Django

unread,
Apr 21, 2023, 1:17:03 PM4/21/23
to django-...@googlegroups.com
#34506: Visual regressions in admin's clearable file input.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* cc: Natalia Bidart (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/34506#comment:4>

Django

unread,
Apr 21, 2023, 1:48:56 PM4/21/23
to django-...@googlegroups.com
#34506: Visual regressions in admin's clearable file input.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* stage: Unreviewed => Accepted


Comment:

Reproduced in c487634c106888effbba680e02269e489ab911a6

--
Ticket URL: <https://code.djangoproject.com/ticket/34506#comment:5>

Django

unread,
Apr 21, 2023, 1:49:05 PM4/21/23
to django-...@googlegroups.com
#34506: Visual regressions in admin's clearable file input.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/34506#comment:6>

Django

unread,
Apr 21, 2023, 1:50:18 PM4/21/23
to django-...@googlegroups.com
#34506: Visual regressions in admin's clearable file input.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"92537e83c1322c40dd39a8f0f9c78018307f2102" 92537e83]:
{{{
#!CommitTicketReference repository=""
revision="92537e83c1322c40dd39a8f0f9c78018307f2102"
Fixed #34506 -- Fixed margin of ClearableFileInput in admin CSS.

Regression in 96a598356a9ea8c2c05b22cadc12e256a3b295fd.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34506#comment:7>

Django

unread,
Apr 21, 2023, 1:52:45 PM4/21/23
to django-...@googlegroups.com
#34506: Visual regressions in admin's clearable file input.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"0a805cf42d0bb263114a1fa200ee13d6b3b8fdeb" 0a805cf4]:
{{{
#!CommitTicketReference repository=""
revision="0a805cf42d0bb263114a1fa200ee13d6b3b8fdeb"
[4.2.x] Fixed #34506 -- Fixed margin of ClearableFileInput in admin CSS.

Regression in 96a598356a9ea8c2c05b22cadc12e256a3b295fd.
Backport of 92537e83c1322c40dd39a8f0f9c78018307f2102 from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34506#comment:8>

Reply all
Reply to author
Forward
0 new messages