[Django] #34470: client_encoding is no longer set on PostgreSQL.

8 views
Skip to first unread message

Django

unread,
Apr 7, 2023, 1:59:42 AM4/7/23
to django-...@googlegroups.com
#34470: client_encoding is no longer set on PostgreSQL.
-------------------------------------+-------------------------------------
Reporter: Mariusz | Owner: nobody
Felisiak |
Type: Bug | Status: new
Component: Database | Version: 4.2
layer (models, ORM) |
Severity: Release | Keywords:
blocker |
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
`client_encoding` defined in `get_connection_params()` is always
overridden in the following
[https://github.com/django/django/blob/9daf8b4109c3e133eb57349bb44d73cc60c5773c/django/db/backends/postgresql/base.py#L212-L222
code].

Regression in 6a2165816394ab4bb259f6171e82417e098e97a6.

--
Ticket URL: <https://code.djangoproject.com/ticket/34470>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 7, 2023, 2:16:28 AM4/7/23
to django-...@googlegroups.com
#34470: client_encoding is no longer set on PostgreSQL.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: Database layer | Version: 4.2
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* owner: nobody => Mariusz Felisiak
* status: new => assigned


Comment:

By default, client encoding is the encoding defined by the database but we
should still enforce `utf-8`.

--
Ticket URL: <https://code.djangoproject.com/ticket/34470#comment:1>

Django

unread,
Apr 7, 2023, 2:29:03 AM4/7/23
to django-...@googlegroups.com
#34470: client_encoding is no longer set on PostgreSQL.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: Database layer | Version: 4.2
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/16739 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/34470#comment:2>

Reply all
Reply to author
Forward
0 new messages