Re: [Django] #34446: Coding style docs should contain incorrect example for Model style. (was: Code style - incorrect Model Style)

2 views
Skip to first unread message

Django

unread,
Mar 30, 2023, 3:06:13 AM3/30/23
to django-...@googlegroups.com
#34446: Coding style docs should contain incorrect example for Model style.
-------------------------------+------------------------------------
Reporter: JiriKr | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by Mariusz Felisiak):

* cc: Joseph V Zammit, Paolo Melchiorre (added)
* easy: 0 => 1
* stage: Unreviewed => Accepted


Comment:

Great catch! We should remove this blank line:
{{{#!diff
diff --git a/docs/internals/contributing/writing-code/coding-style.txt
b/docs/internals/contributing/writing-code/coding-style.txt
index 5b64e94b24..9b44be87b1 100644
--- a/docs/internals/contributing/writing-code/coding-style.txt
+++ b/docs/internals/contributing/writing-code/coding-style.txt
@@ -282,7 +282,6 @@ Model style
class Person(models.Model):
first_name = models.CharField(max_length=20)
last_name = models.CharField(max_length=40)
-
class Meta:
verbose_name_plural = "people"


}}}
I hope there is a way to skip `blacken-docs` on this example.

JiriKr, Would you like to prepare a patch?

--
Ticket URL: <https://code.djangoproject.com/ticket/34446#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Reply all
Reply to author
Forward
0 new messages