Re: [Django] #33826: delete_many()/set_many() crashes with empty values on Redis client .

[Django]

#33826: delete_many()/set_many() crashes with empty values on Redis client .
-------------------------------------+-------------------------------------
Reporter: Christos Kopanos | Owner: Christos
Type: | Kopanos
Cleanup/optimization | Status: assigned
Component: Core (Cache system) | Version: 4.0
Severity: Normal | Resolution:
Keywords: redis | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/33826#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#33826: delete_many()/set_many() crashes with empty values on Redis client .
-------------------------------------+-------------------------------------
Reporter: Christos Kopanos | Owner: Christos
Type: | Kopanos

Cleanup/optimization | Status: closed

Component: Core (Cache system) | Version: 4.0

Severity: Normal | Resolution: fixed

Keywords: redis | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"608ab043f75f1f9c094de57d2fd678f522bb8243" 608ab043]:
{{{
#!CommitTicketReference repository=""
revision="608ab043f75f1f9c094de57d2fd678f522bb8243"
Fixed #33826 -- Fixed RedisCache.set_many()/delete_many() crash with an
empty list.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33826#comment:4>

[Django]

#33826: delete_many()/set_many() crashes with empty values on Redis client .
-------------------------------------+-------------------------------------
Reporter: Christos Kopanos | Owner: Christos
Type: | Kopanos
Cleanup/optimization | Status: closed
Component: Core (Cache system) | Version: 4.0
Severity: Normal | Resolution: fixed
Keywords: redis | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Timothy Schilling):

I think there's benefit to backporting this change since other cache
backends handle this. Trying to convert from `django-redis-cache` to
Django core's Redis cache is difficult because any number of libraries may
be built with this expectation.

--
Ticket URL: <https://code.djangoproject.com/ticket/33826#comment:5>

[Django]

#33826: delete_many()/set_many() crashes with empty values on Redis client .
-------------------------------------+-------------------------------------
Reporter: Christos Kopanos | Owner: Christos
Type: | Kopanos
Cleanup/optimization | Status: closed
Component: Core (Cache system) | Version: 4.0
Severity: Normal | Resolution: fixed
Keywords: redis | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Timothy Schilling):

Ack, never mind. It's pretty easy to subclass the backend and override the
two functions to confirm that keys is truthy.

--
Ticket URL: <https://code.djangoproject.com/ticket/33826#comment:6>